aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBill Meier <wmeier@newsguy.com>2014-09-11 14:19:03 -0400
committerBill Meier <wmeier@newsguy.com>2014-09-11 18:43:59 +0000
commit0ec17938fdfb103e6a8375e9735c64bda5935c10 (patch)
tree9a839e00b84e18b42c3d926cd900d6a32897660c
parent6e81f1d18ce1209435c81df215e6bf1de5cf830b (diff)
packet-cfm.c: Update some comments; Add editor modelines.
- Indicate that ITU-T G.8013/Y.1731 (11/2013) is the latest spec (and that the cfm dissector has not been updated to reflect same). - Remove a comment about a "discrepancy in the recommendation ITU-T Y.1731". The discrepancy has been corrected in the latest spec. Change-Id: I5a5f873d2a0a5fdee3aef1688403bb317a155cdf Reviewed-on: https://code.wireshark.org/review/4081 Reviewed-by: Bill Meier <wmeier@newsguy.com>
-rw-r--r--epan/dissectors/packet-cfm.c32
1 files changed, 21 insertions, 11 deletions
diff --git a/epan/dissectors/packet-cfm.c b/epan/dissectors/packet-cfm.c
index 3f93914cf7..6b0bfb4522 100644
--- a/epan/dissectors/packet-cfm.c
+++ b/epan/dissectors/packet-cfm.c
@@ -24,12 +24,15 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
-/* This code is based on the IEEE P802.1ag/D8.1 document,
- * the ITU-T Rec. G.8031/Y.1342 (06/2011) - Ethernet linear protection switching document,
- * the ITU-T Rec. G.8032/Y.1344 (02/2012) - Ethernet ring protection switching document,
- * and on the ITU-T Y.1731 recommendation (05/2006,) which is not formally released
- * at the time of this dissector development.
- * Any updates to these documents may require additional modifications to this code.
+/* This code is based on the following documents;
+ * - IEEE P802.1ag/D8.1
+ * - ITU-T Rec. G.8031/Y.1342 (06/2011) - Ethernet linear protection switching
+ * - ITU-T Rec. G.8032/Y.1344 (02/2012) - Ethernet ring protection switching
+ * - ITU-T Y.1731 recommendation (05/2006,) which is not formally released
+ * at the time of this dissector development.
+ * Any updates to these documents may require additional modifications to this code.
+ * ITU-T G.8013/Y.1731 (11/2013) is the current version (as of Sep 11, 2014)
+ * ToDo: Update dissector to reflect this document.
*/
@@ -1515,11 +1518,6 @@ static void dissect_cfm(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
tlv_data_offset += cfm_tlv_length;
break;
case TEST_TLV:
- /* There is a discrepancy in the recommendation ITU-T Y.1731
- * where the test pattern type may or may not be included in
- * the TLV length. Going to assume that it is included in the
- * length which corresponds with the typical format for TLV's
- * until the recommendation is more clear in this regard. */
proto_tree_add_item(cfm_tlv_tree, hf_tlv_tst_test_pattern_type,
tvb, tlv_data_offset, 1, ENC_BIG_ENDIAN);
tlv_tst_test_pattern_type = tvb_get_guint8(tvb,tlv_data_offset);
@@ -2164,3 +2162,15 @@ void proto_reg_handoff_cfm(void)
dissector_add_uint("ethertype", ETHERTYPE_CFM, cfm_handle);
}
+/*
+ * Editor modelines - http://www.wireshark.org/tools/modelines.html
+ *
+ * Local variables:
+ * c-basic-offset: 8
+ * tab-width: 8
+ * indent-tabs-mode: t
+ * End:
+ *
+ * vi: set shiftwidth=8 tabstop=8 noexpandtab:
+ * :indentSize=8:tabSize=8:noTabs=false:
+ */