aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Thacker <johnthacker@gmail.com>2023-02-26 07:49:56 -0500
committerJohn Thacker <johnthacker@gmail.com>2023-02-27 01:56:30 +0000
commit4fa5e0f3c9e68338c3d1eb6082b7a050cb30611d (patch)
tree07d9c91cc4fd30bc4494ff69652aadc4fefda985
parent6f8eef82b47c7b1bcc0d3a0d9ddc8f82300e9175 (diff)
Qt: Fix some leaks in RTP Analysis windows
Parent the QActions that are created for Analyze and Play buttons for each RTP window, so that they are deleted when the button is deleted.
-rw-r--r--ui/qt/rtp_analysis_dialog.cpp2
-rw-r--r--ui/qt/rtp_player_dialog.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/ui/qt/rtp_analysis_dialog.cpp b/ui/qt/rtp_analysis_dialog.cpp
index ee59a9576d..5852555eb4 100644
--- a/ui/qt/rtp_analysis_dialog.cpp
+++ b/ui/qt/rtp_analysis_dialog.cpp
@@ -1142,7 +1142,7 @@ QToolButton *RtpAnalysisDialog::addAnalyzeButton(QDialogButtonBox *button_box, Q
analysis_button->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
analysis_button->setPopupMode(QToolButton::MenuButtonPopup);
- ca = new QAction(tr("&Analyze"));
+ ca = new QAction(tr("&Analyze"), analysis_button);
ca->setToolTip(tr("Open the analysis window for the selected stream(s)"));
connect(ca, SIGNAL(triggered()), dialog, SLOT(rtpAnalysisReplace()));
analysis_button->setDefaultAction(ca);
diff --git a/ui/qt/rtp_player_dialog.cpp b/ui/qt/rtp_player_dialog.cpp
index e284262816..9096b22fea 100644
--- a/ui/qt/rtp_player_dialog.cpp
+++ b/ui/qt/rtp_player_dialog.cpp
@@ -359,7 +359,7 @@ QToolButton *RtpPlayerDialog::addPlayerButton(QDialogButtonBox *button_box, QDia
player_button->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
player_button->setPopupMode(QToolButton::MenuButtonPopup);
- ca = new QAction(tr("&Play Streams"));
+ ca = new QAction(tr("&Play Streams"), player_button);
ca->setToolTip(tr("Open RTP player dialog"));
ca->setIcon(StockIcon("media-playback-start"));
connect(ca, SIGNAL(triggered()), dialog, SLOT(rtpPlayerReplace()));