aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarien Spencer <cusneud@mail.com>2018-09-11 18:37:12 +0300
committerAnders Broman <a.broman58@gmail.com>2018-09-12 19:38:57 +0000
commit5c7dae133754fbed20647609b262ef24c52620f8 (patch)
tree1c5ab6c67cae2d014d06ee826c8396bc39c32286
parente31ca2e278614d7c21a7912641a274994ad80e70 (diff)
AT: Fix rejection values
Dissect functions for CNUM/VTS were returning TRUE for all wrong role/type combinations instead of FALSE ( = Rejecting the parameter ) Change-Id: I1aae5b76db83cef6b59f5244c05a67b2110f8969 Reviewed-on: https://code.wireshark.org/review/29634 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
-rw-r--r--epan/dissectors/packet-at.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-at.c b/epan/dissectors/packet-at.c
index 3553c62..8699d60 100644
--- a/epan/dissectors/packet-at.c
+++ b/epan/dissectors/packet-at.c
@@ -1255,7 +1255,7 @@ dissect_cnum_parameter(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
proto_item *pitem;
guint32 value;
- if (!(role == ROLE_DCE && type == TYPE_RESPONSE)) return TRUE;
+ if (!(role == ROLE_DCE && type == TYPE_RESPONSE)) return FALSE;
if (parameter_number > 5) return FALSE;
switch (parameter_number) {
@@ -1600,7 +1600,7 @@ dissect_vts_parameter(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
proto_item *pitem;
guint32 value;
- if (!(role == ROLE_DTE && type == TYPE_ACTION)) return TRUE;
+ if (!(role == ROLE_DTE && type == TYPE_ACTION)) return FALSE;
if (parameter_number > 1) return FALSE;
switch (parameter_number) {