diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-06-10 15:05:23 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-06-10 22:11:35 +0000 |
| commit | b8779f9b59921e07b7d5318242dce12d12c53450 (patch) | |
| tree | cef2304a565bee4dcfd7729cd677c87ffd8a1643 | |
| parent | 8626cefd114ff49c6e3a763b72ba26b5bec06a1e (diff) | |
More comment clarification.
That's not "the biggest record we're willing to write", it's "the
biggest record the pcapng format supports, as the record length is a
16-bit field".
Change-Id: Icbd5e0cc4ed8e2a3a0d474245a9b9ed2c999d520
Reviewed-on: https://code.wireshark.org/review/15818
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 09de28933f9a17d4472206e1ac4b7c92001e44f5)
Reviewed-on: https://code.wireshark.org/review/15820
| -rw-r--r-- | wiretap/pcapng.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/wiretap/pcapng.c b/wiretap/pcapng.c index e9652dcc67..4f2d90428e 100644 --- a/wiretap/pcapng.c +++ b/wiretap/pcapng.c @@ -3131,7 +3131,8 @@ pcapng_write_name_resolution_block(wtap_dumper *wdh, int *err) hostnamelen = strlen(ipv4_hash_list_entry->name); if (hostnamelen > (G_MAXUINT16 - 4) - 1) { /* - * This won't fit in a maximum-sized record; discard it. + * This won't fit in the largest possible NRB record; + * discard it. */ i++; ipv4_hash_list_entry = (hashipv4_t *)g_list_nth_data(wdh->addrinfo_lists->ipv4_addr_list, i); @@ -3200,7 +3201,8 @@ pcapng_write_name_resolution_block(wtap_dumper *wdh, int *err) hostnamelen = strlen(ipv6_hash_list_entry->name); if (hostnamelen > (G_MAXUINT16 - 16) - 1) { /* - * This won't fit in a maximum-sized record; discard it. + * This won't fit in the largest possible NRB record; + * discard it. */ i++; ipv6_hash_list_entry = (hashipv6_t *)g_list_nth_data(wdh->addrinfo_lists->ipv6_addr_list, i); |