From c20f9bb5cd2491169959922ce1ba249a34f589aa Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Tue, 6 Mar 2018 02:11:06 +0700 Subject: fake_trx/ctrl_if.py: remove incorrect isdigit() check Previously, we used to check if all arguments of a command are numeric. This was done in a wrong way, so parsing a *valid* command with at least one negative argument could fail. Let's remove this check, allowing the command handlers to deal with argument types themselves. Change-Id: If31295274a09102c414b5a7aec5dd85d88b2e514 --- src/target/fake_trx/ctrl_if.py | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src') diff --git a/src/target/fake_trx/ctrl_if.py b/src/target/fake_trx/ctrl_if.py index d4840cde..af124f65 100644 --- a/src/target/fake_trx/ctrl_if.py +++ b/src/target/fake_trx/ctrl_if.py @@ -60,11 +60,6 @@ class CTRLInterface(UDPLink): if len(request) - 1 != argc: return False - # Check if all arguments are numeric - for v in request[1:]: - if not v.isdigit(): - return False - return True def send_response(self, request, remote, response_code, params = None): -- cgit v1.2.3