summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-11-26mobile: Do not print MDL-Error 'ignoring' and then aborting anyway.zecke/work-with-nitbHolger Hans Peter Freyther1-10/+2
The current code mentioned it will ignore the MDL-Error and then printed it will abort. Only print the abortion message and print the RSL error name.
2012-11-26mobile: Do the LU with a IMSI... to deal with changing NITBs..Holger Hans Peter Freyther1-1/+1
NITB will not ask for the IMSI if the TMSI is not known... work around and do the LU with the IMSI..
2012-11-25rxqual: Begin to implement the rxqual calculationHolger Hans Peter Freyther7-25/+57
* Make num_biterr 16bit because the API is 16bit. * Add the num_bits to count the bits transferred. * Re-order and add manual padding due the increase in size. * Add the bits to struct rx_meas_stat, increment and reset them. * Calculation for the sub_rxqual is missing, so is DTX code in general * Calculation for TCH/F, TCH/H in speech mode might be wrong
2012-11-22Rename various "rxlev" variable to "rxlev_dbm" and correct their signessAndreas Eversberg10-47/+47
All levels in range of 0..63 are now uint8_t and use "rxlev" as variable name. All levels in range of -110..-47 are now int8_t and use "rxlev_dbm" as variable name.
2012-11-22fix previous commit: use dbm2rxlev()Harald Welte2-2/+2
As andreas points out, there are structure members that are called 'rxlev' but which don't use the scaling (0..63) of the GSM specs, but which are already a signed type and in dBm. So they need to be converted. TODO: Rename those structure members to rxlev_dbm or something that explicitly states it is _not_ an 'RXLEV' value in terms of GSM.
2012-11-20Tell L1CTL_FBSB_REQ the expected received signal levelHarald Welte9-8/+14
As Dieter points out, this drastically improves the resiliance to high receive levels on the C155. We cannot blindly assume a received signal level of -85 dBm if the BTS is 2m away and we actually receive -40 dBm. This patch extends the L1CTL_FBSB_REQ data structure in layer 1 with the respective field, as well as the l1ctl_tx_fbsb_req() API function called from the various layer23 apps. "mobile" and "bcch_scan" already did a PM request and thus know the expected signal power. "ccch_scan" and "cbch_sniff" apparently don't do, so the -85 dBm constant is now hardcoded into the host-side source code there, and should probably be fixed in a follow-up patch.
2012-11-16Fix wrong print of scan freq when using gsm_print_arfcn twice for the same ↵Pavel Baturko1-4/+12
log message
2012-11-15Fix: Correctly convert ARFCN to index.Joshua Lackey1-1/+4
If you enable PCS, you'll never make it out of power-measurement without this patch.
2012-11-14Merge commit '5905d5be60249b2d9ca9abce4c801bc3bceed6d9'Sylvain Munaut16-24/+48
2012-11-14msgb: fix msgb_pull_u*()Steve Markgraf1-3/+3
msgb_pull returns a pointer to the new begin of the buffer, unlike msgb_get(), where those functions were originally taken from. Signed-off-by: Steve Markgraf <steve@steve-m.de>
2012-11-14fw/comm: remove unused, outdated copy of msgb.hSteve Markgraf1-161/+0
Signed-off-by: Steve Markgraf <steve@steve-m.de>
2012-11-14smc: Fix a typo in the smc codeHolger Hans Peter Freyther1-1/+1
2012-11-14smc: Make it possible to include gsm0411_smc.h as first header fileHolger Hans Peter Freyther1-0/+1
The code embeds the timer so one needs to include the header file.
2012-11-11smc: Print the current state of the SMSHolger Hans Peter Freyther1-1/+3
When the connection may not released print the name of the current state to ease with debugging and verification that this is not a valid state transition.
2012-11-11sms: Remove the commented out code that was the default in OpenBSCHolger Hans Peter Freyther1-1/+0
This code got copied from OpenBSC and we used the network specific and private numbering plan. Remove it as it can be easily set.
2012-11-11sms: Reduce the logging level to debugHolger Hans Peter Freyther1-3/+3
<001c> gsm0411_smr.c:175 TX: MNSMS-REL-REQ adds little value so I am reducing it to a debug statement.
2012-11-06debian: Create a git-buildpackage based 0.5.3Holger Hans Peter Freyther2-1/+7
2012-11-05debian: Testing was disabled because of a funny x86 compiler issue caused by usHolger Hans Peter Freyther1-5/+0
The bits test will fail on Debian Stable for x86. Somehow the load of a static const array is ending up accessing random memory. This only happens when not using any -OX options and this is caused by us. Do not override the default debian CFLAGS.. and the tests will pass on debian stable.
2012-11-05GSM48: Avoid unaligned access in gsm48_construct_raAndreas Eversberg1-1/+3
This avoids an unaligned access on platforms that don't support them, such as ARMv4/ARMv5.
2012-10-30Fix: Change T200 of LAPDm if SAPI 0 and SAPI 3 share bandwidth on SDCCHAndreas Eversberg3-0/+42
We use 1 second on FACCH and 2 seconds on SACCH when SMS is transfered during a call on TCH. There is no impact on bandwidth, because SAPIs use differen channels. In order to correctly transfer SMS during SDCCH, the T200 must be raised from 1 (SAPI 0) to 2 (SAPI 0 and 3), so T200 will not timeout before receiving acknowledge from BTS. This is because both SAPIs share the same ressource on SDCCH. After release of SAPI 3, T200 is lowered back to 1.
2012-10-30Fixed decoding of hexadecimal LAI componentsAndreas Eversberg6-27/+44
libosmocore has changed its LAI decoding from hex to decimal. This caused wrong decoding of MCC and MNC. In order to provide required hex transcoding, special hex encoding and decoding function are added to mobile/sysinfo.c.
2012-10-27Add "extern" keywordsTobias Engel1-5/+5
Without the "extern" keyword the variables in this header file will be seen as empty definitions when compiled on OSX.
2012-10-27Do not use --version-script linker flag on OSXTobias Engel3-2/+14
Add a check to not use --version-script linker flag if compiled on OSX since it doesn't exist there
2012-10-27Define struct iphdr for OSXTobias Engel1-1/+1
Use FreeBSD struct iphdr definition for OSX also. From the commentary in the source file: On BSD the IPv4 struct is called struct ip and instead of iXX the members are called ip_XX. One could change this code to use struct ip but that would require to define _BSD_SOURCE and that might have other complications. Instead make sure struct iphdr is present on FreeBSD.
2012-10-22logging: Make sure to install standard "end" command in VTY nodeHarald Welte2-0/+3
When you are in the config-log VTY node, you expect "end" to work like in any other sub-node of config.
2012-10-22logging: Don't forget to save "logging filter all 1"Harald Welte1-0/+4
Prior to this fix, a persistent file or syslog log configuration didn't work across an application re-start, as the "logging filter all 1" was never saved and thus no messages were logged.
2012-10-14Merge commit 'b8d18f32a1676f05d73bc9d94eadeaf5cc43c9a5'Sylvain Munaut20-93/+440
2012-10-01Drop unused imports from the python utilities.Paul Wise2-2/+0
2012-09-30Doc: Adding new parameter descriptions in gprs_bssgp_bss.cAndreas Eversberg1-1/+9
2012-09-30Fix: Correcting bssgp_tx_fc_bvc, bssgp_tx_fc_ms, bssgp_tx_ul_udAndreas Eversberg3-11/+30
2012-09-29Fix: gprs_ns_destroy() now frees all NSVCs and its timersAndreas Eversberg1-4/+14
Freeing memory of registered timers and file descriptors cause corrupt lists.
2012-09-27logging: Modify the testcase to excercise Nico's fixHolger Hans Peter Freyther1-1/+1
2012-09-27logging: Move the logging test from OpenBSC into libosmocoreHolger Hans Peter Freyther6-2/+94
Add a testcase for the logging facility. The test is coming from the OpenBSC code.
2012-09-27logging.c: Do not crash on empty category nameNico Golde1-5/+7
log_parse_category_mask(), skip log category name right away if name is NULL to prevent passing a NULL ptr to strlen.
2012-09-21gsm_utils.c: in 7bit decoding, first check if the last character was an ↵Nico Golde1-5/+5
extension character before doing anything else
2012-09-20gsm_utils: Fix up coding style in previous patchHarald Welte1-2/+2
'if' is not a function, so we have space before parenthesis.
2012-09-20build: fix directory creation for core headers, introduced by d471a219.Nico Golde1-1/+1
2012-09-20gsm_utils.c: cleanup + do not use dynamic memory when decoding 7bit messagesNico Golde1-14/+13
2012-09-17Fix linking with GNU ld 2.22 and libgpsKevin Redon4-6/+9
Error: gcc -Wall -I/home/kevredon/osmocom-bb/src/shared/libosmocore/include -I/home/kevredon/osmocom-bb/src/shared/libosmocore/include -g -O2 -D_HAVE_GPSD -lgps -o cell_log main.o app_cell_log.o cell_log.o geo.o ../common/liblayer23.a /home/kevredon/osmocom-bb/src/shared/libosmocore/build-host/src/.libs/libosmocore.a /home/kevredon/osmocom-bb/src/shared/libosmocore/build-host/src/gsm/.libs/libosmogsm.a /home/kevredon/osmocom-bb/src/shared/libosmocore/build-host/src/codec/.libs/libosmocodec.a -lm ../common/liblayer23.a(gps.o): In function `osmo_gpsd_cb': /home/kevredon/osmocom-bb/src/host/layer23/src/common/gps.c:79: undefined reference to `gps_waiting' Fix: Holger told me to do so (he knows better then me about autoconf) - set CFLAGS and LIBS for LIBGPS in layer23 - add libgps CFLAGS and LIBS in Makefile.am for common, misc, mobile I would have done the following (which also works): -AC_CHECK_LIB(gps, gps_waiting, CFLAGS+=" -D_HAVE_GPSD" LDFLAGS+=" -lgps",,) +AC_CHECK_LIB(gps, gps_waiting, CFLAGS+=" -D_HAVE_GPSD" LDFLAGS+=" -lgps" LIBS+=" -lgps",,)
2012-09-17Fix build with dpkg-buildpackage.Max2-0/+11
2012-09-11git: Ignore generated tests executablesHolger Hans Peter Freyther1-0/+2
2012-09-11vty: Include osmocom/core/utils.h for the value_string structHolger Hans Peter Freyther1-0/+1
2012-09-11tests: Make the gb test work with srcdir != builddirHolger Hans Peter Freyther4-53/+56
* Disable color and printing the filename of the stderr log target, update the results * Add the .ok, .err and .sh files to the extra_dist * Execute the shell script from the source directory
2012-09-11logging: Introduce a print_filename flag for the logtargetHolger Hans Peter Freyther2-5/+20
Introduce a print_filename attribute for each logtarget. Initialize it with 1 to be backward compatible with earlier versions. The bit is taken from an existint bitfield. There were at least six bits left of the byte.
2012-09-11vty: Address compiler warning about the const qualifierHolger Hans Peter Freyther1-1/+1
vty.c: In function 'vty_out_newline': vty.c:294:12: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
2012-09-11vty: Address compiler warning about tolowerHolger Hans Peter Freyther1-0/+1
Include ctype.h to have a declaration of tolower. utils.c: In function 'vty_cmd_string_from_valstr': utils.c:95:6: warning: implicit declaration of function 'tolower' [-Wimplicit-function-declaration]
2012-09-11gsm: Address compiler warning about unused variable 'z'Holger Hans Peter Freyther1-3/+4
The comment explains why we don't care about the content of z, stop storing it. gsm_utils.c: In function 'gsm_7bit_encode': gsm_utils.c:253:13: warning: variable 'z' set but not used [-Wunused-but-set-variable]
2012-09-11logging: Mark the log_info_cat pointer as constsHolger Hans Peter Freyther2-3/+4
Applications should keep the log area in a static const area. Mark the pointer as const to address compiler warnings in OpenBSC, cast the const away for the osmo_log_info as it is not declared as const.
2012-09-10Gb: Add functions for sending flow control messages from BSS sideHarald Welte2-0/+113
2012-09-10Gb: Add header file for BSS-side BSSGP functionsHarald Welte3-0/+69
.. not sure how we could have missed that so far.