diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2018-03-09 06:34:04 +0700 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-03-11 10:05:48 +0000 |
| commit | 2136891b7bbdfbd62f28f63c8a16711d9562ec1c (patch) | |
| tree | c3c07e1c856d2e506895c4388e375c38b60a2464 /src/host/trxcon/l1ctl.c | |
| parent | a92fd3388cd7eac69e18938832be688c9a425613 (diff) | |
trxcon: clarify L1CTL message length field
Each L1CTL message gets its own length pushed in front before
sending. This isn't specified in the 'l1ctl_proto.h', but
assumed in the code. Let's clarify this.
Change-Id: I118d00613aeaf5ff0bad1188fa5f7450d4ca8122
Diffstat (limited to 'src/host/trxcon/l1ctl.c')
| -rw-r--r-- | src/host/trxcon/l1ctl.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index 58b8a4ff..f138b88c 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -49,8 +49,14 @@ static struct msgb *l1ctl_alloc_msg(uint8_t msg_type) { struct l1ctl_hdr *l1h; - struct msgb *msg = msgb_alloc_headroom(256, 4, "l1ctl_tx_msg"); + struct msgb *msg; + /** + * Each L1CTL message gets its own length pushed in front + * before sending. This is why we need this small headroom. + */ + msg = msgb_alloc_headroom(L1CTL_LENGTH + L1CTL_MSG_LEN_FIELD, + L1CTL_MSG_LEN_FIELD, "l1ctl_tx_msg"); if (!msg) { LOGP(DL1C, LOGL_ERROR, "Failed to allocate memory\n"); return NULL; |