path: root/src/host/layer23/src/mobile/gsm48_cc.c
diff options
authorHolger Hans Peter Freyther <>2017-11-15 12:25:47 +0100
committerHolger Hans Peter Freyther <>2017-11-27 17:54:03 +0800
commiteddf339871559f282fe615f9c618a1220bd97743 (patch)
treeb8fd59a2eb1b45cde02c6cb34ae26f7d89e07e56 /src/host/layer23/src/mobile/gsm48_cc.c
parent65774d447d8623257e1cbf3694542f4a421017d7 (diff)
mobile: Instead of putting semantic in a comment, use an enum
The enum was created to understand the different states during the shutdown and find places where it is used. The normal transitions are like. Idle -> Imsi Detach -> L1 Reset -> Done Idle -> L1 Reset -> Done The shutdown can get stuck in case: * Out of memory situation while handling IMSI detach (timeout) * Never receiving l1 reset acknnowledgment. The code could benefit from the move to osmo fsm to deal with proper timeouts. Change-Id: Iee1140e4848923c7270495c381bf87b7e3fddee1
Diffstat (limited to 'src/host/layer23/src/mobile/gsm48_cc.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c
index d398c765..f1e81098 100644
--- a/src/host/layer23/src/mobile/gsm48_cc.c
+++ b/src/host/layer23/src/mobile/gsm48_cc.c
@@ -1923,7 +1923,7 @@ int mncc_tx_to_cc(void *inst, int msg_type, void *arg)
struct gsm_trans *trans;
int i, rc;
- if (!ms->started || ms->shutdown) {
+ if (!ms->started || ms->shutdown != MS_SHUTDOWN_NONE) {
LOGP(DCC, LOGL_NOTICE, "Phone is down!\n");
if (ms->mncc_entity.mncc_recv && msg_type != MNCC_REL_REQ) {
struct gsm_mncc rel;