summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2018-03-06 02:25:51 +0700
committerVadim Yanitskiy <axilirator@gmail.com>2018-03-06 02:28:37 +0700
commit59d054906d1d5bd6f21fb6072ead0f76b6e5f27a (patch)
treeaaabf325a77af0d687fe21e8d3b8e73f5e664db6
parentf97e3cd7882dff977973a2f29606c594f02c0b36 (diff)
fake_trx/ctrl_if.py: reduce code branch nasting
Let's use the inverted condition to avoid additional code nasting. Change-Id: I8a62b39d9d9a597c612f9a576e98dc05e37cd25b
-rw-r--r--src/target/fake_trx/ctrl_if.py18
1 files changed, 10 insertions, 8 deletions
diff --git a/src/target/fake_trx/ctrl_if.py b/src/target/fake_trx/ctrl_if.py
index 64f08bfd..d4840cde 100644
--- a/src/target/fake_trx/ctrl_if.py
+++ b/src/target/fake_trx/ctrl_if.py
@@ -26,16 +26,18 @@ from udp_link import UDPLink
class CTRLInterface(UDPLink):
def handle_rx(self, data, remote):
- if self.verify_req(data):
- request = self.prepare_req(data)
- rc = self.parse_cmd(request)
+ if not self.verify_req(data):
+ print("[!] Wrong data on CTRL interface")
+ return
+
+ # Attempt to parse a command
+ request = self.prepare_req(data)
+ rc = self.parse_cmd(request)
- if type(rc) is tuple:
- self.send_response(request, remote, rc[0], rc[1])
- else:
- self.send_response(request, remote, rc)
+ if type(rc) is tuple:
+ self.send_response(request, remote, rc[0], rc[1])
else:
- print("[!] Wrong data on CTRL interface")
+ self.send_response(request, remote, rc)
def verify_req(self, data):
# Verify command signature