diff options
| author | Oliver Smith <osmith@sysmocom.de> | 2019-11-28 13:40:37 +0100 |
|---|---|---|
| committer | Oliver Smith <osmith@sysmocom.de> | 2019-11-28 15:07:21 +0100 |
| commit | 81a2546fcb3c3daef05ae04742fd29141b287c85 (patch) | |
| tree | 1e038d908917b6a76f3396dd2e82a90a8981b8a2 /library | |
| parent | e25773980ba1bebd809bed41982e6f1da8aff1b9 (diff) | |
library/MNCC_Types: fix sdp in tr_MNCC_*
Make sure it is * everywhere, not "". Partially fix the SIP tests, where
tr_MNCC_RTP_CONNECT did not match anymore:
13:15:27.516387 5 SIP_Tests.ttcn:219 Message enqueued on MNCC from SIP_Test-MNCC(3) @MNCC_Types.MNCC_PDU : {
msg_type := MNCC_RTP_CONNECT (517),
u := {
rtp := {
callref := 5001,
ip := 0,
rtp_port := 0,
payload_type := 0,
payload_msg_type := 0,
sdp := "0"
}
}
} id 3
13:15:27.516604 5 SIP_Tests.ttcn:221 Matching on port MNCC .u.rtp.sdp := "0" with "" unmatched: First message in the queue does not match the template:
Together with I522ce7f206932a816a64f03d916799c3215bb8c7 in
osmo-sip-connector.git, this makes the testsuite work again for
osmo-sip-connector master.
In order to fix the TTCN-3 tests for the latest release, we would need
to add a second code path to the TTCN-3 code, that does not send the sdp
data based on a configuration option. Considering that I've spent quite
some time already to fix this up, it does not seem worth the effort.
Related: OS#4282
Fixes: 06b859ca314f53a902329ed95848dbafef1d4f87 ("msc: add sdp to MNCC")
Change-Id: Ic7a2df0b6faeaa88682880f816518618ced79a7e
Diffstat (limited to 'library')
| -rw-r--r-- | library/MNCC_Types.ttcn | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/library/MNCC_Types.ttcn b/library/MNCC_Types.ttcn index 52965791..0a8e7d9f 100644 --- a/library/MNCC_Types.ttcn +++ b/library/MNCC_Types.ttcn @@ -1478,7 +1478,7 @@ template MNCC_PDU tr_MNCC_REL_req(template uint32_t call_id, template MNCC_cause imsi := ?, lchan_type := 0, lchan_mode := 0, - sdp := "" + sdp := * } } } @@ -1856,7 +1856,7 @@ template MNCC_PDU tr_MNCC_USERINFO_ind(template uint32_t call_id := ?, template imsi := "", lchan_type := 0, lchan_mode := 0, - sdp := "" + sdp := * } } } @@ -1977,7 +1977,7 @@ template MNCC_PDU tr_MNCC_RTP_CONNECT(template uint32_t call_id, rtp_port := rtp_port, payload_type := pt, payload_msg_type := 0, - sdp := "" + sdp := * } } } |