aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2020-05-25 15:33:13 +0200
committerPhilipp Maier <pmaier@sysmocom.de>2020-06-02 14:13:57 +0200
commit882843dc0f6870711adfd86dec70799360fa05cf (patch)
tree65007701a9a2e7c37432d5353631eefc76dfedb2
parent28d18e1e3e1b8632e61c2fed779a0d2354becca5 (diff)
MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
The rtp payload test vector in TC_amr_oa_bwe_rtp_conversion is wrong, it lacks the last byte which should be 0x00. Also the testvector is not very well chossen since it after BWE conversion the actual payload does not shrink (even if it looks like if it would because of the 0x00 byte at the end). Lets pick a better payload from a real world trace that actually shrinks by one byte when it is converted to BWE and use that one. Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8
-rw-r--r--mgw/MGCP_Test.ttcn6
1 files changed, 5 insertions, 1 deletions
diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 0de53087..be4e6342 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2082,8 +2082,12 @@ module MGCP_Test {
setverdict(pass);
}
+ /* Note: The hexstrings used with the f_TC_amr_x_x_rtp_conversion test
+ * functions are real world AMR RTP payloads including AMR header. The
+ * payloads were extracted from a trace with known good payloads. */
+
testcase TC_amr_oa_bwe_rtp_conversion() runs on dummy_CT {
- f_TC_amr_x_x_rtp_conversion('100c4e9ba850e30d5d53d04de41e7c'O, '10d3a6ea1438c35754f41379079f'O, "octet-align=1", "octet-align=0");
+ f_TC_amr_x_x_rtp_conversion('2014e959f35fdfe5e9667ffbc088818088'O, '217a567cd7f7f97a599ffef022206022'O, "octet-align=1", "octet-align=0");
}
testcase TC_amr_oa_oa_rtp_conversion() runs on dummy_CT {