diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2020-05-29 15:25:59 +0700 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2020-05-29 20:02:49 +0000 |
| commit | 28d18e1e3e1b8632e61c2fed779a0d2354becca5 (patch) | |
| tree | 4f5613bdd947126274b273f8b5bd3bb6588f080d | |
| parent | 438939029d1249d7b8845f665b7d6d456c6d49e9 (diff) | |
PCU: s/f_establish_tbf/f_pcuif_tx_rach_rx_imm_ass/g
Fix confusion: f_ms_establish_ul_tbf() vs f_establish_tbf(). The
new name precisely describes what the function does. Sending a
RACH.ind and receiving a DATA.req with RR Immediate Assignment
is just a part of the TBF establishment process.
Change-Id: I1e22b9936bf68ebcaf70cefbc57345995ebbbaed
| -rw-r--r-- | pcu/GPRS_Components.ttcn | 10 | ||||
| -rw-r--r-- | pcu/PCU_Tests.ttcn | 2 |
2 files changed, 6 insertions, 6 deletions
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 26289387..392440c9 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -308,7 +308,7 @@ function f_ms_establish_ul_tbf(inout GprsMS ms) runs on MS_BTS_IFACE_CT { var GsmRrMessage rr_imm_ass; - rr_imm_ass := f_establish_tbf(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta); + rr_imm_ass := f_pcuif_tx_rach_rx_imm_ass(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta); ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass); } @@ -523,10 +523,10 @@ runs on MS_BTS_IFACE_CT return GsmRrMessage { const BIT8 chan_req_def := '01111000'B; /* Establish an Uplink TBF by sending RACH.ind towards the PCU */ -function f_establish_tbf(uint16_t ra := bit2int(chan_req_def), - uint8_t is_11bit := 0, - PCUIF_BurstType burst_type := BURST_TYPE_0, - TimingAdvance ta := 0) +function f_pcuif_tx_rach_rx_imm_ass(uint16_t ra := bit2int(chan_req_def), + uint8_t is_11bit := 0, + PCUIF_BurstType burst_type := BURST_TYPE_0, + TimingAdvance ta := 0) runs on MS_BTS_IFACE_CT return GsmRrMessage { var uint32_t fn; diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5fb4b2bf..bdcf7c1f 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1518,7 +1518,7 @@ runs on RAW_PCU_Test_CT { ra11 := enc_EGPRSPktChRequest2uint(req); log("Sending EGPRS Packet Channel Request (", ra11, "): ", req); - rr_msg := f_establish_tbf(ra := ra11, is_11bit := 1, burst_type := bt); + rr_msg := f_pcuif_tx_rach_rx_imm_ass(ra := ra11, is_11bit := 1, burst_type := bt); if (not match(rr_msg, t_imm_ass)) { setverdict(fail, "Immediate Assignment does not match"); f_shutdown(__BFILE__, __LINE__); |