AgeCommit message (Collapse)AuthorFilesLines
2018-06-13lms: Fix coding stylelaforge/limeHarald Welte3-12/+10
In Change-Id Ib2fca81b76d027b08e2891056fa076d071597783 we introduced some coding style violations. Let's make newly-added code follows standard Osmocom coding style. Change-Id: Ib7ddd275014f03a2eed3cddc02b1356e2b00c0bc
2018-06-13radioDevice: better encapsulation in base classHarald Welte6-32/+37
It's not good style to have the derived classes initialize members inherited from the base class using "this->foo = bar". Rather, let's make the base class have a constructor, and call that constructor to initialize the members of the base class. While doing this * rename 'offset' to 'lo_offset' to avoid confusion with timestamp offset * move 'InterfaceType' into the base class * move 'chans' into the base class * move 'rx_sps' into the base class * mark base class members as 'protected' Change-Id: Ib885675a7612a392aa7f75fca81269ddcff2f6ab
2018-06-13radioDevice: Move tx_sps from derived into base classHarald Welte6-17/+18
All three derived classes use a tx_sps member, let's move this into the base class. Change-Id: I73b4aa2705c5049561e2d7b21301a0d2b3c96ced
2018-06-13lms: Call set_antennas() during open() methodHarald Welte1-0/+5
Without this call, the antenna/path configuration is not applied. Change-Id: I0bca58266b59f1315ec72b6407fe4f4495aff678
2018-06-13lms: Fix support for rx_paths / tx_pathsHarald Welte2-3/+10
Before this patch, any configuration in osmo-trx.cfg regarding the rx and tx "antenna" (path) would have been completely ignored, as the radioDevice::make() function would simply drop those arguments to the floor. Change-Id: Ie50f854abbc9dcf351cddc052d10206382e1d5d3
2018-06-13move set_antennas() from UHD to generic radioDevice base classHarald Welte4-33/+29
Change-Id: I806143e9db21f0be4dcc6a376b3a630be7aeb3ba
2018-06-12lms: Reduce Rx gain from 47 to 34 dBZydrunas Tamosevicius1-1/+1
Initially, Rx gain was hardcoded to be 47. This was too high for our setup and we were constantly getting "clipping detected" messages. Reducing Rx gain to 34 solved the issue. However, it looks like gains should be controlled through configuration files. Change-Id: I30580f18c4ad630c09f725b1d24c125fc3119809
2018-06-12lms: fix LMS_StartStream() handling for multiple channelsZydrunas Tamosevicius1-0/+5
LMS_StartStream() (in LMSDevice::start()) was moved to separate loop. It is because LMS_SetupStream() would fail for second channel if streaming has already been started (LMS_StartStream()) for single channel configuration. Change-Id: I6704bb92864aa81417507c4ae24a22f41dc529c1
2018-06-12lms: Reduce log level of "send buffer of len ..."Zydrunas Tamosevicius1-1/+1
Log level of "send buffer of len ..." messages was changed as it was causing problems on some machines. Change-Id: I605d50e81966c7bd169b27788d62af6fb54c84e1
2018-06-12lms: Use same timestamp offset like when using LimeSDR via UHDZydrunas Tamosevicius1-5/+2
The tx timestamp offset was not set. We set it to the same value as it was in UHD interface for LimeSDR Change-Id: I78bc40cd575097f71a5f82b63467fa81c3f8d837
2018-05-29lms: Check LPBFW to set is within supported rangePau Espin Pedrol1-6/+26
As of LimeSuite 618fbb9c3188b36d75ad5785a97b8887dcc468f6, it seems 5e6 is within the returned range, but LMS_SetLPFBW fails anyway. See for more information: https://github.com/myriadrf/LimeSuite/issues/184 Change-Id: I967e7da7c0e3e8138b76733ee4a0e6311d20b62e
2018-05-25lms: Makefile.am: Reorder params to fix link issuePau Espin Pedrol1-2/+2
It seems the order in which static code and -lfoo is passed to the linker matters. This commit is a lms specific follow-up of commit 2a8183bdf0dfd5c5a59c3933fb932e827ddf811c. Change-Id: I59c20d268ecac4c22689124165c47295bd9176d4
2018-05-25LMSDevice: Fix setup failure with LimeSuite > 18.04.1Pau Espin Pedrol1-1/+1
Fixes: https://github.com/myriadrf/LimeSuite/issues/184 Change-Id: Ia9f37995cd10d19d6820e3e12b8ee8f3efbff5d4
2018-05-25LMSDevice: Set correct values for Max{Tx,Rx}GainPau Espin Pedrol1-2/+2
Change-Id: I3b3a7080a69e15d8d6770186810d922227439099
2018-05-25LMSDevice: Reduce Rx logging verbosity: Only log unexpected timestampsHarald Welte1-1/+2
Change-Id: I06b35efb7368616b9f4d348da574cd524ffe3ea6
2018-05-25LMS_Device: Set ts_offset to 0.Harald Welte1-1/+2
I'm not quite sure what the ts_offset is for, but by using "0" we are now receiving exactly the timestamp that we're expecting: LMSDevice.cpp:486 [tid=140576250332928] chan 0 recv buffer of len 2500 expect 305ed0 got 305ed0 (305ed0) diff=0 Change-Id: I270c94945b1af9662cfc468cfda1ae3af3ac0a27
2018-05-25LMSDevice: Fix initial timestamp offset of 2500Harald Welte1-1/+1
ts_initial must not point to the timestamp of the first sample in the last "flush" sample buffer, but to the first timestamp we expect in the next buffer. Change-Id: I23af62870544d4c6cf5f6e2d6578936603bceb91
2018-05-25LMSDevice: Set low-pass filters to smallest possible optionHarald Welte1-0/+4
Rx 1.4 MHz, Tx 5MHz. Both massively too wide for GSM, but there's no smaller band-width available. Change-Id: I9723c9a2ea77f65bfa9d796d7c44adc2417e89cf
2018-05-25LMSDevice: Typo fix: s/Internal/ExternalHarald Welte1-1/+1
Change-Id: Icacfe6da90a89c7f00d62c580948fb913998eaa7
2018-05-25LMSDevice: Print sample rate range + actual sample rate after setting itHarald Welte1-0/+9
Change-Id: I19c1a5b2d2431b8d39e277244e313f6e559e4d25
2018-05-25LMSDevice: Call LMS_Init() before setting sample rateHarald Welte1-4/+6
LMS_Init() will override basically all device settings with their default value, including the sample rate. We hence have to make sure to call it before any other API function that changes the device config such as sample rate, frequency, filter bandwidth, ... Change-Id: I4cdbae8406b5e1e93da491e90f8bad41d4be748b
2018-05-25update .gitignore to include osmo-trx-lmsHarald Welte1-0/+1
Change-Id: I52efd2f71eb61baa80427ab9f7b518f17d514792
2018-05-25build: Add support for LimeSuite device backendPau Espin Pedrol4-0/+35
Change-Id: I239e1b37263a62b374d84974c9347e3654072e87
2018-05-25lms: Several improvements and compilation/runtime fixesPau Espin Pedrol6-124/+271
Continuation of initial work done on LimeSuite support from Harald. Change-Id: Ib2fca81b76d027b08e2891056fa076d071597783
2018-05-25Initial work towards direct LimeSuite support in OsmoTRXHarald Welte2-0/+648
This is work in progress towards a direct LimeSuite driver in OsmoTRX, bypassing the currently rather complex stack of wrappers by going through UHD, SoapyUHD, SoapySDR and LimeSuite. Change-Id: Iaef29c4c2585ef8c2f94866c9591919f538c1a2d
2018-05-09trx_vty.c: fix: use CONFIG_NODE as parent by defaultVadim Yanitskiy1-1/+3
There are some configuration nodes, which are handled by extenral libraries, such as libosmoctrl. So, when switching back to the parent node, this should be kept in mind. Instead of aborting, let's got to the CONFIG_NODE by default. Fixes: OS#3250 Change-Id: Ia0600a46d19825806e5aed9257b6c57c3907808b
2018-05-08UHDDevice: Fix setup failure with LimeSuite > 18.04.1Pau Espin Pedrol1-2/+2
Fixes: https://github.com/myriadrf/LimeSuite/issues/184 Change-Id: I48ead8b8996981263297b66c0c7d3d0972261316
2018-05-04doc: examples: Add umtrx sample configPau Espin Pedrol1-0/+22
Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
2018-05-03Bump version: 0.3.0-dirty → Espin Pedrol2-3/+125
Change-Id: Ifc469bce89d52012e1f876c847b4535360a602ad
2018-05-02git-version-gen: Take into account tags not in masterPau Espin Pedrol1-2/+1
Latest tag 0.3.0 was created in a release branch instead of master. As a result, git describe doesn't show them. Let's instead reuse git command used in osmo-ci to get latest tag from tag list when OBS latest repository is built. Change-Id: I3e461d4270b5e6d4c42126df4deef5651dca1e27
2018-05-02doc: add example config for usrp B200 seriesPhilipp Maier1-0/+20
Change-Id: I1a80ddd9ca9b143e9c89618616f30fe3f3547d7b
2018-04-28osmo-trx: s/GSM Core Address/GSM BTS Address/Harald Welte1-1/+1
The TRX connects to the BTS, not to the "Core". The Core network is miles away... Change-Id: I6de2f708fc7a7df7dea16314b7dfa4ab82f15b2c
2018-04-28update .gitignore for new executable namesHarald Welte1-1/+2
Change-Id: Id698024485176e5201ca92c72b1bd1d5914aff32
2018-04-28debian/control: Add build dependency to libusrp-devHarald Welte1-0/+1
Change-Id: I9593c9e45d304b7ffc94474e94450da418838513
2018-04-28debian: Ensure USRP1 firmware is part of osmo-trx-usrp1Harald Welte1-0/+2
The std_inband.rbf files are required to operate USRP1 with timestamps Change-Id: I9b3e937ea1941953dcdcaf57cfec9575cd5a8a9c
2018-04-28debian/rules: Make sure we always require libusrpHarald Welte1-0/+3
Change-Id: Id9c9188a24617f83efa0e1fcf54f9e0dd223e365
2018-04-28debian/control: Remove "Maintainer" from binary package sectionHarald Welte1-1/+0
This resolves the following warning: dpkg-source: warning: unknown information field 'Maintainer' in input data in package's section of control info file Change-Id: I7a8d8c54eabccc5cedf7ad0a2bccf91f32f1bfdf
2018-04-28Revert "debian: Remove osmo-trx-usrp1 until we can build libusrp1.deb"Harald Welte1-0/+1
This reverts commit 295b938d51889d6db39251130642d45262ca039a, as we now have libusrp built in OBS Change-Id: Ia1311f1e236e6aea4acc08d3f234d53e46789cf9
2018-04-28build: Fix OBS build for ARMPau Espin Pedrol1-2/+3
Change-Id: Ic6b408d684e2bb58af71ec04ced7e73e0d38ffcd
2018-04-28debian: Fix OBS buildPau Espin Pedrol1-17/+9
osmo-trx is a metapackage, no need for .install file. Debug files are always put into osmo-trx-dbg, no osmo-trx-*-dbg. Change-Id: I160dd83b265dcda52762a9f9c7eac9337928da35
2018-04-28debian: Remove osmo-trx-usrp1 until we can build libusrp1.debPau Espin Pedrol1-1/+0
Change-Id: I43163755a29014fe1f098e994f8df79d853c90f8
2018-04-28jenkins.sh: Enable build of osmo-trx-usrp1Pau Espin Pedrol1-1/+2
Change-Id: I44a978fdd7fac683520be3586d84783e5e13de5f
2018-04-28build: More OBS build failure fixesPau Espin Pedrol1-4/+4
It seems the order in which static code and -lfoo is passed to the linker matters. Change-Id: I3b25be0154053ae8eb5f0a24c39fb9a229130fcf
2018-04-27build: Fix make distcheckPau Espin Pedrol6-12/+9
Change-Id: I1fa5e34b44331cd56408ea7ad4483dcf6443b259
2018-04-25Transceiver: log timing info of stale burstsPau Espin Pedrol1-1/+2
Change-Id: I043fd8199253bdf3912c7aec2ccf98f8cbe54251
2018-04-25Logger: Print correct source file and line numberPau Espin Pedrol3-10/+13
Before this commit, always Logger.cpp:53 was being printed. Change-Id: Ie5c64b4961c7c41d23484784a93eda5e08331f08
2018-04-24Build one osmo-trx binary for each device support enabledPau Espin Pedrol7-18/+64
Same way as we do in osmo-bts. After this commit, osmo-trx no longer exists. Instead, osmo-trx-uhd and osmo-trx-usrp1 are generated based on configure flags enabled. A new flag --with(out)-uhd has been added to enable/disable build of osmo-trx with UHD backend. It is left enabled by default to keep compatibility with older build scripts. Binary with USRP1 backend must still be manually enabled with --with-usrp1 flag. Change-Id: Iea8c0d7434762713a53440d29bf3ebd84accb262
2018-04-24Transceiver: Move device specific code to radioDevice classPau Espin Pedrol6-7/+26
Change-Id: Ibcf258d8bf8595e286682e0bc59391b239ea7642
2018-04-24Move device specific code out of radioInterfacePau Espin Pedrol6-28/+36
This way code of radioInterface is independent of the device and doesn't need to be rebuild for each device. Change-Id: Id104e1edef02f863b6465ced5b4241050dc188f9
2018-04-24Change configure define USRP1 to DEVICE_USRP1Pau Espin Pedrol5-7/+7
Similar as we do for ARCH_*, it's easier to find those are related to device support features. Change-Id: Iba238bff689b8f944af76120402c0fa2e29a70de