diff options
| author | Tom Tsou <tom.tsou@ettus.com> | 2017-03-30 19:36:41 -0700 |
|---|---|---|
| committer | Tom Tsou <tom@tsou.cc> | 2017-04-03 18:06:48 +0000 |
| commit | 6031734f448c6308d67b1ee464a13d60b33cd843 (patch) | |
| tree | 300f6980e2670802970a1924972d4c8607799c6d | |
| parent | 5d2a36a1137ea725b679655aec703a9fb0b9c243 (diff) | |
Transceiver: Remove unsigned negative compares
Change-Id: I49f30699786c52736ef334dae61f7bbd65d878d5
Fixes: Coverity CID 149353, 149356
| -rw-r--r-- | Transceiver52M/Transceiver.cpp | 4 | ||||
| -rw-r--r-- | Transceiver52M/osmo-trx.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4616fea..66eff7f 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -788,9 +788,9 @@ void Transceiver::driveControl(size_t chan) // set TSC unsigned TSC; sscanf(buffer, "%3s %s %d", cmdcheck, command, &TSC); - if ((TSC < 0) || (TSC > 7)) + if (TSC > 7) { sprintf(response, "RSP SETTSC 1 %d", TSC); - else { + } else { LOG(NOTICE) << "Changing TSC from " << mTSC << " to " << TSC; mTSC = TSC; sprintf(response,"RSP SETTSC 0 %d", TSC); diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 5e81586..b36c081 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -168,7 +168,7 @@ bool trx_setup_config(struct trx_config *config) if (!config->chans) config->chans = DEFAULT_CHANS; - if (config->mcbts && ((config->chans < 0) || (config->chans > 5))) { + if (config->mcbts && config->chans > 5) { std::cout << "Unsupported number of channels" << std::endl; return false; } |