From 43b8f9f8a10c16ddbcd1caeae742aace0c5e4ee9 Mon Sep 17 00:00:00 2001 From: Jacob Erlbeck Date: Thu, 2 Oct 2014 14:56:44 +0200 Subject: gbproxy: Send STATUS(BVCI unknown) to BSS on unknown PTP BVCI Currently BSSGP PTP messages are silently dropped when the BVCI is not known and patching is enabled. The nanoBTS will not recognize this and continue to send messages on the BVCI. If it receives a STATUS(BVCI unknown) instead, it will start a BVC reset procedure instead. This patch modifies gbprox_rx_ptp_from_bss() to return a STATUS(BVCI unknown) to the BSS instead of dropping the message. Sponsored-by: On-Waves ehf --- openbsc/src/gprs/gb_proxy.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'openbsc/src/gprs/gb_proxy.c') diff --git a/openbsc/src/gprs/gb_proxy.c b/openbsc/src/gprs/gb_proxy.c index c23e718c6..1437646fa 100644 --- a/openbsc/src/gprs/gb_proxy.c +++ b/openbsc/src/gprs/gb_proxy.c @@ -791,12 +791,19 @@ static int gbprox_rx_ptp_from_bss(struct gbproxy_config *cfg, peer = gbproxy_peer_by_bvci(cfg, ns_bvci); - if (peer) - check_peer_nsei(peer, nsei); - + check_peer_nsei(peer, nsei); rc = gbprox_process_bssgp_ul(cfg, msg, peer); - if (!rc) + if (!rc) { + if (!peer) { + LOGP(DGPRS, LOGL_NOTICE, "Didn't find peer for " + "BVCI=%u for PTP message from NSVC=%u/NSEI=%u (BSS)\n", + ns_bvci, nsvci, nsei); + return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, + &ns_bvci, msg); + } + return 0; + } switch (pdu_type) { case BSSGP_PDUT_FLOW_CONTROL_BVC: -- cgit v1.2.3