From e456e32f1511357256337efea9aafe6999f4760b Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Mon, 5 Aug 2019 16:03:39 +0200 Subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. API osmo_stats_vty_add_cmds never had a param list but has seem problem (no "void"), so some users decided to pass a parameter to it. Change-Id: Ic4af704958819e6f65ac01be33ef5b3d69628ad0 Related: OS#4138 --- src/gprs/gb_proxy_main.c | 4 ++-- src/gprs/gtphub_main.c | 2 +- src/gprs/sgsn_main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gprs/gb_proxy_main.c b/src/gprs/gb_proxy_main.c index 1e1aeac25..4319fda63 100644 --- a/src/gprs/gb_proxy_main.c +++ b/src/gprs/gb_proxy_main.c @@ -284,9 +284,9 @@ int main(int argc, char **argv) vty_info.copyright = openbsc_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - osmo_stats_vty_add_cmds(&gprs_log_info); + osmo_stats_vty_add_cmds(); gbproxy_vty_init(); handle_options(argc, argv); diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 6d470bd4b..f693f0993 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -356,7 +356,7 @@ int main(int argc, char **argv) vty_info.copyright = gtphub_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); gtphub_vty_init(hub, cfg); diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c index 3543517c1..ecfb79b0c 100644 --- a/src/gprs/sgsn_main.c +++ b/src/gprs/sgsn_main.c @@ -384,9 +384,9 @@ int main(int argc, char **argv) vty_info.copyright = openbsc_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - osmo_stats_vty_add_cmds(&gprs_log_info); + osmo_stats_vty_add_cmds(); sgsn_vty_init(&sgsn->cfg); ctrl_vty_init(tall_sgsn_ctx); -- cgit v1.2.3