From 20795e3fda107f4b292497337fd1a35d74482342 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Tue, 28 May 2019 21:25:06 +0200 Subject: Document max retransmit times for T3395 Spec also states same value is used for T3390, which we don't yet implement. Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066 --- src/gprs/gprs_gmm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index a18a54e1b..e7f0bfebd 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -67,6 +67,9 @@ #define PTMSI_ALLOC +/* 3GPP TS 04.08 sec 6.1.3.4.3(.a) "Abnormal cases" */ +#define T339X_MAX_RETRANS 4 + extern struct sgsn_instance *sgsn; extern void *tall_sgsn_ctx; @@ -2797,8 +2800,8 @@ static void pdpctx_timer_cb(void *_pdp) switch (pdp->T) { case 3395: /* waiting for PDP CTX DEACT ACK */ - if (pdp->num_T_exp >= 5) { - LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired >= 5 times\n"); + if (pdp->num_T_exp > T339X_MAX_RETRANS) { + LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired > %d times\n", T339X_MAX_RETRANS); pdp->state = PDP_STATE_INACTIVE; if (pdp->ggsn) sgsn_delete_pdp_ctx(pdp); -- cgit v1.2.3