aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-01-05Move struct sgsn_subscriber_pdp_data to gprs_subscriber.hPau Espin Pedrol3-17/+16
The functions driving its lifcyecles are already in gprs_subscriber.c, and are used mainly by functions in the same file, hence move it to the related header to further shrink gprs_sgsn.h. Change-Id: Iff7be91af130a3317d57d3649c17e3d5d2540e7a
2023-01-05Move struct apn_ctx and APN related definitions to its own filePau Espin Pedrol8-113/+154
This allows further shrinking of gprs_sgsn.{c,h} and also being able to use GSM_APN_LENGTH on different headers easily (needed by follow-up patch). Change-Id: Id225ed8b84e1376f4a30f17dd4b153b6b1a6efa8
2023-01-05Move global ggsn_list into struct sgsn_instancePau Espin Pedrol5-6/+6
Change-Id: I9d4c74476b777a866af2796dd376ed50da7b5d01
2023-01-05Keep sgsn subsystems under struct sgsn_instance lifecyclePau Espin Pedrol8-63/+83
Rework initialization and destruction of several sgsn subsystems to be allocated & released together with the struct sgsn_instance. This makes it easier to destroy and recreate the entire context and allows us to start moving global variables scattered around to be under struct sgsn_instance. Change-Id: Idf60519b8e475b94d38bbb69e737132a5afaefab
2023-01-05Remove unneeded extern declaration from libosmocotrlPau Espin Pedrol1-2/+0
Change-Id: I464df2d03538c71f6666046c67170746690e723d
2023-01-05Move related structs to gprs_subscriber.hPau Espin Pedrol2-24/+26
This allows shrinking a bit more gprs_sgsn.h and and in turn have everything much more tidy. Change-Id: Ie39b48a0d612aa632327cc5a21c833b05f5bf297
2023-01-05Fix -Werror=old-style-definitionPau Espin Pedrol6-15/+16
Change-Id: I119d4ba58d9c68df12b433b0cee924468a1473d8
2023-01-05Introduce new header file sgsn/gtp.hPau Espin Pedrol4-3/+7
It will be used to store all stuff relatd to libgtp use and GTP protocol, similar to what we already do for other protocols. Change-Id: I4aae35cd0ea401856cd822cb507d668350d07a89
2023-01-05Move gprs_sndcp_vty_init() declaration to gprs_sndcp.hPau Espin Pedrol3-1/+3
Change-Id: Iea9692e7ef9bd017d89ef654d2f2ae5b30cc4550
2023-01-05gprs_subscriber: Move API declarations to correct headerPau Espin Pedrol3-30/+29
Change-Id: Iaa1032c38fa54ad57c472d9120cfbb34b2ae90e9
2023-01-05Move struct sgsn_ggsn_ctx to its own file gtp_ggsn.{c,h}Pau Espin Pedrol13-169/+229
Similar to what we already have for struct sgsn_mme_ctx in gtp_mme.{c,h}. This is just the nth step of properly splitting different protocol layers, data model, etc. Change-Id: Iad1895f09e43e299df7bb126bf52fdb98268392e
2023-01-04Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str()Pau Espin Pedrol3-53/+17
The exact same function exists in libosmocore with a different naming. Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d
2023-01-04Remove unused function gprs_parse_mi_tmsi()Pau Espin Pedrol2-14/+0
Change-Id: I6fb7688bf54c7ae3ca3e06bf3a1b729fa62d82f9
2023-01-04Standarize lle and llme state enum & value_stringPau Espin Pedrol3-12/+13
Change-Id: Iaf102ce5ca60854fe7eb1af17c73a80e7c76181b
2023-01-04vty: Fix wrong value_string used to print llme statePau Espin Pedrol1-1/+1
Change-Id: Id3eec91b47029964092087858e4ae3a824929ce3
2023-01-04cosmetic: gprs_llc_vty.c: Fix trailing whitespacePau Espin Pedrol1-1/+1
Change-Id: I543fd784f7e1a0f7c82bd7c79e073104becc88da
2023-01-02Move gprs_tmr_to_secs() to tests/gprs/gprs_test.cPau Espin Pedrol3-17/+16
That function is only used in the test. Let's hence move the function to the same test file in order to simplify osmo-sgsn code. Change-Id: I69d80810362d75eb93974af34f61639514f99f8a
2022-12-28Rename gprs_gb.[c,h] -> gprs_ns.[c,h]Pau Espin Pedrol9-7/+7
All remaining code in that file is NS protocol related, hence let's rename it so that we end up with one file per protocol in the Gb stack. Change-Id: I8312c8a70d60cab48764950c5b57ca02964e9db2
2022-12-28Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h]Pau Espin Pedrol5-55/+55
This leaves only NS protocol related code in gprs_gb.[c,h], which will be renamed to gprs_ns.[c,h] in a follow up patch. Change-Id: I3dcbe1d0f75cb91ec8b700e239e2ba16fff030a2
2022-12-28Create new specific file for BSSGP codePau Espin Pedrol10-69/+118
Right now there's no much code there since the related code is totally entangled with the LLC one. This will eventually change in the future when we switch to use libosmo-gprs. Hence, this commit is a preparation to have already some place to put new BSSGP specific code in the future. Change-Id: I816396ab5ccb86032bbc21b41a959934a7768780
2022-12-22Move gprs_gb_parse.[c,h] to tests/sgsn/Pau Espin Pedrol7-7/+10
That big file is really only used by tests/sgsn/sgsn_test nowadays, so let's keep it out of osmo-sgsn app code base. Change-Id: Ia5a639832f52b2f015a2800bd0d94a28d7bc689b
2022-12-17ctrl: take both address and port from vty configMax1-2/+1
Change-Id: Ie1330b152a2e5cdcdb80a1c958e7c1d784b78eab
2022-12-08osmo-gtphub.cfg: fix conflict with osmo-ggsn.cfgOliver Smith1-1/+1
Change bind-to-ggsns from 127.0.0.2 to 127.0.0.20, so osmo-gtphub's default config does not confligt with the osmo-ggsn default config. This change is for the effort of making the configs of all Osmocom programs not conflict with each other. A similar change was made in Id892e1f4ab2daabbe9824b819b5fed985373b97a with bind-to-sgsns. Related: OS#5817 Change-Id: I57ee457b62139d831707b6ebd6baaea8d33c2d9c
2022-12-06sndcp: Put decompress handling code into helper functionPau Espin Pedrol1-79/+64
This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649
2022-11-17sgsn_libgtp: cb_data_ind: remove mm_idle assertOliver Smith1-4/+13
Log an error message and drop the packet instead of asserting if mm state fsm is in ST_MM_IDLE while the gmm fsm is in ST_GMM_REGISTERED_NORMAL. Fixes: OS#5725 Change-Id: I9dab98917c622b36dae22399bb359d747a598208
2022-11-15contrib/jenkins.sh: use enable-werror with IU tooOliver Smith1-5/+2
Now that the warnings in osmo-iuh have been fixed, we should be able to build the IU version of OsmoSGSN with --enable-werror too. Related: OS#4462 Change-Id: I8cc4e209e21acfe513bef72927499f1ccdead783
2022-11-04vty: Make new libgtp tdefs configurable through VTYPau Espin Pedrol4-0/+29
Related: OS#5485 Depends: osmo-ggsn.git Change-Id I10bc8e2e197c0e8753b23b684b5ae41025672bf7 Change-Id: I46e9cd158a9f2f721c69f807beb7bb67a459f4a4
2022-10-14GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal stateMax1-0/+6
The FSM might be moved out of ST_GMM_COMMON_PROC_INIT state either by E_GMM_ATTACH_SUCCESS or by E_GMM_COMMON_PROC_SUCCESS events which are not mutually exclusive. Hence the later event will arrive when we're already in the ST_GMM_REGISTERED_NORMAL state. Let's have both events permitted to keep the logs clean from useless error. Related: OS#5349 Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5
2022-10-11Constify LLC/SNDCP parametersMax5-22/+23
That makes it easier to track side-effects while reading the code. Related: OS#5349 Change-Id: I903f8a747a8d3b7f734dac7b0c12373ecbb90b11
2022-10-11GTP: migrate from deprecated functionMax1-2/+2
The gtp_set_cb_recovery3() is similar to gtp_set_cb_recovery2() with extra parameter representing GSN. Change-Id: I8b46cf8c52e36b0312eddf37f3e136662b95732e
2022-10-08SNDCP: log more details on failureMax1-2/+3
Related: OS#5349 Change-Id: Iad3ebbc28909a827db7b3a0ae2d3e1de7991210f
2022-09-08llc: gprs_llc_fcs(): make the input data pointer constVadim Yanitskiy4-4/+4
Change-Id: If95210fe69f915ab1010fe5916cb6bee3faeb7b9
2022-09-08gprs_llc.h: use '#pragma once'Vadim Yanitskiy1-5/+1
Change-Id: Iff748fe68dbef83589bfb5e3bea5183deb365fa6
2022-08-30Set working directory in systemd service fileMax2-0/+4
By default systemd will execute service with root directory (or home directory for user instance) which might result in attempts to create files in unexpected place. Let's set it to 'osmocom' subdir of state directory (/var/lib for system instance) instead. Related: OS#4821 Change-Id: I950d84853c6737276d02b3275127b499ae567c38
2022-08-26gprs_llc: fix misleading spacing in gprs_llc_rcvmsg()Vadim Yanitskiy1-3/+3
Change-Id: I7ec97a7d9b37f0541887bc13e31f547613f8945e
2022-08-16configure.ac: do not require unused dlsym/dlopenVadim Yanitskiy1-7/+0
Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d
2022-06-29Bump version: 1.8.0.9-c230-dirty → 1.9.01.9.0Pau Espin Pedrol4-31/+54
Change-Id: If8d3bad88dbd57b620e3aca61d99073e178c2fb6
2022-06-20README: Major updateHarald Welte3-18/+82
* convert to markdown syntax * bring in-line with other osmo-* README.md files, in terms of links to git, mailing list, manuals, etc. Change-Id: Ia4a4329c6ef6b8c833aa26832776dad662cdc7e9
2022-06-20update git URLs (git -> https; gitea)Harald Welte4-5/+5
Change-Id: Ib8d2953a6c3f1e65b7c638feea4d8a97ee02e443
2022-04-13tests: use 'check_PROGRAMS' instead of 'noinst_PROGRAMS'Vadim Yanitskiy7-7/+7
When using 'check_PROGRAMS', autoconf/automake generates smarter Makefiles, so that the test programs are not being compiled during the normal 'make all', but only during 'make check'. Change-Id: I8118ee3d3da9bdcd0c691471ef91b95dba21004a
2022-03-10Iu: add UEA encryptionNeels Hofmeyr6-3/+48
Add vty 'encryption uea 0 1 2', defaults to 'encryption uea 0' to yield previous behavior. If any UEA above 0 is enabled, include the UEA key in the Iu Security Mode Command. I noticed that only the code bit in st_iu_security_cmd_on_enter() affects the test. The same code in gsm48_gmm_authorize() seems to be dead code? But applying the patch there as well just to be safe. We cannot yet verify the chosen UEA to match a configured UEA level, because the iu_client.c does not send us message details with the RANAP_IU_EVENT_SECURITY_MODE_COMPLETE. Also we cannot yet send the set of configured UEA to the hNodeB, since, again, iu_client.c does not provide the proper API for it. The proper solution here is to completely dissolve iu_client.c and do all Iu handling in osmo-sgsn itself -- see OS#5487. Related: SYS#5516 Related: I1a7c3b156830058c43f15f55883ea301d2d01d5f (osmo-ttcn3-hacks) Change-Id: I27e8e0078c45426bf227bb44aac82a4875d18d0f
2022-03-07s/cipher_support_mask/gea_encryption_maskNeels Hofmeyr4-12/+12
will add uea_encryption_mask, and find that the name 'cipher_support_mask' is not concise enough. Related: SYS#5516 Change-Id: Ie8d4a0534c5b751f698bce425427bb1d28ddea31
2022-02-18Revert "sgsn: Handle different levels of QoS"Pau Espin Pedrol1-12/+5
This reverts commit 4bd931f96d75d3e71b73a06e67f84ffdcab9caf6. The commit was wrong, and previous code is correct. Relevant specs: * TS 29.060 7.7.34 Quality of Service (QoS) Profile * TS 24.008 10.5.6.5 Quality of service As can be seen in TS 24.008 10.5.6.5, OSMO_IE_GSM_REQ_QOS never comes with the the ARP byte prepended. This is actually always prepended when sending the GTP message, as explained in TS 29.060 7.7.34. As a result, the Qos Service sent in Create PDP Context Request sent to the GGSN contained wrongly formatted Qos Profile IE, which was observed checking wireshark with a real phone. This was found due to open5gs-smfd being more strict about the possible lengths of the IE, since the wrongly formatted IE send in GTP had length=14, which is incorrect due to folllowing TS 24.008 10.5.6.5 wording: "Octets 15-22 are optional. If octet 15 is included, then octet 16 shall also be included, and octets 17-22may be included." In this case, due to the wrong format it was seen as including octet 15 but not 16. Change-Id: I4fc5ab823a27d27482858a7459337a2f8ae593c3 Related: SYS#5793
2022-01-11Drop unneeded ax_check_compile_flag.m4Pau Espin Pedrol1-74/+0
The macro is no longer used since 2d0e22960cc8f9c6f97159589df25395cc491e85. Change-Id: I230005acc27e29c679a4ddbb2b316a3aae70874e
2021-12-14treewide: remove FSF addressOliver Smith3-12/+0
Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b
2021-12-07llme_free: clean up related sndcpOliver Smith3-0/+18
Fix crash in vty_dump_sne when sndcp->lle has already been deallocated. Context: * sndcp->lle is set only once in gprs_sndcp_entity_alloc() * sndcp->lle is a struct gprs_llc_lle, which gets allocated and deallocated together with struct gprs_llc_llme. From gprs_llc.h: struct gprs_llc_llme { ... struct gprs_llc_lle lle[NUM_SAPIS]; Fixes: OS#4824 Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3
2021-11-16Bump version: 1.7.0.28-245ac-dirty → 1.8.01.8.0Pau Espin Pedrol5-31/+74
Change-Id: I62daba59b9dd1a0cade5292c8705ee5ec5b103c2
2021-11-15tests/Makefile.am: do not try removing non-existing filesVadim Yanitskiy1-3/+3
Change-Id: Ie9f4a9aa4061e4e4c659b1ad71596846ce75df7b
2021-11-04Revert "Turn some compiler warnings into errors"Oliver Smith1-12/+0
Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4
2021-09-30VTY: Don't display 'PDP Address: invalid' for IPv4v6Keith3-6/+24
We were not handling the case of PDP_TYPE_N_IETF_IPv4v6 in gprs_pdpaddr2str() and showed "invalid" for these addresses. Depends: libosmocore Change-Id: I1f82f9d8fc13dcc4474760329bd74ae9685b9031 Change-Id: Id36b7520677e4a0af40d05dc503b26d1b0b74a26
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-24 09:12:59 +0000