AgeCommit message (Collapse)AuthorFilesLines
2020-06-26sgsn_libgtp: Avoid ps-paging MS on GMM Suspended statepespin/pspagingPau Espin Pedrol1-4/+3
The MS notifies movement to GMM SUSPEND state because it is for instance handling a call and cannot use PDCH anymore. Once it releases the TCH it will ASAP move to either dedicated mode or trigger RAU, which means it will get out of SUSPEND state. So it doesn't make sense to try paging the MS when in that state. Related: OS#4616 Change-Id: Ia245899eb9f16c7f839785def4ceb721a1c3a11b
2020-06-26gprs_gmm_fsm.c: Add missing license headerPau Espin Pedrol1-0/+22
The file was created by myself on September 2019, 31c4657c971e40407163034526aafeb9b5a83460. Change-Id: I94299b9ccf760ad13429e149067f06ed60d37de3
2020-06-22*.spec.in: Use %config(noreplace) to retain current config fileHarald Welte1-3/+3
Change-Id: I4e7f0a44d5e2d132b24ca0f38dc6f520b59112da
2020-06-18sgsn_libgtp: Improve ps-paging loggingPau Espin Pedrol1-1/+7
Change-Id: I0c3d48d54295824c3ba5b0fa9e3c035983556326
2020-06-18use new osmo_mobile_identity API everywhereNeels Hofmeyr7-120/+137
Depends: If4f7be606e54cfa1c59084cf169785b1cbda5cf5 (libosmocore) Change-Id: I4cacb10bac419633ca0c14f244f9903f7f517b49
2020-06-18gbproxy_test.c: fix mobile identity test dataNeels Hofmeyr2-271/+271
Fix the final nibble of all IMSI BCD digits to 0xf, since it is a filler digit. The encoded IMSI has an even amount of digits (14) and must contain a 0xf filler nibble at the end. The test data looked correct due to repeated '1' digits. wrong hex: 11 12 13 14 15 16 17 18 correct: 11 12 13 14 15 16 17 f8 order: 1T 32 54 76 98 ba dc Xe T = type, X = filler, 1..e = 14 digits This error was found when applying the new osmo_mobile_identity API. Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9
2020-06-17Treat RAU as implicit RESUME if GMM is suspendedHarald Welte1-3/+8
We so far only resumed from suspend upon receiving an explicit BSSGP RESUME message from the BSS. The latter is only possible in BSC-colocated PCU, where the BSC can trigger the message when releasing the dedicated channel. In BTS-colocated PCUs, this is not possible, and we have to rely on the MS resuming by RAU. See 3GPP TS 23.060 section clause 6: The MS shall resume GPRS services by sending a Routeing Area Update Request message to the SGSN: * if the BSS did not successfully request the SGSN to resume GPRS services, * if the RR Channel Release message was not received before the MS left dedicated mode, * if the MS locally determines that the conditions for the GPRS suspension have disappeared Without this patch, the GMM state would forever be stuck in SUSPEND, which in turn causes the SGSN to page the MS all the time. Change-Id: I3c09187a27483d95fa0070bbb467f94a2ea3978f Related: OS4616
2020-06-08Fix memory leak when SNDCP de-fragmentation is usedHarald Welte1-0/+4
As msgb ownership is not passed along, we need to free the message buffer memory we allocate in defrag_segments() after calling sgsn_rx_sndcp_ud_ind(). Change-Id: I1185b1aa99bb167d616eb469e5445e4ed5ad949d Closes: OS#4603
2020-05-22Makefile.am: EXTRA_DIST: debian, contrib/*.spec.inOliver Smith1-1/+7
Change-Id: I15d4c9ca2c7ed0467b44f57bbaa1a2177feff154
2020-05-19contrib: integrate RPM specOliver Smith3-6/+9
Remove OpenSUSE bug report link, set version to @VERSION@, make it build with CentOS 8 etc. Related: OS#4550 Change-Id: I824b67f2d590ac2aa9f2e4fa4387a5283cf22521
2020-05-14contrib: import RPM specOliver Smith1-0/+141
Copy the RPM spec file from: https://build.opensuse.org/project/show/home:mnhauke:osmocom:nightly Related: OS#4550 Change-Id: Ia18f44f1b6dc259c3d0474b88b33f4657d96fd7a
2020-05-12gsup: send RAT type on LUNeels Hofmeyr1-2/+14
At 36c3, osmo-hlr was run with a patch that records the RAN type of attached subscribers. Even though this is not in osmo-hlr master, it is nice information to send along. Change-Id: I5dbe610738aed7ea1edf6b33543b1c03818cc274
2020-05-10fix nullpointer: in gsm48_rx_gmm_ra_upd_req()Neels Hofmeyr1-1/+1
This caused frequent crashes at 36c3. The "proper" fix is probably elsewhere (lynxis mentions an unfinished patch), but at least this prevented some crashes during active operation. Once this is merged, we can (re)enable SGSN_Tests_Iu.TC_geran_attach_iu_rau, which tests exactly for this scenario: A Subscriber / MM context that is so far attached via GERAN, but now receives a RAU via UTRAN/Iu. Closes: OS#4339 Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc
2020-05-09Use OSMO_FD_* instead of deprecated BSC_FD_*Pau Espin Pedrol3-13/+13
New define is available since libosmocore 1.1.0, and we already require 1.2.0, so no need to update dependenices. Let's change it to avoid people re-using old BSC_FD_* symbols when copy-pasting somewhere else. Change-Id: Iaebd049e383b02204a12f39cc6c932a53d25fd72
2020-04-20gtphub_test: Fix compilation with gcc-10Harald Welte1-1/+1
/usr/bin/ld: ../../src/gtphub/gtphub.o:/home/laforge/projects/git/osmo-sgsn/src/gtphub/gtphub.c:50: multiple definition of `osmo_gtphub_ctx'; gtphub_test.o:/home/laforge/projects/git/osmo-sgsn/tests/gtphub/gtphub_test.c:57: first defined here collect2: error: ld returned 1 exit status See also https://alioth-lists.debian.net/pipermail/debian-mobcom-maintainers/Week-of-Mon-20200413/000653.html Change-Id: I19c1eef6649d2747f0b624f5292d7ae47c4ca839
2020-04-11configure.ac: fix libtool issue with clang and sanitizerEric1-0/+5
As pointed out at https://github.com/libexpat/libexpat/issues/312 libtool does not play nice with clang sanitizer builds at all. For those builds LD shoud be set to clang too (and LDFLAGS needs the sanitizer flags as well), because the clang compiler driver knows how linking to the sanitizer libs works, but then at a later stage libtool fails to actually produce the shared libraries and the build fails. This is fixed by this patch. Addtionally LD_LIBRARY_PATH has no effect on conftest runs during configure time, so the rpath needs to be set to the asan library path to ensure the configure run does not fail due to a missing asan library, i.e.: SANS='-fsanitize=memory -fsanitize-recover=all -shared-libsan' export CC=clang-10 ASANPATH=$(dirname `$CC -print-file-name=libclang_rt.asan-x86_64.so`) export LDFLAGS="-Wl,-rpath,$ASANPATH $SANS $LDFLAGS" Change-Id: I7402b019c191304f639806a3c29e6bb698b398ed
2020-04-11tests: dlopen does not imply availability of dlsym..Eric2-0/+4
Check for both. Change-Id: If41a20bf499f791432f5f207e40688e97fb6e9f7
2020-03-23manual: explain IuPS, add SCCP/M3UA section from common chaptersNeels Hofmeyr3-0/+23
Add 'cs7' default configuration, link to the osmo-gsm-manuals/common/cs7-config.adoc chapter to fully explain the 'cs7' client configuration. Related: OS#2767 Depends: Ia2508d4c7b0fef9cdc57e7e122799a480e340bf7 (osmo-gsm-manuals) Change-Id: If0f7c8fc4b94eb40b62570cf90999d5074dc00ee
2020-02-04gprs_gmm_fsm.c: Implement RAT change between 2g and 3gAlexander Couzens3-2/+63
Related: OS#2737 Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2
2020-02-04gprs_gmm: Check for RAT change and ensure this only happens for RAU/ATTDaniel Willmann1-0/+27
Change-Id: I38cb31907eddeade5350cdb648df179408d908d2 Related: OS#3727
2020-01-03Bump version: → Espin Pedrol4-7/+111
Change-Id: I99e6950db3f54c6291dd259bed9b5c46cc26c465
2019-12-11osmoappdesc.py, tests: switch to python 3osmith/fix-python3Oliver Smith3-82/+82
Make build and external tests work with python3, so we can drop the python2 dependency. This should be merged shortly after osmo-python-tests was migrated to python3, and the jenkins build slaves were (automatically) updated to have the new osmo-python-tests installed. Related: OS#2819 Depends: osmo-python-tests I3ffc3519bf6c22536a49dad7a966188ddad351a7 Change-Id: I8c07d99c1bc9f0383e4bce17544e0998998cc54d
2019-12-03exit(2) on unsupported positional arguments on command lineHarald Welte3-0/+15
Change-Id: I4f2d70d0b0f1b7bdb8604c930aba8fbb53d8bd54
2019-12-03regen_doc.sh: support gbproxy, run without dockerOliver Smith1-11/+71
Do not only update the VTY reference and counters of osmo-sgsn, but also the VTY reference of gbproxy. This was not possible with the old code path of calling "regen_doc.sh" inside docker-playground.git, as it expects the program to be updated to have the same name as the docker image. Using the docker-playground script also has the disadvantage, that one must push the development branch to git.osmocom.org before updating the VTY reference/counters, because that script would build a new docker container with a freshly cloned repository, check out the same commit that we have already locally, build that and then finally regenerate the docs. So instead of adding another parameter for the docker image to the script in docker-playground.git and calling it twice, simplify the process by rewriting the regen_doc.sh script in osmo-sgsn.git. Make it start the locally installed osmo-sgsn and osmo-gbproxy binaries and call osmo_interact_vty.py on them. Related: OS#4292 Change-Id: I8b5bd5347ea34266ad650383372630f2a84d5cce
2019-12-03doc: add OsmoGbProxy VTY referenceOliver Smith4-2/+1675
Depends: (osmo-gsm-manuals) I4dea3e07b88175b2a88e577129360af7ec5f87e1 Related: OS#4292 Change-Id: I24c3ca2fc2446673edceefb797c7d800c3a1a5d2
2019-12-02gitignore: fix paths to binariesOliver Smith1-3/+3
Change-Id: Ia968bbc5de34e9068d4b414e5a701b958ae517e5
2019-12-01manual: Fix copy+paste errorHarald Welte1-1/+1
Change-Id: I5753ded676951998a1fd76e4d2c2bf3311213f53
2019-12-01check for osmo_ss7_init() error return valueHarald Welte1-1/+1
Change-Id: Ic228273aa6fb197b78c70c467a4a99af317e8098
2019-12-01check for osmo_fsm_register() error return valuesHarald Welte4-4/+4
Change-Id: I2028c82ac1b0421101c3f5d04fd999b65abdbf08
2019-12-01Initial OsmoGbPROXY user manualHarald Welte7-1/+284
This adds a very basic manual consisting of nothing more than the common chapters and a high-level description of what it is all about. Change-Id: I80d4ea016376c59995ccfcd8685c7c0e86745bd2
2019-11-30LLC: Don't use hard-coded N201-U / N201-I values in XIDHarald Welte1-2/+5
The N201 values are negotiated per SAPI, and there are default values per each SAPI. Let's use those rather than hard-coded values. Closes: OS#3954 Change-Id: I447a3c6dd85311772a6e219c62dc820d2726857f
2019-11-23Use libosmocore constant for IMSI length in ACL entryMax1-1/+1
Presumably the length is chosen to match that of imsi in osmo_gsup_message. Change-Id: I138aea409aab0c748c75546e628797fc7498bf40
2019-11-21gprs_gmm.c: Send XID reset with received TLLIPau Espin Pedrol1-1/+1
Otherwise lower layers will end up using a TLLI from PTMSI which was not yet announced to the MS if it is still not in GMM attached state, as showcased by SGSN_Tests.TC_attach_req_id_req_ra_update. Related: OS#3957, OS#4245 Change-Id: Ide51726abb82f5784eca4ab8d62b2ad8512be843
2019-11-21gprs_llc.c: Use enum instead of hardcoded valuePau Espin Pedrol1-1/+1
Change-Id: I89815f44f615a188f46a13f3785b3f7484f73bb3
2019-11-21Improve logging in gprs_llc.c codePau Espin Pedrol3-11/+26
Change-Id: Id89cc6760179fb9b1709a30b5d1af41d466b280b
2019-11-08gmm: Fix assertion hit during RA UPD REQ before completting gmm attachPau Espin Pedrol1-2/+2
Output: 20191107021548500 DMM <0002> gprs_gb.c:40 MM_STATE_Gb(2596296189)[0x6120000084a0]{Idle}: Received Event E_MM_PDU_RECEPTION 20191107021548500 DMM <0002> gprs_gmm.c:1531 MM(/d4b6d7af) -> GMM RA UPDATE REQUEST type="RA updating" 20191107021548501 DMM <0002> gprs_gmm.c:1615 MM(/d4b6d7af) The MM context cannot be used, RA: 901-70-2758-208 Assert failed mmctx->gb.llme == NULL gprs_gmm.c:1620 Scenario reproducing the crash can be triggered with TTCN3 SGSN_Tests.TC_attach_req_id_req_ra_update. Basically, SGSN first receives an ATTACH REQ with a given RA ID, then SGSN switches to state CommonProcedureInitiated and sends GMM ID REQ, and MS/PCU answers immediatelly with a RA Update instead with a new RA ID. Related: OS#3957, OS#4245 Change-Id: I64fa5cf1b427d3abb99e553e584897261a827ce6
2019-10-21sgsn_libgtp.c: Drop use of deprecated libgtp APIs gtp_retrans*()Pau Espin Pedrol3-28/+3
Since osmo-ggsn.git c94837c6a401bf0f80791b619a9b4cfbe9160afd, those APIs are a no-op since timers are tracked internally through osmocom APIs (and at the same time, new implementation fixes some timing related bugs). As a result, osmo-sgsn depends now on at least that libgtp commit. Since it's not yet avaiable on latest libgtp release, let's track it down in TODO-RELESE to not forget to update libgtp requirements during osmo-sgsn release. Related: OS#4178 Change-Id: Ia9a93d4a6ed63cd0c736f9a99d81d730b958d82e
2019-10-17sgsn: Gb: implementing PS Paging when MS is MM_STANDBYAlexander Couzens1-0/+6
When the MS is in MM_STANDBY, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c
2019-10-17sgsn_libgtp: refactor ps paging into gprs_gbAlexander Couzens3-11/+28
Paging should be done in gprs_gb Change-Id: I3020020f52005aa460ca6b245ee2297aec9821b3
2019-10-09gprs_mm_state_iu_fsm.c: fix: assign timer_cb to mm_state_iu_fsmVadim Yanitskiy1-0/+1
GCC warns us that 'pmm_state_fsm_timer_cb' is defined but not used. This function was introduced in [1], but was not assigned to the FSM. [1] I66c2ac0350cb074aefd9a22c5121acf723f239d3 Change-Id: Ib040befc87b2676aad2b8fe3671404fb3f5b030b
2019-10-08sgsn_mm_ctx_alloc(): check for unallocated fsmsAlexander Couzens1-0/+25
Change-Id: I867612a60236eaf7009400c92f5d871006aaf008
2019-10-08gprs_gmm: release Iu connection on RAU failuresAlexander Couzens1-0/+6
When a RAU fails without an a GMM context, release the Iu connection after sending a response. Change-Id: I05a9200f55d608ccfb3f86184c324a2b428da76b
2019-10-08ranap: add non-spec X1001Alexander Couzens3-3/+12
When the SGSN releases a RANAP connection, it sends a Release Command and waits for a Release Complete. Use X1001 to release the Iu connection when the Release Complete is lost/never received. Change-Id: I39a0169c22a4ac430b3d6f3c281d1f381eaa4756
2019-10-08sgsn: MM Gb Fsm: fix event handling for implicit detachAlexander Couzens1-1/+3
Implicit detach means there won't be any Gb state afterwards. Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
2019-10-08gprs_sgsn: always allocate Gb/Iu mm fsmAlexander Couzens1-6/+6
When moving between RANs we need them at a later point. Allocate them always to not make the code (more) complex. Change-Id: I1724790335b0820f153a0cbdb5cfd1cfea36d1e9
2019-10-08gprs_ranap: add missing rc = 0Alexander Couzens1-0/+1
After processing the event, set the return code to success. Thanks to manatails (redmine). Change-Id: I73b3b3c3dd330bc953835737758854cf68539495 Fixes: #3969
2019-10-08gprs_mm_state_gb_fsm: ensure T3350 is not running when entering IDLEAlexander Couzens1-0/+4
In IDLE there is not further context with the MS. Prevents the Timer from sending packages to a MS which can not respond Change-Id: Ibdd913173af11d0e6d04aa392e047d5d9aee1243
2019-10-08gprs_ranap: on Iu release, stop the attach fsm if runningAlexander Couzens1-0/+3
A Iu release should stop any active procedure. Change-Id: I78c6c0c4024657212d6abef51e226ce233018fee
2019-10-08Iu: implement a user inactivity timerAlexander Couzens4-2/+29
The user inactivity timer is similiar to the Gb READY timer and reduces the resources taken by an idle UE. Change-Id: I66c2ac0350cb074aefd9a22c5121acf723f239d3
2019-10-03gprs_ranap: release Iu UE Context when exiting PMM ConnectedAlexander Couzens3-2/+52
PMM Connected defines a Iu signaling connection. The 2 other PMM states do not have an active Iu signaling connection. Change-Id: Ie05d2bdf8dfb593b4c7e837107a3a06f22e90119