diff options
| author | Harald Welte <laforge@gnumonks.org> | 2016-06-19 18:06:02 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-07-12 23:42:45 +0200 |
| commit | 80e6ece792802ea04664c1a415540fae518ea627 (patch) | |
| tree | 13976704a3b2e717b024151b170623f0fb900d40 /include/openbsc/silent_call.h | |
| parent | 7788cbf96c13c5ebb04894bd97a351bb25caf9bf (diff) | |
Use libvlr in libmsc (large refactoring)
Original libvlr code is by Harald Welte <laforge@gnumonks.org>,
polished and tweaked by Neels Hofmeyr <nhofmeyr@sysmocom.de>.
This is a long series of trial-and-error development collapsed in one patch.
This may be split in smaller commits if reviewers prefer that. If we can keep
it as one, we have saved ourselves the additional separation work.
SMS:
The SQL based lookup of SMS for attached subscribers no longer works since the
SQL database no longer has the subscriber data. Replace with a round-robin on
the SMS recipient MSISDNs paired with a VLR subscriber RAM lookup whether the
subscriber is currently attached.
If there are many SMS for not-attached subscribers in the SMS database, this
will become inefficient: a DB hit returns a pending SMS, the RAM lookup will
reveal that the subscriber is not attached, after which the DB is hit for the
next SMS. It would become more efficient e.g. by having an MSISDN based hash
list for the VLR subscribers and by marking non-attached SMS recipients in the
SMS database so that they can be excluded with the SQL query already.
There is a sanity limit to do at most 100 db hits per attempt to find a pending
SMS. So if there are more than 100 stored SMS waiting for their recipients to
actually attach to the MSC, it may take more than one SMS queue trigger to
deliver SMS for subscribers that are actually attached.
This is not very beautiful, but is merely intended to carry us over to a time
when we have a proper separate SMSC entity.
Introduce gsm_subscriber_connection ref-counting in libmsc.
Related: OS#1592
Change-Id: I639544a6cdda77a3aafc4e3446a55393f60e4050
Diffstat (limited to 'include/openbsc/silent_call.h')
| -rw-r--r-- | include/openbsc/silent_call.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/openbsc/silent_call.h b/include/openbsc/silent_call.h index 619a54327..5fec77b73 100644 --- a/include/openbsc/silent_call.h +++ b/include/openbsc/silent_call.h @@ -3,9 +3,9 @@ struct gsm_subscriber_connection; -extern int gsm_silent_call_start(struct gsm_subscriber *subscr, +extern int gsm_silent_call_start(struct vlr_subscr *vsub, void *data, int type); -extern int gsm_silent_call_stop(struct gsm_subscriber *subscr); +extern int gsm_silent_call_stop(struct vlr_subscr *vsub); #if 0 extern int silent_call_rx(struct gsm_subscriber_connection *conn, struct msgb *msg); |