diff options
| author | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-12-27 10:55:45 +0100 |
|---|---|---|
| committer | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-12-27 10:58:55 +0100 |
| commit | 8ce8d3a00d627b900f9343ffc3d07db0eeeee941 (patch) | |
| tree | d0bb36be1b46ac18a4ef6888d1df93db89ad9efe | |
| parent | cfcf7e84bd344f86f73b829996ba404a908d4133 (diff) | |
bsc: Avoid crashing when no lchan is present in the subscriber connection
If someone wants to send a message but we have no lchan anymore
we will now complain, delete the message and return.
| -rw-r--r-- | openbsc/src/bsc_api.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/openbsc/src/bsc_api.c b/openbsc/src/bsc_api.c index 267998fa6..35babc319 100644 --- a/openbsc/src/bsc_api.c +++ b/openbsc/src/bsc_api.c @@ -262,7 +262,17 @@ int bsc_api_init(struct gsm_network *network, struct bsc_api *api) int gsm0808_submit_dtap(struct gsm_subscriber_connection *conn, struct msgb *msg, int link_id, int allow_sach) { - uint8_t sapi = link_id & 0x7; + uint8_t sapi; + + + if (!conn->lchan) { + LOGP(DMSC, LOGL_ERROR, + "Called submit dtap without an lchan.\n"); + msgb_free(msg); + return -1; + } + + sapi = link_id & 0x7; msg->lchan = conn->lchan; msg->trx = msg->lchan->ts->trx; |