From 72ec18ce5a7f4e873b6137460706f5ecc598e4dd Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sun, 5 Apr 2020 03:19:43 +0700 Subject: sba: fix possible memleak in SBAController::alloc() Change-Id: I417eda155cd5b1e46dd0b05db3f507abd79121d1 --- src/sba.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sba.cpp b/src/sba.cpp index 567babe..32735e8 100644 --- a/src/sba.cpp +++ b/src/sba.cpp @@ -55,13 +55,13 @@ int SBAController::alloc( int8_t trx, ts; uint32_t fn; + if (!gsm48_ta_is_valid(ta)) + return -EINVAL; + sba = talloc_zero(tall_pcu_ctx, struct gprs_rlcmac_sba); if (!sba) return -ENOMEM; - if (!gsm48_ta_is_valid(ta)) - return -EINVAL; - for (trx = 0; trx < 8; trx++) { for (ts = 7; ts >= 0; ts--) { pdch = &m_bts.bts_data()->trx[trx].pdch[ts]; -- cgit v1.2.1