From 67204588f56aba6bf9b0a8bd7950b442d1cd0ac8 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 3 Mar 2018 15:48:40 +0100 Subject: UL TBF: Actually raise V(Q) in raise_v_q() method So far the method only printed that it was raising V(Q) but never actually did so. The increment statement was only in the log statement, its result never store to the actual m_v_q member variable. Change-Id: I699ebf6d1fceec655585e430711f59648b525728 --- src/rlc.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rlc.cpp b/src/rlc.cpp index ee88bd99..5c43304c 100644 --- a/src/rlc.cpp +++ b/src/rlc.cpp @@ -294,11 +294,13 @@ uint16_t gprs_rlc_ul_window::raise_v_q() uint16_t count = 0; while (v_q() != v_r()) { + uint16_t v_q_old; if (!m_v_n.is_received(v_q())) break; + v_q_old = v_q(); + set_v_q(mod_sns(v_q() + 1)); LOGP(DRLCMACUL, LOGL_DEBUG, "- Taking block %d out, raising " - "V(Q) to %d\n", v_q(), mod_sns(v_q() + 1)); - raise_v_q(1); + "V(Q) to %d\n", v_q_old, v_q()); count += 1; } -- cgit v1.2.3