AgeCommit message (Collapse)AuthorFilesLines
2019-01-28Added support for daemonize to osmo-pcu.rafael2k/daemonizeRafael Diniz1-1/+15
Change-Id: Ia889544e0a350b6bab55da4e4201a617e0241ea2
2019-01-21Bump version: → Welte1-0/+61
Change-Id: Ibd7ac106f1e08319a592cf3246fc9fb6e298d226
2018-12-06contrib: fix makedistcheck with disabled systemdOliver Smith1-1/+2
EXTRA_DIST files need to be distributed, no matter if the systemd option is configured or not. Change-Id: I356aa59ab152ace89b247823a2c0517814a69ecb
2018-12-05contrib/jenkins.sh: build and publish manualsOliver Smith1-0/+17
Add new environment variables WITH_MANUALS and PUBLISH to control if the manuals should be built and uploaded. Describe all environment vars on top of the file. When WITH_MANUALS is set, install osmo-gsm-manuals like any other dependency and add --enable-manuals to the configure flags (for "make" and "make distcheck"). Add the bin subdir of the installed files to PATH, so osmo-gsm-manuals-check-depends can be used by ./configure. Related: OS#3385 Change-Id: Ia5b112fc1663b78800d3c2c4ff2a0771cf5af11b
2018-12-04Fix DISTCHECK_CONFIGURE_FLAGS overrideOliver Smith2-2/+2
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the automake manual, as otherwise the flag can't be changed by the user anymore. Related: OS#3718 Change-Id: I10d1eef9838c0b843a3a4103b7b03e8e9457b69e
2018-11-27build manuals moved here from osmo-gsm-manuals.gitOliver Smith8-31/+97
Moved to doc/manuals/, with full commit history, in preceding merge commit. Now incorporate in the build system. Build with: $ autoreconf -fi $ ./configure --enable-manuals $ make Shared files from osmo-gsm-manuals.git are found automatically if - the repository is checked out in ../osmo-gsm-manuals; or - if it osmo-gsm-manuals was installed with "make install"; or - OSMO_GSM_MANUALS_DIR is set. Related: OS#3385 Change-Id: I7270652de393a98748c0cdc51e626c17ab8f44c2
2018-11-27Merge history from osmo-gsm-manuals.gitNeels Hofmeyr16-0/+2469
Change-Id: I33ce528bb58a8a730a15cc8a7a74852a14f42921
2018-11-27Change OpenBSC mentions to OsmoBSC where applicableDaniel Willmann1-1/+1
Change-Id: I4cc6874302b6089a54d44b09f08660a25e46d4dc
2018-11-27vty-ref: Update URI of docbook 5.0 schemaHarald Welte1-2/+2
... to match the /etc/xml/catalog file on debian (no "www" in hostname) Change-Id: Id9f3579c7f2bc3af13fe30b5268f249b6f59ed0d
2018-11-27OsmoPCU: add rate counter documentationAlexander Couzens3-0/+184
Change-Id: Ieb4e1dab415a70ded5c65c21752dca497856e96f
2018-11-27refactor Makefile build rules, don't use the FORCENeels Hofmeyr1-39/+5
The initial goal was to make sure we don't have overall FORCE rules causing unnecessary rebuilds -- annoying while writing documentation. As I looked through possible dependencies, I finally understood what's going on here. Remove code dup and nicely sort which belongs where in build/Makefile.*.inc. In each, describe in a top comment how to use it, and also unify how they are used: - Rename Makefile.inc to Makefile.docbook.inc and refactor - Add Makefile.vty-reference.inc - Add Makefile.common.inc Make sure that we accurately pick up all dependencies. Drop use of the macro called 'command', that silenced the actual command lines invoked and replaced them with short strings: it obscures what is actually going on and makes the Makefiles hard to read and understand. Each manual's makefile is greatly reduced to few definitions and a Makefile include, e.g. one for asciidoc, one for VTY reference. Move common/bsc_vty_additions.xml to OsmoBSC/vty/libbsc_vty_additions.xml, link from OsmoNITB. It applies only to OsmoBSC and OsmoNITB. Add a script that combines a VTY reference file with *all* additions files found in a manual's vty/ dir. Call this from Makefile.vty-reference.inc. Change-Id: I9758e04162a480e28c7dc83475b514cf7fd25ec0
2018-11-27Allow easily disabling GFDL referencesPau Espin Pedrol2-0/+4
All parts referencing GFDL can be easily disabled by removing the 'gfdl-enabled' attribute from the document. Change-Id: I2489726ad2e90301bceadfada926e31ae0f85986
2018-11-27configuration: fixing typosPhilipp1-2/+2
configuration.adoc has some minor typos in it, this commit fixes that. Change-Id: Id84238b89e5deeac99c043b79b26c7e7b8b8534b
2018-11-27fix 'make clean': shell glob, ignore failureNeels Hofmeyr1-3/+5
Unfortunately a glob like osmo-x__*.{svg,png} doesn't work, so have the suffixes in separate globs. Add dashes to indicate that failure should be ignored. Change-Id: I6bc4d9ea72b43a573acbc860c23397f748de2c7b
2018-11-27add 'make check' targetNeels Hofmeyr1-1/+1
Generate *.check files from asciidoc output and grep for WARNINGs. Add *.check files to gitignore and to 'make clean'. Change-Id: Ibccc83a3415930a528f2e8e4e4dda3b81c6d0b64
2018-11-27make clean: also remove generated image filesNeels Hofmeyr1-0/+1
Change-Id: I80798e79b4ccee64f26f58f9754de02b2958e33e
2018-11-27fix various typos across all manualsJonathan Brielmaier3-5/+5
2018-11-27gb/NS: Clarify the language regarding the UDP port numbers / socketHarald Welte2-5/+6
2018-11-27consistently use '3GPP TS' not sometimes 3GPP TS and sometimes TS.Harald Welte2-19/+19
2018-11-27gb: Some language improvements, formatting changesHarald Welte2-100/+199
2018-11-27Gb: Various spelling fixesHarald Welte3-5/+5
2018-11-27Gb message sequence chart: Add notion of PCU unix domain socketHarald Welte1-0/+3
2018-11-27Gb message sequence chart: flip sides (SGSN should be right)Harald Welte1-4/+4
... also, re-word some of th labels for more clarity
2018-11-27OsmoPCU: add MSC chartMax1-0/+24
2018-11-27OsmoPCU: expand BSSGP documentationMax1-3/+376
2018-11-27OsmoPCU: expand NS documentationMax2-18/+141
Add table with NS messages. Add corresponding sections. Clarify spec numbers.
2018-11-27OsmoPCU: fix Gb documentation front pageMax2-4/+6
Add date and commit refs. Add relevant standards. Fix email typo.
2018-11-27Initial place-holder for the new Gb/IP interface documentationHarald Welte6-1/+283
2018-11-27Add link to Asciidoc source code of manualHarald Welte1-0/+6
2018-11-27initial checkin of manuals to public repoHarald Welte9-0/+1399
The manuals existed in different form for several years in an internal sysmocom repository. However, since they had just recently been converted from docboox-xml to asciidoc and all files have been re-shuffled for enabling the public release, there's not much point in keeping the history with git-filter-branch.
2018-11-27Importing history from osmo-gsm-manuals.gitNeels Hofmeyr0-0/+0
Change-Id: I23320be18612dd1eb800d3b16594166f33b3d984
2018-11-07deb: add missing copyright fileMax1-0/+132
File is imported as-is from current .deb package Change-Id: Ib05480c0eea91bfb55bfc7ab446ea60932096d3d
2018-10-21gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tvHarald Welte1-0/+1
In Change-Id I7d22e7b5902c230efeae66eb20c17026a4037887 we introduced the use of timespecsub(). Unfortuantely, we also accidentially removed the call to osmo_clock_gettime() along with it, leaving now_tv completely uninitialized. Change-Id: Ieced0c62700b2fe4ab0208258183154cc701490b Related: OS#3225 Fixes: Coverity CID#188872
2018-09-20check for overlong unix socket pathsStefan Sperling1-2/+5
In pcu_l1if_open(), use osmo_strlcpy() instead of strncpy() and check for overflow. This catches overlong and non-NUL-terminated socket paths. Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839 Related: OS#2673
2018-09-13Install osmo-pcu.cfg to docdir/examplesPau Espin Pedrol2-2/+6
Change-Id: I42938d9abd17575c2e0ce69cc20d44a131f26b6a
2018-09-13Move examples/ to doc/examples/Pau Espin Pedrol6-4/+6
Change-Id: I1e163e10f8a2e22b9ebdcb2d0f13f6ad07c84efe
2018-09-10Install systemd services with autotoolsPau Espin Pedrol8-2/+32
Change-Id: Ie4c7e81495181059d1dff1c194d52d11fb72ed03
2018-09-10configure.ac: Set CXXFLAGS during --enable-sanitizePau Espin Pedrol1-1/+4
For some unknown reason ld was failing to find some asan symbols until I enabled asan too in CXXFLAGS. Change-Id: I695314b284277674dc336b40765313a37d238d6e
2018-09-06Cleanup of systemd service filesPau Espin Pedrol3-34/+2
Let's use a symlink in debian/ as we do in other projects, and merge the two service files since anyway they call the same binary. Change-Id: Ibd82ec12cbeb73a27ca5860266587efb58be14ab
2018-08-06debian/rules: Don't overwrite .tarball-versionHarald Welte1-4/+0
The .tarball-version file should contain the *source version* uniquely identifying the git commit, and not the Debian package name. With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct .tarball-version file in the .tar.xz of the nightly source packages. Change-Id: I093c9c1943e5f09d8f91f94af438f697a93e7127 Related: OS#3449
2018-07-27Bump version: → Espin Pedrol2-4/+25
Change-Id: I0c5a3f3cee8332d5088982117037d5a0b077061b
2018-07-11tbf: Replace '.' in counter names with ':'Pau Espin Pedrol1-32/+32
The '.' is illegal character in counter names, as they are exported via CTRL interface, where '.' has a special meaning that cannot be used by strings comprising the variable name. Change-Id: Ieb7496e1a30ab4f2bfe36c7b664dcdc034010a15
2018-07-11tbf: Use incrementing id for rate_ctr_group_allocPau Espin Pedrol1-8/+18
Wrap-around of var handling next id will luckly happen long after initially assigned TBFs are already released. Change-Id: I90ef64133986c556c1a529f5b966e847e6cabbad
2018-06-25check bssgp_tlv_parse() return code in gprs_bssgp_pcu_rcvmsg()Stefan Sperling1-0/+7
The return code from bssgp_tlv_parse() was not checked for a parsing error. In case of a parsing error the stored return code could have been overwritten later in this function. Explicitly check for a parsing error, log corresponding packets, and return an "invalid mandatory information" error status to the sender. To avoid loops, do not respond with an error status to STATUS PDUs. Change-Id: I56e10a97cda7fd2d40bc7b4b2e6202f97772e1b3 Related: OS#3178
2018-06-20jenkins.sh: use flag --enable-werror for sysmo and nonePau Espin Pedrol1-2/+2
The lc15 flavour still contains compilation warnings and thus the flag cannot be enabled while building it. Change-Id: I66a43822f8a40764d7d6e09503892cea6030e697
2018-06-05change log level of "DL packet loss" log messagesStefan Sperling2-2/+1
The TBF tests are failing on some machines due to unexpected log output: "DL packet loss of IMSI= / TLLI=0xffeeddcc: 0%" These messages are printed if >= 1 second has passed between loss reports. This timing is machine-dependent so the test is unstable as a result. Only print these messages at log level debug to (hopefully) make TBF tests pass consistently. Update expected test output accordingly. Change-Id: Ie43f0e3a8740f0fc132809a09a153886c51fadf9
2018-05-31fix time-delta calculations for measurement reportsStefan Sperling1-17/+14
The previous implementation unconditionally subtracted nanosecond values from different time measurements, causing overflow if the current measurement was taken in less of a fraction of a second than the past measurement. Use timespecsub() instead, which accounts for nanoseconds correctly. Also, fix calculations of KBit/s throughtput. It was not being calculated correctly, since it was actually accounting for one KB per 128th-part-of-a-second. Change-Id: I7d22e7b5902c230efeae66eb20c17026a4037887 Related: OS#3225
2018-05-25read monotonic clock with clock_gettime() instead of gettimeofday()Stefan Sperling3-21/+22
There have been test failures on the osmo-pcu Jenkins builders due to apparent clock drift. Switch relevant code from gettimeofday() to clock_gettime() with CLOCK_MONOTONIC to prevent time from going backwards and causing negative time deltas in calculations. Change-Id: I775d85d0d3ac740330879e588bdab6fce7f0b46c Related: OS#3225
2018-05-25fix a one-byte stack buffer overrun in osmo-pcuStefan Sperling1-1/+2
Address sanitizer uncovered a one-byte stack overrun due to an off-by-one in the size of the 'data' buffer in pcu_l1if_tx_pch(). Fix the problem and add an assertion which triggers before the overrun can occur. Change-Id: I08a879d72fcb916f78f175612fd90467d7bdd57c Related: OS#3289
2018-05-16rlc: Fix memset(0) on object with no trivial copy-assignmentPau Espin Pedrol1-3/+10
As warned by gcc 8.1.0, the cs field is a class (GprsCodingScheme) and should not be memset. Change-Id: Id742f82aa856e696b5fb414991dfd0883d0ac7fe