diff options
| author | Max <msuraev@sysmocom.de> | 2019-02-19 18:41:22 +0100 |
|---|---|---|
| committer | Max <msuraev@sysmocom.de> | 2019-03-27 12:32:04 +0000 |
| commit | 3eb47363ade9b4ce1de0f35c965e4a8dbb88b606 (patch) | |
| tree | 2927c05b9c13ed3e3eff91df4fbcd06001137a64 /tests/types/TypesTest.cpp | |
| parent | 0367ddd62b3c8a24358534bf8e500f7cac3300a6 (diff) | |
Rewrite Packet Uplink IA Rest Octets for SBA
Use bitvec_set_*() directly without external write pointer tracking to
simplify the code. This is part of IA Rest Octets (3GPP TS 44.018
§10.5.2.16) which is the last part of the message so it should not
interfere with the rest of encoding functions.
The difference in the expected test output is due to proper handling of
TAI which should not be transmitted for SBA according to the Note in
Table 10.5.2.16.1 in 3GPP TS 44.018.
The change was manually tested against real mobile phone using options
'gprs mode gprs' in osmo-bsc.cfg and 'two-phase-access' in osmo-pcu.cfg
to make sure appropriate code path is actually triggered.
That's partially based on reverted commit 93d947f5e8a30acc9250c124bf9d5bb6a8863526.
Change-Id: I97d53c27c1ca9e032d431b3aa7f915027d63ddc0
Related: OS#3014
Diffstat (limited to 'tests/types/TypesTest.cpp')
| -rw-r--r-- | tests/types/TypesTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp index 48794243..822bd514 100644 --- a/tests/types/TypesTest.cpp +++ b/tests/types/TypesTest.cpp @@ -514,7 +514,7 @@ void test_immediate_assign_ul0s() 0x23, /* TA */ 0x00, /* 0-length §10.5.2.21 Mobile Allocation */ /* ETSI TS 44.018 §10.5.2.16 IA Rest Octets */ - 0xc5, 0xd1, 0x08, 0x0b, 0x5b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, }; + 0xc5, 0xd0, 0x80, 0xb5, 0xab, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, }; check_imm_ass(NULL, false, GSM_L1_BURST_TYPE_ACCESS_0, res, sizeof(res), "ia_rest_uplink(SBA)"); } |