diff options
| author | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2015-05-04 08:21:17 +0200 |
|---|---|---|
| committer | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2015-05-04 10:01:25 +0200 |
| commit | 1f33294b1c1394c6ff0dd109ff10bb65886c1a44 (patch) | |
| tree | c54fb3f0f2973d55b538d5bc5b6dfdc68b05621f /tests/alloc | |
| parent | 2acfbebfd3b7fc24ccaf2115e7c8d55e94cd1450 (diff) | |
pcu: Fix non-critical warnings
These fixes do not affect the semantics of the code. They either help
gcc by providing default values that won't be used ("may be
uninitialised"), remove unused variables, or change signed to
unsigned variables to avoid comparison warnings.
Addresses:
bts.cpp:494:32: warning: 'tbf' may be used uninitialized in this
function
emu/test_replay_gprs_attach.cpp:81:27: warning: comparison between
signed and unsigned integer expressions
emu/test_pdp_activation.cpp:95:23: warning: unused variable ‘budh’
emu/test_pdp_activation.cpp:97:6: warning: variable ‘rc’ set but
not used
emu/pcu_emu.cpp:109:26: warning: unused variable ‘bts’
alloc/AllocTest.cpp:74:27: warning: unused variable ‘tbf’
osmocom/core/utils.h:13:50: warning: comparison between signed and
unsigned integer expressions
types/TypesTest.cpp:319:7: warning: unused variable ‘count’
types/TypesTest.cpp:320:11: warning: unused variable ‘rbb’
alloc/AllocTest.cpp:74:27: warning: unused variable ‘tbf’
alloc/AllocTest.cpp:132:11: warning: unused variable ‘ts_no’
Diffstat (limited to 'tests/alloc')
| -rw-r--r-- | tests/alloc/AllocTest.cpp | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index d711ad89..dcc33712 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -71,8 +71,6 @@ static void test_alloc_a(gprs_rlcmac_tbf_direction dir, const int count) * least this part is working okay. */ for (int i = 0; i < count; ++i) { - struct gprs_rlcmac_tbf *tbf; - tfi = the_bts.tfi_find_free(dir, &used_trx, 0); OSMO_ASSERT(tfi >= 0); tbfs[i] = tbf_alloc(bts, NULL, dir, tfi, used_trx, 0, 0); @@ -90,7 +88,7 @@ static void test_alloc_a(gprs_rlcmac_tbf_direction dir, const int count) } OSMO_ASSERT(!tbf_alloc(bts, NULL, dir, tfi, used_trx, 0, 0)); - for (int i = 0; i < ARRAY_SIZE(tbfs); ++i) + for (size_t i = 0; i < ARRAY_SIZE(tbfs); ++i) if (tbfs[i]) tbf_free(tbfs[i]); @@ -110,7 +108,7 @@ static void test_alloc_a() static void dump_assignment(struct gprs_rlcmac_tbf *tbf, const char *dir) { - for (int i = 0; i < ARRAY_SIZE(tbf->pdch); ++i) + for (size_t i = 0; i < ARRAY_SIZE(tbf->pdch); ++i) if (tbf->pdch[i]) printf("PDCH[%d] is used for %s\n", i, dir); printf("PDCH[%d] is control_ts for %s\n", tbf->control_ts, dir); @@ -131,7 +129,7 @@ static void test_alloc_b(int ms_class) struct gprs_rlcmac_bts *bts; struct gprs_rlcmac_trx *trx; int tfi; - uint8_t ts_no, trx_no; + uint8_t trx_no; gprs_rlcmac_tbf *ul_tbf, *dl_tbf; @@ -172,7 +170,7 @@ static void test_alloc_b(int ms_class) struct gprs_rlcmac_bts *bts; struct gprs_rlcmac_trx *trx; int tfi; - uint8_t ts_no, trx_no; + uint8_t trx_no; gprs_rlcmac_ul_tbf *ul_tbf; gprs_rlcmac_dl_tbf *dl_tbf; @@ -221,7 +219,7 @@ static void test_alloc_b(int ms_class) struct gprs_rlcmac_bts *bts; struct gprs_rlcmac_trx *trx; int tfi; - uint8_t ts_no, trx_no; + uint8_t trx_no; gprs_rlcmac_tbf *ul_tbf, *dl_tbf; @@ -282,7 +280,7 @@ static void test_alloc_b(bool ts0, bool ts1, bool ts2, bool ts3, bool ts4, bool struct gprs_rlcmac_bts *bts; struct gprs_rlcmac_trx *trx; int tfi; - uint8_t ts_no, trx_no; + uint8_t trx_no; gprs_rlcmac_tbf *ul_tbf, *dl_tbf; @@ -326,7 +324,7 @@ static void test_alloc_b(bool ts0, bool ts1, bool ts2, bool ts3, bool ts4, bool struct gprs_rlcmac_bts *bts; struct gprs_rlcmac_trx *trx; int tfi; - uint8_t ts_no, trx_no; + uint8_t trx_no; gprs_rlcmac_ul_tbf *ul_tbf; gprs_rlcmac_dl_tbf *dl_tbf; |