aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorDaniel Willmann <dwillmann@sysmocom.de>2014-01-15 12:45:56 +0100
committerDaniel Willmann <daniel@totalueberwachung.de>2014-01-15 15:23:35 +0100
commit3ce011f44ff5eaecb467e8633e1b134b04f21048 (patch)
treeb2dc22e639df507e85e7a1e9f59da3ebd51245cf /src
parentd54d9f5c75c4f020750af043de9ca43df52ade5d (diff)
rlc: Rename state() to show_state() to better reflect its function
show_state() is only used for debugging output to make the v(b) array human readable.
Diffstat (limited to 'src')
-rw-r--r--src/rlc.cpp4
-rw-r--r--src/rlc.h2
-rw-r--r--src/tbf.cpp2
3 files changed, 5 insertions, 3 deletions
diff --git a/src/rlc.cpp b/src/rlc.cpp
index 99516bb..36320dc 100644
--- a/src/rlc.cpp
+++ b/src/rlc.cpp
@@ -130,7 +130,7 @@ int gprs_rlc_dl_window::move_window()
return moved;
}
-void gprs_rlc_dl_window::state(char *show_v_b)
+void gprs_rlc_dl_window::show_state(char *show_v_b)
{
int i;
uint16_t bsn;
@@ -150,6 +150,8 @@ void gprs_rlc_dl_window::state(char *show_v_b)
case GPRS_RLC_DL_BSN_NACKED:
show_v_b[i] = 'N';
break;
+ default:
+ show_v_b[i] = '?';
}
}
show_v_b[i] = '\0';
diff --git a/src/rlc.h b/src/rlc.h
index 1834dba..17a1360 100644
--- a/src/rlc.h
+++ b/src/rlc.h
@@ -130,7 +130,7 @@ struct gprs_rlc_dl_window {
void update(BTS *bts, char *show_rbb, uint8_t ssn,
uint16_t *lost, uint16_t *received);
int move_window();
- void state(char *show_rbb);
+ void show_state(char *show_rbb);
int count_unacked();
uint16_t m_v_s; /* send state */
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 5969f0f..dfd1c67 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1374,7 +1374,7 @@ int gprs_rlcmac_tbf::update_window(const uint8_t ssn, const uint8_t *rbb)
dir.dl.window.raise(dir.dl.window.move_window());
/* show receive state array in debug (V(A)..V(S)-1) */
- dir.dl.window.state(show_v_b);
+ dir.dl.window.show_state(show_v_b);
LOGP(DRLCMACDL, LOGL_DEBUG, "- V(B): (V(A)=%d)\"%s\""
"(V(S)-1=%d) A=Acked N=Nacked U=Unacked "
"X=Resend-Unacked I=Invalid\n",