diff options
| author | Max <msuraev@sysmocom.de> | 2019-03-07 11:46:43 +0100 |
|---|---|---|
| committer | Max <msuraev@sysmocom.de> | 2019-03-07 17:05:19 +0000 |
| commit | fa3085b45e3615f0257133bd1e7953b60d69cded (patch) | |
| tree | b813ec61442e500448ac53d147dd4233c0b4b412 /src/gprs_ms.cpp | |
| parent | 86e35e488740889f8ad03d09a78918839b883240 (diff) | |
Log (M)CS UL update errors
Previously some of the errors in update_cs_ul() call were silently
ignored. Let's log all those as errors with appropriate message.
Note: test output needs updating because we do not (yet) set proper meas
struct in TBF tests. That's likely wrong but it's better to update tests
in a separate commit.
Change-Id: I4084fb281dd9dad04a2a3a68cac2a8f7b462548e
Diffstat (limited to 'src/gprs_ms.cpp')
| -rw-r--r-- | src/gprs_ms.cpp | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp index 87a35d18..88550539 100644 --- a/src/gprs_ms.cpp +++ b/src/gprs_ms.cpp @@ -633,11 +633,19 @@ void GprsMs::update_cs_ul(const pcu_l1_meas *meas) OSMO_ASSERT(current_cs_num > 0); - if (!m_current_cs_ul) + if (!m_current_cs_ul) { + LOGP(DRLCMACMEAS, LOGL_ERROR, + "Unable to update UL (M)CS because it's not set: %s\n", + m_current_cs_ul.name()); return; + } - if (!meas->have_link_qual) + if (!meas->have_link_qual) { + LOGP(DRLCMACMEAS, LOGL_ERROR, + "Unable to update UL (M)CS %s because we don't have link quality measurements.\n", + m_current_cs_ul.name()); return; + } old_link_qual = meas->link_qual; @@ -652,6 +660,9 @@ void GprsMs::update_cs_ul(const pcu_l1_meas *meas) low = bts_data->mcs_lqual_ranges[current_cs_num-1].low; high = bts_data->mcs_lqual_ranges[current_cs_num-1].high; } else { + LOGP(DRLCMACMEAS, LOGL_ERROR, + "Unable to update UL (M)CS because it's neither GPRS nor EDGE: %s\n", + m_current_cs_ul.name()); return; } |