aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Couzens <lynxis@fe80.eu>2016-05-30 17:30:10 +0200
committerHarald Welte <laforge@gnumonks.org>2016-05-31 11:51:59 +0000
commitb82bd92e57667f39eb88702bba9e5235b8a23b9f (patch)
tree6769cc7ab3b78d5b82da55c93d5692ea85d0ad56
parent2fcfc29020c81891d7888ddc7ddbcd866bcd406d (diff)
decoding: improve and add comments
Change-Id: I45c9fc55243224909ca2fdece8cbfa686b0f444d Reviewed-on: https://gerrit.osmocom.org/139 Tested-by: Jenkins Builder Reviewed-by: Harald Welte <laforge@gnumonks.org>
-rw-r--r--src/decoding.cpp3
-rw-r--r--src/decoding.h3
2 files changed, 4 insertions, 2 deletions
diff --git a/src/decoding.cpp b/src/decoding.cpp
index 0c81b2a7..5f64ac01 100644
--- a/src/decoding.cpp
+++ b/src/decoding.cpp
@@ -32,7 +32,7 @@ extern "C" {
#include <string.h>
#define LENGTH_TO_END 255
-/*
+/*!
* \returns num extensions fields (num frames == offset) on success,
* -errno otherwise.
*/
@@ -197,6 +197,7 @@ int Decoding::rlc_data_from_ul_data(
e = rdbi->e;
if (e) {
if (chunks_size > 0) {
+ /* Block without LI means it only contains data of one LLC PDU */
chunks[num_chunks].offset = offs;
chunks[num_chunks].length = LENGTH_TO_END;
chunks[num_chunks].is_complete = is_last_block;
diff --git a/src/decoding.h b/src/decoding.h
index 1043d673..50c9e7d3 100644
--- a/src/decoding.h
+++ b/src/decoding.h
@@ -28,10 +28,11 @@ struct bitvec;
class Decoding {
public:
+ /* represents (parts) LLC PDUs within one RLC Data block */
struct RlcData {
uint8_t offset;
uint8_t length;
- bool is_complete;
+ bool is_complete; /* if this PDU ends in this block */
};
static int rlc_data_from_ul_data(