diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2023-04-14 14:38:30 +0200 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2023-05-10 12:41:17 +0000 |
| commit | 8984afa5d0cb2bc5ca73973de78d63fab7d140aa (patch) | |
| tree | 319e47a9f8cdd4880ae19045d5246c2470a3cdd4 | |
| parent | 6ee8d136d3126b8392495f52510ed662b9b8fb32 (diff) | |
pcu_l1_if: replace magic numbers with IMSI_DIGITS_FOR_PAGING
we have defined IMSI_DIGITS_FOR_PAGING but some parts of the code still
use magic numbers (3), let's replace those as well.
Change-Id: I9a1b6ba4578e2a8875d8d1a9e56c36dc2b33fe0d
| -rw-r--r-- | src/pcu_l1_if.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index a830c318..85aaddcc 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -276,11 +276,12 @@ void pcu_l1if_tx_pch(struct gprs_rlcmac_bts *bts, bitvec *block, int plen, const /* block provided by upper layer comes without first byte (plen), prepend it manually: */ OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len); - data[3] = (plen << 2) | 0x01; + data[IMSI_DIGITS_FOR_PAGING] = (plen << 2) | 0x01; bitvec_pack(block, data + IMSI_DIGITS_FOR_PAGING + 1); if (the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PCH)) - gsmtap_send(the_pcu->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0, data + 3, GSM_MACBLOCK_LEN); + gsmtap_send(the_pcu->gsmtap, 0, 0, GSMTAP_CHANNEL_PCH, 0, 0, 0, 0, + data + IMSI_DIGITS_FOR_PAGING, GSM_MACBLOCK_LEN); pcu_tx_data_req(bts, 0, 0, PCU_IF_SAPI_PCH, 0, 0, 0, data, sizeof(data)); } |