diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-02-27 22:37:28 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-03-28 14:34:55 +0000 |
| commit | 89b85e078e93988ef4f7a3867c0c571738219285 (patch) | |
| tree | d72847279be1efd99f6aad85f01ac6ab4e2aff4e | |
| parent | f75381498ca298679e8dfba63cc4e33e0b969a17 (diff) | |
Revert "Use Timing Advance Index in UL assignments"
This reverts commit 6298fbb7b2f3639fde994633e33ba54a64a6ef9b,
I8b17be78a46c0bc17516b7c90f35aa4768010ae4.
Commit I52ec9b07413daabba8cd5f1fba5c7b3af6a33389 /
896574e92bea09ed8d39688b6fdf504e84521746 was found (empirically) to be a
regression, rendering GPRS service fatally unreliable.
This reverted commit seems to follow after the regression and is reverted along
with it.
Related: OS#3013
Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6
| -rw-r--r-- | src/encoding.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/encoding.cpp b/src/encoding.cpp index 39cbe249..e96894f2 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -255,9 +255,7 @@ static inline int write_ia_rest_uplink(const gprs_rlcmac_ul_tbf *tbf, bitvec * d rc = write_alpha_gamma(dest, alpha, gamma); check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest); /* No TIMING_ADVANCE_INDEX */ set_0(dest); /* No TBF_STARTING_TIME */ } else { set_0(dest); /* Single Block Allocation */ @@ -319,9 +317,7 @@ static inline int write_ia_rest_egprs_uplink(const gprs_rlcmac_ul_tbf *tbf, bitv rc = write_alpha_gamma(dest, alpha, gamma); /* ALPHA and GAMMA */ check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest); /* No TIMING_ADVANCE_INDEX */ set_0(dest); /* No TBF_STARTING_TIME */ bitvec_set_bit(dest, L); /* No Additions for Rel-7 */ } else { |