diff options
| author | Stefan Sperling <ssperling@sysmocom.de> | 2018-05-02 14:53:16 +0200 |
|---|---|---|
| committer | Stefan Sperling <ssperling@sysmocom.de> | 2018-05-02 14:53:16 +0200 |
| commit | 513c9bca17b32a97befd87930b2f9c21339dd3c1 (patch) | |
| tree | ee6f2095e4900bd4c21899f3bbc982ae87907c8b | |
| parent | 33c52b6271677bbbbc44f70fd7f10270e4a2c06f (diff) | |
improve documentation of Encoding::write_paging_request()
Add pointers to relevant parts of the spec. Tweak comments to be
more specific about the values being written and abbreviations used.
Change-Id: Ia5bf3f7f8846198b7b4e25ff1accf6206764be74
| -rw-r--r-- | src/encoding.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/encoding.cpp b/src/encoding.cpp index b2da1e84..1f96458b 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -609,7 +609,7 @@ void Encoding::write_packet_downlink_assignment(RlcMacDownlink_t * block, pda_r99->Exist_COMPACT_ReducedMA = 0; } -/* generate paging request */ +/* Generate paging request. See 44.018, sections 10 and 9.1.22 */ int Encoding::write_paging_request(bitvec * dest, uint8_t *ptmsi, uint16_t ptmsi_len) { unsigned wp = 0; @@ -617,7 +617,7 @@ int Encoding::write_paging_request(bitvec * dest, uint8_t *ptmsi, uint16_t ptmsi bitvec_write_field(dest, &wp,0x0,4); // Skip Indicator bitvec_write_field(dest, &wp,0x6,4); // Protocol Discriminator - bitvec_write_field(dest, &wp,0x21,8); // Paging Request Message Type + bitvec_write_field(dest, &wp,0x21,8); // Paging Request Message Type 1 bitvec_write_field(dest, &wp,0x0,4); // Page Mode bitvec_write_field(dest, &wp,0x0,4); // Channel Needed @@ -636,7 +636,7 @@ int Encoding::write_paging_request(bitvec * dest, uint8_t *ptmsi, uint16_t ptmsi "multiple of 8 bits, PLEASE FIX!\n"); plen = wp / 8; - bitvec_write_field(dest, &wp,0x0,1); // "L" NLN(PCH) = off + bitvec_write_field(dest, &wp,0x0,1); // "L" Notification List Number; NLN(PCH) = off bitvec_write_field(dest, &wp,0x0,1); // "L" Priority1 = off bitvec_write_field(dest, &wp,0x1,1); // "L" Priority2 = off bitvec_write_field(dest, &wp,0x0,1); // "L" Group Call information = off |