aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Eversberg <jolly@eversberg.eu>2012-07-25 09:14:09 +0200
committerAndreas Eversberg <jolly@eversberg.eu>2012-07-25 09:14:09 +0200
commitba1cd9bbc222bd62a4d1ef4bbb6d380347f04f5f (patch)
tree41f2bb4a2fa1dddc941411aa9ef2644c470247c0
parent6681bb8d0c847ad59a1e6109689ec322884e8e27 (diff)
Fixed two issues found by clang, pointed out by Holger
-rw-r--r--src/gprs_bssgp_pcu.cpp3
-rw-r--r--src/gprs_rlcmac.cpp2
2 files changed, 4 insertions, 1 deletions
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index d4a6557..c4d27e8 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -235,6 +235,9 @@ int gprs_bssgp_pcu_rx_ptp(struct msgb *msg, struct tlv_parsed *tp, struct bssgp_
uint8_t pdu_type = bgph->pdu_type;
unsigned rc = 0;
+ if (!bctx)
+ return -EINVAL;
+
/* If traffic is received on a BVC that is marked as blocked, the
* received PDU shall not be accepted and a STATUS PDU (Cause value:
* BVC Blocked) shall be sent to the peer entity on the signalling BVC */
diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp
index c9279c5..a827d36 100644
--- a/src/gprs_rlcmac.cpp
+++ b/src/gprs_rlcmac.cpp
@@ -370,7 +370,7 @@ int alloc_algorithm_b(struct gprs_rlcmac_tbf *old_tbf,
uint8_t tx_win_min, tx_win_max, tx_range;
uint8_t rx_window = 0, tx_window = 0;
const char *digit[10] = { "0","1","2","3","4","5","6","7","8","9" };
- uint8_t usf[8];
+ int8_t usf[8] = { -1, -1, -1, -1, -1, -1, -1, -1 }; /* must be signed */
int8_t tsc = -1; /* must be signed */
uint8_t i, ts;