aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-12-12 14:42:35 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-12-12 14:42:35 +0100
commitb3a87ced5ab427b3ab95d79557ddad1cac254c6c (patch)
treeaf2c0f6a95eaee2d55e77428438ce6be343aa9ad
parent81e8f0a8a2329333a366c2e655c452ff6d90a833 (diff)
test: Remove the side-effect from the assertion
Coverity complains about this code as it doesn't know that the OSMO_ASSERT is always on. But it is good practice to now have the side-effect in here. Fixes: Coverity CID 1080724
-rw-r--r--tests/emu/test_replay_gprs_attach.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/emu/test_replay_gprs_attach.cpp b/tests/emu/test_replay_gprs_attach.cpp
index 9bcab57..8d29a72 100644
--- a/tests/emu/test_replay_gprs_attach.cpp
+++ b/tests/emu/test_replay_gprs_attach.cpp
@@ -78,7 +78,8 @@ void test_replay_gprs_data(struct gprs_bssgp_pcu *pcu, struct msgb *msg, struct
OSMO_ASSERT(ph.cmd == GPRS_LLC_UI);
OSMO_ASSERT(ph.sapi == 1);
- OSMO_ASSERT(ph.seq_tx == next_wanted_nu++);
+ OSMO_ASSERT(ph.seq_tx == next_wanted_nu);
+ next_wanted_nu += 1;
/* this test just wants to see messages... no further data is sent */
if (next_wanted_nu == 6) {