aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
7 dayslogging typo 'extected'neels/dgsm_and_codecsNeels Hofmeyr1-1/+1
Change-Id: I6ebdf3aa49bc27544414be1a4a0334e28faa83aa
7 dayssend the RAT type (GERAN-A / UTRAN-Iu) to HLR on LUNeels Hofmeyr13-69/+71
Use new OSMO_GSUP_RAT_TYPES_IE to transmit the subscriber's RAT type to the HLR. Depends: I3e399ca8a85421f77a9a15e608413d1507722955 (osmo-hlr) Change-Id: I1b0c43c5ab03bc4dd146fdb3f5479b131d4f3b67
7 dayssms-over-gsup fixupsNeels Hofmeyr1-10/+17
Change-Id: I9b03a7db839731aee6db3b0b7a525d7502a2c373
7 daysgsup routing errorNeels Hofmeyr1-0/+9
Change-Id: I57e42662a04e02ad44719ef223b6c7b91887f9ef
7 daysFix duplicate SMS when SMPP returns to same MSCNeels Hofmeyr2-4/+15
Change-Id: I8c9b61dc05bda6f2b09cbc1890de1f2702f7abc8
7 dayscharts: Makefile: add '%.ladder' to '%.msc' ruleNeels Hofmeyr1-0/+4
7 daysadd full SDP codec information to the MNCC socketNeels Hofmeyr27-443/+5489
This way osmo-msc can benefit from the complete codec information received via SIP, which was so far terminated at osmo-sip-connector. osmo-sip-connector could/should have translated the received SDP to MNCC bearer_cap, but this was never implemented properly. Since osmo-msc already handles SDP towards the MGW, it makes most sense to pass SDP to osmo-msc transparently. To be able to send a valid RTP IP:port in the SDP upon the first MNCC_SETUP_IND going out, move the CN side CRCX to the very start of establishing a voice call. As a result, first create MGW conns for both RAN and CN before starting. The voice_call_full.msc chart shows the change in message sequence for MO and MT voice calls. Implement cc_sdp.c, which accumulates codec information from various sources (MS, BSS, Assignment, remote call leg) and provides filtering to get the available set of codecs at any point in time. Implement codec_sdp_cc_t9n.c, to translate between SDP and the various libosmo-mgcp-client, CC and BSSMAP representations of codecs: - Speech Version, - Permitted Speech, - Speech Codec Type, - default Payload Type numbers, - enum mgcp_codecs, - FR/HR compatibility - SDP audio codec names, - various AMR configurations. A codec_map lists these relations in one large data record. Various functions provide conversions by traversing this map. Add trans->cc.mnccc_release_sent: so far, avoiding to send an MNCC release during trans_free() was done by setting the callref = 0. But that also skips CC Release. On codec mismatch, we send a specific MNCC error code but still want a normal CC Release: hence send the MNCC message, set mnccc_release_sent = true and do normal CC Release in trans_free(). (A better way to do this would be to adopt the mncc_call FSM from inter-MSC handover also for local voice calls, but that is out of scope for now. I want to try that soon, as time permits.) Change-Id: I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f
9 dayslibmsc/sdp: cosmetic: fix less-than-zero comparison of an unsigned valueHEADmasterVadim Yanitskiy1-1/+1
Change-Id: I57ed17d8457ada69a3c22233f30339d2c0f65bce Fixes: CID#206075
2020-01-29osmo-msc: use stderr to print error messages, not stdoutVadim Yanitskiy1-11/+12
Change-Id: I702dd054d2e881b526f701ca482ec0f64ba8da28
2020-01-29libmsc/gsm_04_11.h: remove unused sms_deliver definitionVadim Yanitskiy1-18/+0
Change-Id: Icd4b0c45d994dd02d9118890eb5a1261a2008eca
2020-01-27libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMMVadim Yanitskiy2-6/+6
Change-Id: I006c2b4c684dc6b96e98dbb82063a0aa37e33c66
2020-01-27libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info()Vadim Yanitskiy1-2/+3
Change-Id: I2a0991c9bbf86b7eb248d74334f9472c56a3c964
2020-01-27VTY: cosmetic: make struct cmd_node for GSMNET_NODE staticVadim Yanitskiy1-1/+1
We don't need to expose it anyway. Change-Id: Icbaed6b3b15aa719a19bb4be8fed347073025a22
2020-01-27msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name()Vadim Yanitskiy1-2/+2
The problem is that osmo_rat_type_name() calls get_value_string(), so we first cast -1 to 'const enum osmo_rat_type' and then to 'uint32_t'. Let's rather use OSMO_RAT_UNKNOWN. Found by GCC with -Wextra in CFLAGS: warning: operand of ?: changes signedness from ‘int’ to ‘const enum osmo_rat_type’ due to unsignedness of other operand [-Wsign-compare] Change-Id: I63ba355102d3cc035ba90121e06aba7cf1776aa0
2020-01-27vlr_sgs_fsm: add missing break, do not call to_null() twiceVadim Yanitskiy1-0/+1
Change-Id: Ib5d1d7633ca6c32d7d63bb1481f51355c97b90fb
2020-01-27vlr: remove unused parameter 'log_level' of auth_fsm_start()Vadim Yanitskiy4-4/+2
We unconditionally use logging level of the parent FSM anyway. All callers of auth_fsm_start() always pass fi->log_level. Change-Id: If2fdf2564eb56d3d94ec3800bdcb0aabcad4e48d
2020-01-25libmsc: move subscriber expiration timer T3212 to libvlrVadim Yanitskiy8-69/+54
Since the split of OsmoNiTB, OsmoMSC does not deal with the radio access network directly. Therefore the only purpose of T3212 is to control subscriber expiration in the local VLR. The timeout value indicated in System Information Type 3 needs to be configured separately in the BSC/RNC. This means that we don't need to store it in deci-hours anymore. Let's move T3212 to the group of VLR specific timers, so it can be configured and introspected using the generic 'timer' command, and deprecate the old '[no] periodic location update' command. It should be also noted that in the old code subscriber expiration timeout was actually set to twice the T3212 value plus one minute. After this change, we apply the configured value 'as-is', but keep the old behaviour for 'periodic location update' command. Change-Id: I9b12066599a7c834a53a93acf5902d91273bc74f
2020-01-25libvlr: use generic osmo_tdef API for T3250, T3260, and T3270Vadim Yanitskiy6-28/+22
These timers so far were implemented as a list of unsigned integers, which has never been initialized to any reasonable defaults. Since they are used as state timeouts in several FSMs, we might end up staying in some state forever. Let's migrate to generic osmo_tdef API and use default values from table 11.2 of 3GPP TS 24.008. This way the user can introspect and change their values from the VTY / configuration file. Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f Related: OS#4368
2020-01-25VTY: add osmo_tdef introspection and configuration commandsVadim Yanitskiy5-0/+67
This change introduces several new VTY commands letting the user a possibility to introspect and reconfigure some of the existing timers implemented using libosmocore's osmo_tdef API. At the moment this covers the following timers: - MGW specific timers: - X1 - MGCP response timeout, - X2 - RTP stream establishing timeout, - RAN specific timers (same names for GERAN and UTRAN): - X1 - Authentication and Ciphering timeout, - X2 - RAN connection release sanity timeout, - X3 - Handover procedure timeout. The following commands are introduced: - 'enable' node: - show timer [(mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] - 'config-msc' node: - timer [(mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] [(<0-2147483647>|default)] Both MNCC and SCCP related timer definitions are empty at the moment. Achieved by using osmo_tdef_group API of libosmovty. Change-Id: I6024c104b6101666c8aa1108a043910eb75db9a5 Related: OS#4368
2020-01-25VTY: mark 'subscriber create imsi' command as deprecatedVadim Yanitskiy2-23/+6
Neither it should appear in the interactive VTY nor in documentation. Change-Id: I208faab69a40948af5d081edbeaf75f586dfb2e4
2020-01-20msc/signal.h: remove unused (since the NiTB split up) signalsVadim Yanitskiy1-9/+0
Change-Id: I3848d0db3c62de7613f609ad632641eb54453817
2020-01-19osmo-msc: fix: properly initialize default values for MGW timersVadim Yanitskiy1-1/+3
Otherwise they're all set to 0, if not configured in the VTY. Change-Id: I4a0823c2f0ca50ed7407fb0457c54a485799c585
2020-01-19libvlr: remove unused 'periodic_lu_timer' from struct vlr_subscrVadim Yanitskiy1-1/+0
It's never used anywhere in the code. Change-Id: I1b322b57fa0fd17ae2ebe1a2af2d8a93d81e14f0
2020-01-18manuals/vty: update the VTY reference to reflect recent changesVadim Yanitskiy1-37/+439
Change-Id: I14a5c9adff649406b4a079a75f86167ae6b95db4
2020-01-15libmsc: SMS, Avoid premature RP-ACK to MSPablo Neira Ayuso2-2/+12
There was one libmsc commit to openbsc that was thus far missing in osmo-msc. This commit completes the work on delayed response from an ESME. Without this patch, the SMR sends an RP-ACK to the mobile station, and subsequently a DELIVER_SM_REPONSE from the ESME provokes either a second RP-ACK, or an RP-ERROR; both of which result in "unhandled at this state (IDLE)" from the SMR After this patch, we have two things corrected: 1) RP-ERROR respects Deliver-SM error cause. 2) No more "unhandled as this state" error from the SMR Extract from original commit message: -------- libmsc: annotate esme route in the sms object from deliver_to_esme() Annotate this esme route, so we can use it to return -EINPROGRESS to skip sending premature RP-ACK to the mobile station, in case we're handling sms routes through SMPP. -------- Fixes: #OS4351 Change-Id: Ic34d398e0a850856e20380ae35e5c2ae5e3c539b
2020-01-13Trivial: code simplification, return earlyKeith Whyte1-19/+19
This commit also, (for what it is worth) removes a difference to the same file in openbsc, which I found while looking for changes that affected SMPP delivery. This is essentially a "forward-port" of [1] [1] https://gerrit.osmocom.org/#/c/openbsc/+/3899/ Change-Id: I350c19f5bb70b2656171c096334c2ee83f49df7e
2020-01-11Use GSM411_RP_* and not GSM48_CC_*Keith Whyte1-2/+3
d34ed5768cccab57e879bd32f38872d290c9ae89 introduced comparison of GSM411_RP_CAUSE_MO_NUM_UNASSIGNED with GSM48_CC_CAUSE_UNASSIGNED_NR For consistency lets use the GSM411_RP constants in SMS related code. Change-Id: Ie54966560f66d2dcde905feb2eb19ef90406acd1
2020-01-09Bump version: 1.6.0.3-02dd2 → 1.6.11.6.1Pau Espin Pedrol1-0/+11
Change-Id: I3ac4ca12139230863607980cd29250c12df319b7
2020-01-06vlr.c: fix condition to check MSISDN presenceNeels Hofmeyr1-1/+1
msisdn_enc is a buffer, its address is always != 0 Change-Id: Ib2294d2cd339c36df599d7d134f979a572ac308a
2020-01-06vlr_gsup_rx: fix uninitialized rcNeels Hofmeyr1-1/+1
Change-Id: Id7776a473b8356d1d136d78736698f20accc7a36
2020-01-05libmsc/gsm_04_08.c: fix: verify MI before calling vlr_subscr_rx_id_resp()Vadim Yanitskiy2-0/+39
During the last congress, we have noticed that OsmoMSC crashes on receipt of malformed MM Identity Response messages: BSSAP Message Type: Direct Transfer (0x01) Data Link Connection Identifier 00.. .... = Control Channel: not further specified (0x0) ..00 0... = Spare: 0x0 .... .000 = SAPI: RR/MM/CC (0x0) Length: 11 GSM A-I/F DTAP - Identity Response Protocol Discriminator: Mobility Management messages (5) .... 0101 = Protocol discriminator: Mobility Management messages (0x5) 0000 .... = Skip Indicator: No indication of selected PLMN (0) 01.. .... = Sequence number: 1 ..01 1001 = DTAP Mobility Management Message Type: Identity Response (0x19) Mobile Identity - Format Unknown Length: 8 .... 1... = Odd/even indication: Odd number of identity digits .... .111 = Mobile Identity Type: Unknown (7) <-- This makes OsmoMSC crash [Expert Info (Warning/Protocol): Unknown format 7] [Unknown format 7] [Severity level: Warning] [Group: Protocol] The value '111'B is not a valid Mobile Identity type, and shall be considered as reserved according to 3GPP TS 24.008, section 10.5.1.4. Later on it was discovered that '000'B also crashes OsmoMSC in the same way. The crash itself is provoked by OSMO_ASSERT(0) in vlr_subscr_rx_id_resp(). Let's keep that assert in there, and make sure that: - on receipt of MM Identity Response, Mobile Identity type matches the one in MM Identity Request; - on receipt of RR Ciphering Mode Complete, Mobile Identity contains IMEI(SV) if present. Change-Id: Ica4c90b8eb4d90325313c6eb400fa4a6bc5df825 TTCN-3 test case: I62f23355eb91df2edf9dc837c928cb86b530b743 Fixes: OS#4340
2020-01-03Bump version: 1.5.0.72-6e72-dirty → 1.6.01.6.0Pau Espin Pedrol3-7/+101
Change-Id: I315ba8c67fbb5bec520f1bc42aedd25d47e4ca95
2019-12-19libmsc/gsm_04_11_gsup.c: fix SM-RP-OA encoding for MO SMS over GSUPfixeria/smsVadim Yanitskiy1-6/+12
We shall not include additional BCD length octet into the value part of SM-RP-OA (Originating Address) IE. Instead, there should be ToA/NPI header (1 octet). Since we do not get ToN/NPI fields from the VLR/HLR, let's assume the following default values: 1... .... = Extension: No extension .001 .... = Type of number: International (1) .... 0001 = Numbering plan: ISDN/telephone (E.164/E.163) (1) Change-Id: I0f32e2af0ed2d2fea6addf45efbdfee120c2425d TTCN-3 test case: Ib467eeca6439bc6cce72293fbb5bb48f6d233db9 Related: OS#4324
2019-12-19libmsc/gsm_04_11_gsup.c: do not init a buffer in gsm411_gsup_mo_fwd_sm_req()Vadim Yanitskiy1-1/+1
Because there is no real need for that. Change-Id: I19d4d0de0d5a46bf1de194b966f18ea8a84ced94
2019-12-12sms log tweakNeels Hofmeyr1-1/+1
Change-Id: I77e7a1501f74b9045f032c5b6c2322025a11fd59
2019-12-12sms db: when storing an SMS, retrieve the IDNeels Hofmeyr1-0/+3
seemed like a good idea, but not sure if we need it at all. Change-Id: I5fa55307a6abb8bbfe56619235d7b79fbbda6caf
2019-12-12osmoappdesc.py, tests: switch to python 3Oliver Smith4-60/+60
Make build and external tests work with python3, so we can drop the python2 dependency. This should be merged shortly after osmo-python-tests was migrated to python3, and the jenkins build slaves were (automatically) updated to have the new osmo-python-tests installed. Related: OS#2819 Depends: osmo-python-tests I3ffc3519bf6c22536a49dad7a966188ddad351a7 Change-Id: I53ccde96dd3785098df0f7d693c504c8b8302e90
2019-12-12gsup: indicate CN-Domain in SendAuthInfo RequestsNeels Hofmeyr22-146/+148
In order for osmo-hlr to be able to 100% guarantee distinct INDs for CS and PS, set CN-Domain = CS in all SendAuthInfo Requests. In Milenage auth, it is highly desirable that osmo-hlr guarantees use of distinct INDs for CS and PS domains. If an MSC and SGSN attached at the same time use the same IND bucket to generate Milenage SQN, that collision would rapidly waste SQNs and load osmo-hlr with requesting new auth tuples on each CS/PS Complete-Layer3. So far, osmo-msc did not indicate the CN domain in the GSUP SendAuthInfo Request, which was neither required nor evaluated. The CN-Domain is only sent for the UpdateLocation Request that usually follows later. Related: OS#4318 Change-Id: I22f44068268e62801cadbf6542efaf153423cd65
2019-12-03msc: exit(2) on unsupported positional arguments on command lineHarald Welte1-0/+5
Change-Id: Iad858974e9d97ae14f3da6dc21267aafafcda0ef
2019-12-02libmsc: fix potential NULL-pointer dereferences detected by GCC's LTOVadim Yanitskiy2-1/+9
Change-Id: Ib7ba8909dce64d1b8ff3a53495fe3eefc446ed8e
2019-12-02counters: polish documentation of cm_service_request / paging_respVadim Yanitskiy2-8/+8
Change-Id: I273bc4165c70cd54ed94ff5f99377189f3306f51
2019-12-02counters: clarify documentation for MSC_CTR_CALL_* entriesVadim Yanitskiy2-14/+14
Change-Id: Iad1ef917a229c3be51bd8fbe155f009f81e7d72a
2019-12-02counters: clarify documentation for MSC_CTR_LOC_UPDATE_* entriesVadim Yanitskiy2-12/+12
Change-Id: I4f4a0d644db0a2dd7c8eefd846ea6913c0b780ce
2019-12-02counters: clarify documentation for MSC_CTR_SMS_* entriesVadim Yanitskiy2-13/+14
Please note that counter "sms:delivered" assumes "Delivered MT SMS", but actually counts total number MT SMS delivery attempts. This change describes its _actual_ (erroneous) behaviour. Change-Id: I081cf962ce2658ceab02699f3cdee19658d00939 Related: OS#4273
2019-12-01Check for osmo_fsm_register() error return valueHarald Welte2-2/+2
Change-Id: I4cce3d6798fe3184a3085d114b749b4645620978
2019-12-01manual: Fix copy+paste errorHarald Welte1-1/+1
Change-Id: I2c03d8424c218155dae9038dd7cc5660a290c5c8
2019-12-01check for osmo_ss7_init() error return valueHarald Welte1-1/+1
Change-Id: I2bc34f3962ca7355f20757e36a86ab2fd1a7aef6
2019-11-28msc_vlr_test_call: rename lu_utran_tmsiNeels Hofmeyr2-16/+16
Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396
2019-11-28msc_vlr_tests: log descriptions in color with -vNeels Hofmeyr1-1/+4
Change-Id: I2b28a94a5b27932e343952ba82e7e11c46f5e87d
2019-11-28msc_vlr_test_call.c: add MNCC loggingNeels Hofmeyr2-5/+41
Change-Id: I03b25c134553c620d3fa9d23a67ad39414546861