aboutsummaryrefslogtreecommitdiffstats
path: root/tests/msc_vlr/msc_vlr_test_reject_concurrency.c
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2018-06-15 23:57:30 +0700
committerHarald Welte <laforge@gnumonks.org>2018-07-29 16:22:06 +0200
commit2760585cca854b1ca5ac7e74b015e31c157a66c5 (patch)
tree775d55281ed5363ed9da3c4f87576b7c2579ae89 /tests/msc_vlr/msc_vlr_test_reject_concurrency.c
parenta4efe3f435211a46195385012788fcaa7b8849c4 (diff)
msc_vlr_tests: don't abuse USSD-request to conclude connections
Previously the '*#100#' USSD-request was abused in order to conclude the current subscriber connection. This makes the unit tests depend on each other, for example, if one break something in the GSM 09.11 implementation, a half of tests would fail. Moreover, the further changes in the GSM 09.11 implementation will make the results less predictable (i.e. session ID, etc.). So let's introduce a separate unit test with simple request- response logic, while more complex tests will be in TTCN. Change-Id: I40b4caac3113263f5a06c861dff5e10d43c319b5
Diffstat (limited to 'tests/msc_vlr/msc_vlr_test_reject_concurrency.c')
-rw-r--r--tests/msc_vlr/msc_vlr_test_reject_concurrency.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/tests/msc_vlr/msc_vlr_test_reject_concurrency.c b/tests/msc_vlr/msc_vlr_test_reject_concurrency.c
index ea8c32cab..580135a0e 100644
--- a/tests/msc_vlr/msc_vlr_test_reject_concurrency.c
+++ b/tests/msc_vlr/msc_vlr_test_reject_concurrency.c
@@ -313,11 +313,10 @@ static void test_reject_paging_resp_during_cm()
EXPECT_CONN_COUNT(1);
BTW("The original CM Service Request can conclude");
- btw("a USSD request is serviced");
- dtap_expect_tx_ussd("Your extension is 46071\r");
- expect_bssap_clear();
- ms_sends_msg("0b3b1c15a11302010002013b300b04010f0406aa510c061b017f0100");
- VERBOSE_ASSERT(bssap_clear_sent, == true, "%d");
+
+ /* Release connection */
+ expect_bssap_clear(RAN_GERAN_A);
+ conn_conclude_cm_service_req(g_conn, RAN_GERAN_A);
btw("all requests serviced, conn has been released");
bss_sends_clear_complete();