diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2019-09-03 01:08:07 +0200 |
|---|---|---|
| committer | neels <nhofmeyr@sysmocom.de> | 2019-09-03 13:59:05 +0000 |
| commit | 4b78b29b8cd9f106c5f7784944e4b1e41eb02f77 (patch) | |
| tree | a541016491d58e2e09e8ba4f8f8a19d357d8478f /src | |
| parent | 991bb422d417d24b25c40dbca5b312c385a5a668 (diff) | |
vlr: don't log about "gratuitous ID RESPONSE"
If an ID Response comes in during a non-LU L3 Complete (Paging or CM Service
Request), no event needs to be dispatched. So far vlr_subscr_rx_id_resp()
logged a NOTICE "gratuitous ID RESPONSE?!?" if no lu_fsm is present.
An ID Response can come in particularly as payload with a BSSMAP Cipher Mode
Complete message, even though osmo-msc didn't explicitly ask for it.
It is not an error to get a Cipher Mode Complete containing an ID Response
during Paging or CM Service Request, so remove the confusing log message.
Related: OS#4168 (only loosely related)
Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac
Diffstat (limited to 'src')
| -rw-r--r-- | src/libvlr/vlr.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index de61ba5a2..ea160b148 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1182,8 +1182,6 @@ int vlr_subscr_rx_id_resp(struct vlr_subscr *vsub, break; } osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string); - } else { - LOGVSUBP(LOGL_NOTICE, vsub, "gratuitous ID RESPONSE?!?\n"); } return 0; |