diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2017-11-07 15:48:29 +0100 |
|---|---|---|
| committer | dexter <pmaier@sysmocom.de> | 2017-11-20 09:23:55 +0000 |
| commit | e4db08a8b5d7525b3e496d0d2eaf6df3c64bf679 (patch) | |
| tree | d2f8ff3c13a60a1299f47ec077dd9ad22f883a9d /src/libmsc/gsm_04_08.c | |
| parent | 8ae3c924ef898a3ec6c3831e82ebd24e708779ff (diff) | |
cosmetic: move log message to else branch
The log message after the nullpointer check for conn tricks Coverity
Scan into detecting a nullpointer deref.
Include the log message into else branch to state the program flow
more clearly
Fixes: Coverity CID#178656
Change-Id: If6e962f4033c955ecd3539a719031a83c9b6205a
Diffstat (limited to 'src/libmsc/gsm_04_08.c')
| -rw-r--r-- | src/libmsc/gsm_04_08.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 8a5265bc8..438f681b7 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -3004,15 +3004,15 @@ int mncc_tx_to_cc(struct gsm_network *net, int msg_type, void *arg) trans->callref = 0; trans_free(trans); return rc; + } else { + DEBUGP(DCC, "(ti %02x sub %s) " + "Received '%s' from MNCC in state %d (%s)\n", + trans->transaction_id, + vlr_subscr_msisdn_or_name(trans->conn->vsub), + get_mncc_name(msg_type), trans->cc.state, + gsm48_cc_state_name(trans->cc.state)); } - DEBUGP(DCC, "(ti %02x sub %s) " - "Received '%s' from MNCC in state %d (%s)\n", - trans->transaction_id, - vlr_subscr_msisdn_or_name(trans->conn->vsub), - get_mncc_name(msg_type), trans->cc.state, - gsm48_cc_state_name(trans->cc.state)); - /* Find function for current state and message */ for (i = 0; i < DOWNSLLEN; i++) if ((msg_type == downstatelist[i].type) |