diff options
| author | Max <msuraev@sysmocom.de> | 2017-01-11 18:37:55 +0100 |
|---|---|---|
| committer | Max <msuraev@sysmocom.de> | 2017-01-25 11:52:45 +0000 |
| commit | f6e51709fc3a79274646135fec1a603d4316acf6 (patch) | |
| tree | 9003843cb78270a629b56dccc7820beeee302ba0 /openbsc/src/libmsc | |
| parent | 76f048a1fdf8247ba28a373d989215a5493895ea (diff) | |
CTRL: remove boilerplate
Use CTRL_CMD_DEFINE_RO(), CTRL_CMD_DEFINE_WO() and
CTRL_CMD_DEFINE_WO_NOVRF() where appropriate to get rid of boilerplate
code.
Change-Id: I5bcea0b4f4b8f535bef2b423f2013b8b4a218b5b
Diffstat (limited to 'openbsc/src/libmsc')
| -rw-r--r-- | openbsc/src/libmsc/ctrl_commands.c | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/openbsc/src/libmsc/ctrl_commands.c b/openbsc/src/libmsc/ctrl_commands.c index d153247b0..a56d122d2 100644 --- a/openbsc/src/libmsc/ctrl_commands.c +++ b/openbsc/src/libmsc/ctrl_commands.c @@ -75,12 +75,6 @@ static int verify_subscriber_modify(struct ctrl_cmd *cmd, const char *value, voi return rc; } -static int get_subscriber_modify(struct ctrl_cmd *cmd, void *data) -{ - cmd->reply = "Set only attribute"; - return CTRL_CMD_ERROR; -} - static int set_subscriber_modify(struct ctrl_cmd *cmd, void *data) { struct gsm_network *net = cmd->node; @@ -157,18 +151,7 @@ fail: return CTRL_CMD_ERROR; } -CTRL_CMD_DEFINE(subscriber_modify, "subscriber-modify-v1"); - -static int verify_subscriber_delete(struct ctrl_cmd *cmd, const char *v, void *d) -{ - return 0; -} - -static int get_subscriber_delete(struct ctrl_cmd *cmd, void *data) -{ - cmd->reply = "Set only attribute"; - return CTRL_CMD_ERROR; -} +CTRL_CMD_DEFINE_WO(subscriber_modify, "subscriber-modify-v1"); static int set_subscriber_delete(struct ctrl_cmd *cmd, void *data) { @@ -199,7 +182,7 @@ static int set_subscriber_delete(struct ctrl_cmd *cmd, void *data) cmd->reply = was_used ? "Removed active subscriber" : "Removed"; return CTRL_CMD_REPLY; } -CTRL_CMD_DEFINE(subscriber_delete, "subscriber-delete-v1"); +CTRL_CMD_DEFINE_WO_NOVRF(subscriber_delete, "subscriber-delete-v1"); static int verify_subscriber_list(struct ctrl_cmd *cmd, const char *value, void *d) { |