diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-12-28 21:22:32 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2019-01-04 01:46:46 +0000 |
| commit | 1035d90c1761d4ab94c998908a475a8dbc09b50c (patch) | |
| tree | 0f2d22b8039c4a7bc1cfac1a9bba51bc9bf13d3c /include/osmocom | |
| parent | 3350bf9f78253eb9f647c8377b6446a4fc7b26e8 (diff) | |
fix vlr ops.subscr_assoc re-association
In rare cases, a conn is already associated with a subscriber. So far, we
abort()ed on that, bringing the entire osmo-msc down. Rather log an error and
keep the service running.
In vlr.ops.subscr_assoc, add success/failure return value, and abort the
LU/PARQ on error.
I haven't figured out in detail yet why/how a subscriber would re-launch a
LU/PARQ on a conn that is already associated, so far it is merely clear that we
do not want to crash the MSC if that happens. A log is in OS#3742.
Related: OS#3742, OS#3743
Change-Id: Ic0d54644bc735700220b1ef3a4384c217d57d20f
Diffstat (limited to 'include/osmocom')
| -rw-r--r-- | include/osmocom/msc/vlr.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h index 20a9c0f24..3c778a96b 100644 --- a/include/osmocom/msc/vlr.h +++ b/include/osmocom/msc/vlr.h @@ -235,7 +235,7 @@ struct vlr_ops { void (*subscr_update)(struct vlr_subscr *vsub); /* notify MSC/SGSN that the given subscriber has been associated * with this msc_conn_ref */ - void (*subscr_assoc)(void *msc_conn_ref, struct vlr_subscr *vsub); + int (*subscr_assoc)(void *msc_conn_ref, struct vlr_subscr *vsub); /* Forward a parsed GSUP message towards MSC message router */ int (*forward_gsup_msg)(struct vlr_subscr *vsub, struct osmo_gsup_message *gsup_msg); |