aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2019-04-09 12:44:35 +0200
committerVadim Yanitskiy <axilirator@gmail.com>2019-04-09 19:45:03 +0700
commitf8af776fbac9c98d6b860a71afbff7caa474352d (patch)
tree16386e5a063d9b99079dd700e6e23351514cc17f
parent0f52319765e9834095c4774ef6a3b22825fa618c (diff)
sms_queue: Print dest msisdn instead of unknown subscriber
If subscriber is NULL, vlr_subscr_msisdn_or_name() returns string "unknown", which is less informative than printing destination msisdn expected for the queued sms. This happens for instance if an sms was queued with Store&Forward and destination subscriber is not currently registered Change-Id: I4b8b54c9c41b17d4e1fa7ece63aa91a98036ef11
-rw-r--r--src/libmsc/sms_queue.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c
index 274c71295..afd878f1c 100644
--- a/src/libmsc/sms_queue.c
+++ b/src/libmsc/sms_queue.c
@@ -228,8 +228,10 @@ struct gsm_sms *smsq_take_next_sms(struct gsm_network *net,
/* Is the subscriber attached? If not, go to next SMS */
if (!sms->receiver || !sms->receiver->lu_complete) {
LOGP(DLSMS, LOGL_DEBUG,
- "Subscriber %s is not attached, skipping SMS %llu\n",
- vlr_subscr_msisdn_or_name(sms->receiver), sms->id);
+ "Subscriber %s%s is not attached, skipping SMS %llu\n",
+ sms->receiver ? "" : "MSISDN-",
+ sms->receiver ? vlr_subscr_msisdn_or_name(sms->receiver)
+ : sms->dst.addr, sms->id);
sms_free(sms);
continue;
}