aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax <msuraev@sysmocom.de>2019-01-17 13:38:10 +0100
committerMax <msuraev@sysmocom.de>2019-01-24 19:08:07 +0000
commit3614fd6d11b1d67e90df80915a2820732d3ec1e2 (patch)
tree7c7b6dd6742e3dad9dfa57880a56d1c42f1ed83b
parent80d8ffda8cdf6676b6d04693af2895d3bef4205f (diff)
Various logging fixes
Log transaction allocation errors as such. While at it, use proper subsystem to log missing VLR subscriber. Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
-rw-r--r--src/libmsc/gsm_04_08_cc.c4
-rw-r--r--src/libmsc/gsm_09_11.c4
-rw-r--r--src/libmsc/transaction.c2
3 files changed, 5 insertions, 5 deletions
diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index 717218416..0119e7b0c 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1931,7 +1931,7 @@ int mncc_tx_to_cc(struct gsm_network *net, int msg_type, void *arg)
/* Create transaction */
trans = trans_alloc(net, vsub, GSM48_PDISC_CC, 0xff, data->callref);
if (!trans) {
- DEBUGP(DCC, "No memory for trans.\n");
+ LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");
vlr_subscr_put(vsub);
/* Ressource unavailable */
mncc_release_ind(net, NULL, data->callref,
@@ -2129,7 +2129,7 @@ int gsm0408_rcv_cc(struct ran_conn *conn, struct msgb *msg)
GSM48_PDISC_CC,
transaction_id, new_callref++);
if (!trans) {
- DEBUGP(DCC, "No memory for trans.\n");
+ LOGP(DCC, LOGL_ERROR, "No memory for trans.\n");
rc = gsm48_tx_simple(conn,
GSM48_PDISC_CC | (transaction_id << 4),
GSM48_MT_CC_RELEASE_COMPL);
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index 12bec9db8..608d4ff99 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -101,7 +101,7 @@ int gsm0911_rcv_nc_ss(struct ran_conn *conn, struct msgb *msg)
trans = trans_alloc(conn->network, conn->vsub,
GSM48_PDISC_NC_SS, tid, new_callref++);
if (!trans) {
- DEBUGP(DMM, " -> No memory for trans\n");
+ LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");
gsm48_tx_simple(conn,
GSM48_PDISC_NC_SS | (tid << 4),
GSM0480_MTYPE_RELEASE_COMPLETE);
@@ -298,7 +298,7 @@ static struct gsm_trans *establish_nc_ss_trans(struct gsm_network *net,
trans = trans_alloc(net, vsub, GSM48_PDISC_NC_SS,
0xff, gsup_msg->session_id);
if (!trans) {
- DEBUGP(DMM, " -> No memory for trans\n");
+ LOGP(DMM, LOGL_ERROR, " -> No memory for trans\n");
return NULL;
}
diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index df770ed56..17f8e964c 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -109,7 +109,7 @@ struct gsm_trans *trans_alloc(struct gsm_network *net,
/* a valid subscriber is indispensable */
if (vsub == NULL) {
- LOGP(DCC, LOGL_NOTICE,
+ LOGP(DVLR, LOGL_ERROR,
"unable to alloc transaction, invalid subscriber (NULL)\n");
return NULL;
}