aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax <msuraev@sysmocom.de>2018-02-12 16:51:03 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2018-03-05 14:29:55 +0000
commit48d4ec06e180cfb60556ce6c565620078bbea8db (patch)
tree566187aa2305213a99a996fc5118c07b24b72fc0
parentda21a52c927b09949bfc1a5d18648d19c8fd3df1 (diff)
VLR: fix potential NULL dereference
The vlr_subscr_get() can return NULL if its argument is NULL (which isn't checked for) so before dereferencing it's result we should check for it. Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91
-rw-r--r--src/libmsc/gsm_04_08.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 995bbf6ce..f87a4c65a 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -3721,8 +3721,10 @@ static void msc_vlr_subscr_assoc(void *msc_conn_ref,
struct vlr_subscr *vsub)
{
struct gsm_subscriber_connection *conn = msc_conn_ref;
+ OSMO_ASSERT(vsub);
OSMO_ASSERT(!conn->vsub);
conn->vsub = vlr_subscr_get(vsub);
+ OSMO_ASSERT(conn->vsub);
conn->vsub->cs.attached_via_ran = conn->via_ran;
}