aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2020-04-20 10:42:28 +0700
committerVadim Yanitskiy <axilirator@gmail.com>2020-04-26 23:55:48 +0700
commit4547cf1c9972f27f3892c5e8a2150f9f8cb41fdc (patch)
tree663395912442fb41175181bba4915cadeec31f17
parentb1e46b17f7d71c2dc0682ff9b20bedfce297302c (diff)
SMS-over-GSUP: notify sender about malformed GSUP messages
-rw-r--r--src/libmsc/gsm_04_11_gsup.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index cf9d11d2e..7c9b6fb50 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -178,9 +178,8 @@ static int gsm411_gsup_mo_handler(struct gsm_network *net, struct vlr_subscr *vs
return 0;
msg_error:
- /* TODO: notify sender about that? */
- LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n",
- msg_name, msg_is_err ? "Err" : "Res");
+ LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", msg_name, msg_is_err ? "Err" : "Res");
+ gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO);
return -EINVAL;
}
@@ -269,8 +268,8 @@ static int gsm411_gsup_mt_handler(struct gsm_network *net, struct vlr_subscr *vs
return 0;
msg_error:
- /* TODO: notify sender about that? */
LOGP(DLSMS, LOGL_NOTICE, "RX malformed MT-forwardSM-Req\n");
+ gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO);
return -EINVAL;
}