sccp_node.c: Some cleanup to the code, fix obvious warnings.

2 files changed, 8 insertions, 15 deletions

diff --git a/src/Makefile.am b/src/Makefile.am
index fcde079..c9c9722 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,5 +1,5 @@
 INCLUDES = $(all_includes)
-AM_CFLAGS = $(ERLANG_CFLAGS)
+AM_CFLAGS = $(ERLANG_CFLAGS) -Wall
 
 bin_PROGRAMS = sccp_node
 
diff --git a/src/sccp_node.c b/src/sccp_node.c
index 63e2c35..6dc9b4d 100644
--- a/src/sccp_node.c
+++ b/src/sccp_node.c
@@ -5,6 +5,7 @@
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <string.h>
+#include <unistd.h>
 
 #include "erl_interface.h"
 #include "ei.h"
@@ -81,30 +82,21 @@ static int handle_command(int fd) {
 			} else if (strncmp(ERL_ATOM_PTR(fnp), "bar", 3) == 0) {
 				res = bar(ERL_INT_VALUE(argp));
 			}
-		}
 
-		resp = erl_format("{cnode, ~i}", res);
-		erl_send(fd, fromp, resp);
+			resp = erl_format("{cnode, ~i}", res);
+			erl_send(fd, fromp, resp);
+			erl_free_term(resp);
+		}
 
 		erl_free_term(emsg.from); erl_free_term(emsg.msg);
 		erl_free_term(fromp); erl_free_term(tuplep);
 		erl_free_term(fnp); erl_free_term(argp);
-		erl_free_term(resp);
 	}
 
 	return exit;
 }
 
 int main(int argc, char **argv) {
-#if 0
-  int port;                                /* Listen port number */
-  int listen;                              /* Listen socket */
-  int fd;                                  /* fd to Erlang node */
-
-  int loop = 1;                            /* Loop flag */
-  int res;
-#endif
-
 	ErlConnect conn;                         /* Connection data */
 	int port = 2342;
 	int server_fd;
@@ -112,7 +104,7 @@ int main(int argc, char **argv) {
 	int exit;
 	int quit = 0;
 
-	server_fd = init_erlang(2342, 2342, "123");
+	server_fd = init_erlang(port, port, "123");
 	if (server_fd < 0)
 		erl_err_quit("Failed to listen.");
 
@@ -129,4 +121,5 @@ int main(int argc, char **argv) {
 		close(fd);
 	}
 
+	return 0;
 }