aboutsummaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2021-01-14tests/hnb-test: Drop unused variablesPau Espin Pedrol1-3/+2
Change-Id: I12870a1cf2462b7cc2868a54f58416e03a856084
2021-01-14tests/hnb-test-ranap: Fix incorrect pointer type castPau Espin Pedrol1-1/+1
osmo_hexdump expect it to be a const unsigned char*, and gcc warns about incorrect signedness. Change-Id: I7e0622f502a4442d700340b0f1c2f8cd01e90ecd
2020-12-30hnbgw: Introduce LOGHNB() macro for log context informationHarald Welte2-0/+36
So far we don't really have any way of matching a given log message to a specific hNB. Let's introduce a new log macro, together with a configuration directive to select whether the hNB-ID or the UMTS CellID shall be used. Change-Id: I6113925216c6f88add2c6d27bdf47ccbb017f293
2020-12-30hnbgw: use OSMO_STRLCPY_ARRAY() instead of open coding itHarald Welte1-4/+3
Change-Id: I4c539168597187408c31b906fd57844e0f165c9b
2020-10-12hnbgw: Mark SCTP conn as NODELAYPau Espin Pedrol1-0/+1
We don't want messages to be sent being delayed. Related: OS#4499 Change-Id: I333e7f868e426f7d7ebb328ea2a441d769ea8ebd
2020-10-04vty: use install_lib_element() and install_lib_element_ve()Vadim Yanitskiy1-3/+3
See https://lists.osmocom.org/pipermail/openbsc/2020-October/013278.html. Change-Id: I5c0a1efc21a5cc085b701be24dbcca1aaae15ee6 Depends: I8baf31ace93c536421893c2aa4e3d9d298dcbcc6 Related: SYS#4937
2020-08-21Change default SCTP conn NULL->127.0.0.1 to localhost->localhostPau Espin Pedrol1-1/+1
"127.0.0.1" is changed to "localhost" to let local NSS decide whether to use IPv4 or IPv6. In newish systems, IPv6 ::1 will be selected since IPv6 takes precedence over IPv4. Similarly, the default source addr needs to be changed from NULL to "localhost" since for some yet unknwon reason, getaddrinfo(AF_UNSPEC, NULL) returns first IPv4 "0.0.0.0" and later "::", which is inconsistent with getaddrinfo("localhost") result, resulting in src=IPv4(0.0.0.0) and dst=IPv6(::1), which is incompatible and will fail. In any case, since the default remote address is a local one and it's the client side, there's no real logical change since the kernel would anyway should have taken a local address anyway. Change-Id: I3c07e6aa0c87b752c9ea22eb4936f6993de6571f
2020-07-29Provide more context when logging "Error in ANY_fromType_aper"Harald Welte3-15/+15
Let's add the type name whose encoding failed to give us some kind of a clue what's happening in those situations. Change-Id: I802677ba7164a4d3382d4bc00f5e1c7ab7067d89
2020-05-19Fix OneDefinitionRule Asan violation in tests and osmo-hnbgwPau Espin Pedrol5-10/+6
With new gcc 10.1.0, tests failed at runtime when built with ASAN enabled, since some global variables where defined multiple times. See OS#4556 for a sample Asan error. Fixes: OS#4556 Change-Id: I12a667ea8a9f16404c13c9218b246d2e3acfe3e8
2020-05-19tests: Fix trailing whitespacePau Espin Pedrol2-2/+2
Change-Id: I3ef7a3f1c3247615619a0d01c92d8f80572b0dfe
2020-04-20Fix compilation with gcc-10Harald Welte1-1/+1
/usr/bin/ld: test_common.o:(.bss+0x0): multiple definition of `talloc_asn1_ctx'; test-helpers.o:(.bss+0x0): first defined here See also https://alioth-lists.debian.net/pipermail/debian-mobcom-maintainers/Week-of-Mon-20200413/000652.html Change-Id: I4ce41158bb27e6b9242613106f226fc86995c53c
2020-04-14hnbgw: do not use LOGL_DEBUG as default loglevelPhilipp Maier1-4/+4
The hnbgw application uses LOGL_DEBUG for all its log categories. This is way to verbose, lets set LOGL_NOTICE as default loglevel instead. Change-Id: If3dbed88307814764bab9e7f1821e1dc0d8be43b Related: OS#2577
2020-04-07tests/test-ranap: cosmetic: remove unused variable 'rc'Vadim Yanitskiy1-1/+1
Change-Id: Ie931d11efd7bb083558852a7f329c984c17fec62
2020-04-07tests/test-helpers: fix endianness: do not print uint32_t as raw bytesVadim Yanitskiy2-3/+2
This unit test would not pass on big-endian machines. Change-Id: I60dbcaa89b031c9a81c35e1dd0d9c963d486014c
2020-04-07tests/test-helpers: fix some -Wpointer-sign warnings reported by GCCVadim Yanitskiy1-10/+10
Change-Id: I7ebc99fe919fe7ba515c9d8ba601dceb820bf11f
2020-03-20hnbgw_vty.c: Drop unusued variablesPau Espin Pedrol1-3/+1
Change-Id: Ic7f730c9f51384006e471b5e8452f5821b458bbf
2020-03-20Fix compiler warning on signedness of char ptr using OCTET_STRING_fromBuf()Pau Espin Pedrol2-14/+14
rua_msg_factory.c:19:48: warning: pointer targets in passing argument 2 of ‘OCTET_STRING_fromBuf’ differ in signedness [-Wpointer-sign] Change-Id: Ie0a2e8e11902dc56720ff8121edde0e148fa587a
2020-03-20tests/test-ranap.c: Fix wrong printf formatPau Espin Pedrol1-2/+2
Caught by compiler: test-ranap.c:54:30: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘RANAP_MaxBitrate_t’ {aka ‘long int’} [-Wformat=] test-ranap.c:78:30: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘RANAP_CauseMisc_t’ {aka ‘long int’} [-Wformat=] Change-Id: Icc4e81beaa35e13aea3adfed983016c78b730061
2020-03-20tests/hnb-test-ranap.c: Fix wrong printf formatPau Espin Pedrol1-1/+1
Catched by compiler: hnb-test-ranap.c:76:44: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘RANAP_CN_DomainIndicator_t’ {aka ‘long int’} [-Wformat=] Change-Id: Ie4cd6a36fd0e9a871a1815d600e8a321a3d2a208
2020-02-15tests: Missing return statementMartin Hauke2-1/+2
Change-Id: I4fae9f84a83af280846b07eaa139ff4a05784a2e
2020-01-03Bump version: 0.5.0.23-11a1 → 0.6.00.6.0Pau Espin Pedrol1-1/+1
Change-Id: I5f42c0ad1a930004415f097d984e1fd1b2d277e6
2020-01-01osmo-hnbgw: make sure osmo_ss7_init() executed successfullyVadim Yanitskiy1-1/+5
Change-Id: Ia9ecf903e79b282aa4fa88a291424681d0fe9d89 Fixes: CID#206089
2019-12-03exit(2) on unsupported positional arguments on command lineHarald Welte1-0/+5
Change-Id: Id33caf93325074f9e5b2b322ac497b1c21c3f406
2019-10-08iu_client: ranap_iu_tx_release() change default cause code to SuccessAlexander Couzens1-3/+3
The cause code no remaining rab should be only used when closing the Iu connection on this specific reason. Change default to NAS Success Release which is a usual release. Change-Id: Icf3f06b0de7dcda9f967ae29863054ef813c75e5
2019-10-03iu_client: pass return value of osmo_sccp_user_sap_down() towards the callerAlexander Couzens1-7/+3
osmo_sccp_user_sap_down return 0 on success, negative values on failure Change-Id: I3b7c2296eb8b26f0881cee643b834336daab86ea
2019-09-23sabp: Generate C/H files for SABP; create libosmo-sabpHarald Welte65-6/+8871
This uses the (modified) Osmocom asn1c on the (modified) SABP ASN.1 syntax to generate C code + header files for SABP parsing/encoding. It also adds some helper code for message encoding and decoding as well as a new libosmo-sabp shared library which can be used by programs to implement SABP related functionality. Change-Id: Ib9580d1af96354398da4c9f97b28a0e23d56e275
2019-09-20hnbgw: Add libosmoctrl's VTY CTRL command initializationPau Espin Pedrol1-0/+1
Otherwise, the "ctrl" VTY node is not available and CTRL ip address cannot be set. Change-Id: I73f64b951690ec23f829c4855b2caeefa66ad35d
2019-09-16iu_client: introduce UE field free_on_releaseAlexander Couzens1-0/+9
Allow to free UE ctx when receiving a Iu Release Complete. In preparation of ranap_iu_tx_release_free() it requires a field to free the Iu ctx on it's own without depending on the upstream user. Change-Id: Iac41cd3cce3232d01b2f7ede0cc46226c2cfb6c0
2019-09-15iu_client: introduce ranap_iu_tx_release_free()Alexander Couzens1-0/+18
ranap_iu_tx_release_free is a fire and forget function to release gracefully if possible. It first sends a Iu Release Command. After a certain timeout the connection will be released. Change-Id: I349e2c61ba0131e233b7ab927dfced0bd461dd8f
2019-09-12iu_client: allow to control the notificationsAlexander Couzens1-0/+4
The iu_client is informing the library user about global event. In prepration to the tx_iu_release_free() call allow to disable upstream notificatiosn Change-Id: Ic93ef6fd54c995405e9c37a5e0c53f81a89850b7
2019-09-10iu_client: introduce a guard around global_iu_event_cbAlexander Couzens1-4/+14
As preparation to enable and disable notifications for a specific ue connection, add a slim proxy before calling global_iu_event_cb Change-Id: I49a3402a871d6dccd343cda49f8a7f82bffe150b
2019-09-03iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indicationAlexander Couzens1-0/+7
Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420
2019-09-03iu_client: introduce ranap_iu_free_ue() to free the UE connectionsAlexander Couzens1-0/+10
When freeing the UE connection object, disconnect the SCCP connection. Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b
2019-09-03iu_client: sccp_sap_up: don't decode empty disconnect indicationsAlexander Couzens1-1/+3
Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900
2019-09-03iu_client: ensure UE is not NULL on CO primitivesAlexander Couzens1-0/+6
When ue_conn_ctx_find() can not find a UE it returns NULL. Change-Id: I63222fda6778417b1c986cb05772fecc51c43bb5
2019-09-03iu_client: sccp_sap_up: set rc earlyAlexander Couzens1-3/+1
Allows to skip assignment later. Change-Id: Idd803774612719df144bef569fb734289aa31282
2019-08-23hnbgw_vty.c: fix: properly pass pointer to g_hnb_gwVadim Yanitskiy1-1/+1
Otherwise the process hangs if the user enters: $ show hnb NAME hnbgw_vty.c: In function ‘show_one_hnb’: hnbgw_vty.c:234:2: warning: passing argument 1 of ‘hnb_context_by_identity_info’ from incompatible pointer type [enabled by default] iuh/hnbgw.h:154:21: note: expected ‘struct hnb_gw *’ but argument is of type ‘struct hnb_gw **’ Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f
2019-08-07Bump version: 0.4.0.14-92ea-dirty → 0.5.00.5.0Pau Espin Pedrol1-1/+1
Change-Id: I53c1743eda203bf075f93f891e336ca4ec6866a8
2019-08-05Remove undefined param passed to {logging,osmo_stats}_vty_add_cmdsPau Espin Pedrol1-1/+1
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. Change-Id: I31a286bebe3229671d9960ae32a753d260a26b1d Related: OS#4138
2019-07-16spelling stuff found by lintianThorsten Alteholz1-1/+1
Change-Id: I8434640701746d5db8707472d1d26c313e0814e9
2019-04-20ranap_msg_factory: Fix criticality of PDUsHarald Welte2-10/+10
Seveal of our RANAP messages were using criticality values at the PDU level differing from what RANAP_PDU_Descriptions.asn states for the respective procedures. Let's fix that. This was discovered while working on the initial IuCS TTCN3 tests, where the receive templates require the criticality to match. Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95
2019-04-20iu_client: Implement transmission of ResetAcknowledgeHarald Welte1-3/+19
When receiving an Iu Reset, respond with Iu ResetAcknowledge. Closes: OS#3944 Change-Id: Ia09752983a7e2a952aa144635924edbffd894058
2019-03-19tests: use -no-install libtool flag to avoid ./lt-* scriptsOliver Smith1-0/+2
This ensures that the rpath of the generated binaries is set to use only the just-compiled so-files and not any system-wide installed libraries while avoiding the ugly shell script wrapper. Change-Id: I92c7391631becc09d277981179c23f2e4dba3b54
2019-03-08osmo-hnbgw: reply with RESET ACK when receiving a RESETNeels Hofmeyr1-10/+42
Rationale: current osmo-msc refactoring introduces RESET handling on IuCS. In particular, it makes osmo-hnbgw be able to operate with an (upcoming) osmo-msc that has strict RESET handling: it will send a RESET and require a RESET ACK if it sees a new IuCS peer sending messages without prior RESET. Even though a workaround to ignore missing RESET messages on IuCS will also be in place in the new osmo-msc, this is a first small step towards more sane RESET handling in osmo-hnbgw. Related: OS#3820 Change-Id: I02bc74ef9fef61f4490b4d4dc3ce6c0a6d965909
2019-03-08osmo-hnbgw: logging tweaksNeels Hofmeyr2-0/+7
Log about: - sending RESET messages to CN; - accepting a new hNodeB peer on HNBAP. Change-Id: I317831dbc6c463e4d4dcde9e6716431e026c4398
2019-03-04osmo-hnbgw: set a proper talloc ctx for loggingNeels Hofmeyr1-1/+1
Change-Id: I006103d8d7fb15e2612fff619879940d8405e045
2019-03-04osmo-hnbgw: fix cmdline: do not force-disable colored loggingNeels Hofmeyr1-1/+1
Un-jam the commandline option to disable color: it is so far stuck in --disable-color and overrides everything so that we never see any colored logging from osmo-hnbgw, whichever cmdline or cfg we pass. Change-Id: I00400b626925fa9da707ad6679d8448941dbfa98
2019-01-20Bump version: 0.3.0.10-9e66-dirty → 0.4.00.4.0Harald Welte1-1/+1
Change-Id: Ib2943b7fd0a1f7ca79f761116cba30aa3aa29b88
2018-10-31add a VTY command which shows a specific HNBStefan Sperling2-1/+36
Add the 'show hnb NAME' VTY command which displays just one specific HNB, addressed by its identity string. This augments the functionality provided by 'show hnb all'. Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6 Related: OS#2774
2018-10-21hnbgw_tx_hnb_register_rej(): Missing return statementHarald Welte1-0/+3
Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158 Fixes: Coverity CID#188869
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-10 15:36:12 +0000