aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-22iu_client: try to fix itcccamp2019Alexander Couzens1-0/+5
Change-Id: Ie50f1b07ec0376a2e88744f1b17aeacf07f645ee
2019-08-21iu_client: add backtrace log messageAlexander Couzens1-0/+1
Change-Id: Ie9d28f5e633edd048b6bcc20ad2e25d8be36acfd
2019-08-21iu_client: add log messageAlexander Couzens1-0/+1
Change-Id: I426a2f533381bcdffc681add1d4a5056f09564e7
2019-08-21try to fix ranap_iu_free_ue()Alexander Couzens1-1/+2
Change-Id: I7013e2477b0dc4cbfbe150864e8021f044deae69
2019-08-21Revert "HACK: iu_client: check if entry is in the list"Alexander Couzens1-14/+0
This reverts commit 90691ca53b48322c8870b6372a887fe74c51fe1b.
2019-08-21HACK: iu_client: check if entry is in the listAlexander Couzens1-0/+14
this should only happen in case of double free :D Change-Id: Ia1281661d450da4f2d2460ff9dfb48fa0c082ea5
2019-08-20iu_client: introduce a connection stateAlexander Couzens2-1/+11
When the SCCP stack indicate a disconnect, save this in the UE connection to allow the application to free() the instance later. Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3
2019-08-20iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indicationAlexander Couzens1-0/+2
Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420
2019-08-20iu_client: introduce ranap_iu_free_ue() to free the UE connectionsAlexander Couzens2-0/+14
When freeing the UE connection object, disconnect the SCTP connection. Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b
2019-08-20iu_client: sccp_sap_up: don't decode empty disconnect indicationsAlexander Couzens1-1/+3
Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900
2019-08-20iu_client: ensure UE is not NULL on CO primitivesAlexander Couzens1-0/+6
When ue_conn_ctx_find() can not find a UE it returns NULL. Change-Id: I63222fda6778417b1c986cb05772fecc51c43bb5
2019-08-20iu_client: sccp_sap_up: set rc earlyAlexander Couzens1-3/+1
Allows to skip assignment later. Change-Id: Idd803774612719df144bef569fb734289aa31282
2019-08-20iu_client: define RANAP_IU_EVENT_SECURITY_MODE_FAILEDAlexander Couzens2-0/+2
To inform the application about failed security modes Change-Id: I14bb9904728eddf7a5742df8382fb204ccda20dd
2019-08-20hnb register: on duplicate cells, log both cellsNeels Hofmeyr1-2/+6
Change-Id: I002852e4fa421118201af5dee632d9f1968c469d
2019-08-07Bump version: 0.4.0.14-92ea-dirty → 0.5.00.5.0Pau Espin Pedrol4-11/+40
Change-Id: I53c1743eda203bf075f93f891e336ca4ec6866a8
2019-08-05Remove undefined param passed to {logging,osmo_stats}_vty_add_cmdsPau Espin Pedrol1-1/+1
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. Change-Id: I31a286bebe3229671d9960ae32a753d260a26b1d Related: OS#4138
2019-07-30jenkins: Enable manual publishing and buildingDaniel Willmann1-2/+13
Related: OS#2589 Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925
2019-07-29Add VTY reference manualDaniel Willmann7-1/+1651
Fixes: OS#2589 Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5
2019-07-17osmo-hnbgw.cfg: set local-ip to 0.0.0.0Oliver Smith1-1/+1
Make the config work out of the box for anyone. Related: OS#3369 Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec
2019-07-16spelling stuff found by lintianThorsten Alteholz1-1/+1
Change-Id: I8434640701746d5db8707472d1d26c313e0814e9
2019-07-10contrib/jenkins.sh: run "make maintainer-clean"Oliver Smith1-0/+1
Related: OS#3047 Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb
2019-04-20ranap_msg_factory: Fix criticality of PDUsHarald Welte2-10/+10
Seveal of our RANAP messages were using criticality values at the PDU level differing from what RANAP_PDU_Descriptions.asn states for the respective procedures. Let's fix that. This was discovered while working on the initial IuCS TTCN3 tests, where the receive templates require the criticality to match. Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95
2019-04-20iu_client: Implement transmission of ResetAcknowledgeHarald Welte1-3/+19
When receiving an Iu Reset, respond with Iu ResetAcknowledge. Closes: OS#3944 Change-Id: Ia09752983a7e2a952aa144635924edbffd894058
2019-03-19tests: use -no-install libtool flag to avoid ./lt-* scriptsOliver Smith1-0/+2
This ensures that the rpath of the generated binaries is set to use only the just-compiled so-files and not any system-wide installed libraries while avoiding the ugly shell script wrapper. Change-Id: I92c7391631becc09d277981179c23f2e4dba3b54
2019-03-08osmo-hnbgw: reply with RESET ACK when receiving a RESETNeels Hofmeyr1-10/+42
Rationale: current osmo-msc refactoring introduces RESET handling on IuCS. In particular, it makes osmo-hnbgw be able to operate with an (upcoming) osmo-msc that has strict RESET handling: it will send a RESET and require a RESET ACK if it sees a new IuCS peer sending messages without prior RESET. Even though a workaround to ignore missing RESET messages on IuCS will also be in place in the new osmo-msc, this is a first small step towards more sane RESET handling in osmo-hnbgw. Related: OS#3820 Change-Id: I02bc74ef9fef61f4490b4d4dc3ce6c0a6d965909
2019-03-08osmo-hnbgw: logging tweaksNeels Hofmeyr2-0/+7
Log about: - sending RESET messages to CN; - accepting a new hNodeB peer on HNBAP. Change-Id: I317831dbc6c463e4d4dcde9e6716431e026c4398
2019-03-04osmo-hnbgw: set a proper talloc ctx for loggingNeels Hofmeyr1-1/+1
Change-Id: I006103d8d7fb15e2612fff619879940d8405e045
2019-03-04osmo-hnbgw: fix cmdline: do not force-disable colored loggingNeels Hofmeyr1-1/+1
Un-jam the commandline option to disable color: it is so far stuck in --disable-color and overrides everything so that we never see any colored logging from osmo-hnbgw, whichever cmdline or cfg we pass. Change-Id: I00400b626925fa9da707ad6679d8448941dbfa98
2019-01-22ranap_msg_factory.h: fix enum def within function signatureNeels Hofmeyr1-0/+1
Include RANAP_KeyStatus.h so that we use the global enum RANAP_KeyStatus instead of defining another only within the ranap_new_msg_sec_mod_cmd() function declaration. Change-Id: Ifefaab32afa962dacdaa738a5419cce0a65a4b22
2019-01-20Bump version: 0.3.0.10-9e66-dirty → 0.4.00.4.0Harald Welte2-1/+32
Change-Id: Ib2943b7fd0a1f7ca79f761116cba30aa3aa29b88
2018-12-06contrib: fix makedistcheck with disabled systemdOliver Smith1-1/+2
EXTRA_DIST files need to be distributed, no matter if the systemd option is configured or not. Change-Id: I8e1615793bc89fdc3b0549c150cc10d848e56645
2018-12-04Fix DISTCHECK_CONFIGURE_FLAGS overrideOliver Smith1-1/+1
Set AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am instead of DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from the automake manual, as otherwise the flag can't be changed by the user anymore. Related: OS#3718 Change-Id: I3cfc4ccf799108ee2f411be443069c88a013df5b
2018-10-31add a VTY command which shows a specific HNBStefan Sperling3-1/+37
Add the 'show hnb NAME' VTY command which displays just one specific HNB, addressed by its identity string. This augments the functionality provided by 'show hnb all'. Change-Id: Iab12aa4ab090b72c472358b84daf6919b30747f6 Related: OS#2774
2018-10-21hnbgw_tx_hnb_register_rej(): Missing return statementHarald Welte1-0/+3
Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158 Fixes: Coverity CID#188869
2018-09-30fix transport layer addr again, for nano3gNeels Hofmeyr1-1/+1
The nano3G sends the RAB Assignment Response's Transport Layer Address in X.213 NSAP padded to 20 bytes (160bit). Do not interpret it as 4-byte IP address, which currently breaks nano3G voice calls (wrong RTP IP address). Recent commit I2cd1b2d8e1c1ae707cfc0dc7961a2b31ecdf29e0 fixed decoding of X.213 NSAP that is exactly seven bytes, but broke decoding of the padded version from the nano3G. A proper X.213 NSAP decoding would still be more welcome than this patching back and forth, but this is (another) quick fix without spending too much time on it. Related: OS#3420 Change-Id: I0ad8bce6fcfd3829394c39490058c1ab85cdfde3
2018-09-27hnbgw: vty: add SCCP related vty commandsNeels Hofmeyr1-0/+1
Depends: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e (libosmo-sccp) Change-Id: I2f81e078d7a26dd39f8ff9d0f9273ee1a3434232
2018-09-12Install sample cfg file to /etc/osmocompespin/systemdPau Espin Pedrol2-0/+5
Change-Id: I7476a1db470d3bc3a833e7657ad29f266df51667
2018-09-10Install systemd services with autotoolsPau Espin Pedrol7-2/+32
Change-Id: I90f1efc4433ec641a28931d5c19e2301a67cf1e9
2018-09-06debian: package osmo-hnbgw.servicePau Espin Pedrol1-0/+1
Change-Id: I7b488ddb07916952adab921415ca373aa7c5c1e8
2018-08-20fix decoding of incoming X.213 NSAP addrNeels Hofmeyr1-1/+1
Fix ranap_transp_layer_addr_decode() to test == 7 instead of > 7: If a femto cell sends its Transport Layer Address as X.213 NSAP IPv4, we receive 3 header bytes and four IP-address bytes, so the length is exactly 7. This function is very vague on numerous other decoding details, but this patch only fixes the vital length check that makes 3G usable with X.213 NSAP. Related: OS#3420 Change-Id: I2cd1b2d8e1c1ae707cfc0dc7961a2b31ecdf29e0
2018-08-06debian/rules: Don't overwrite .tarball-versionHarald Welte1-4/+0
The .tarball-version file should contain the *source version* uniquely identifying the git commit, and not the Debian package name. With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct .tarball-version file in the .tar.xz of the nightly source packages. Change-Id: I08fa724a9a70e024845f683fb3f5d245a0bd9aa3 Related: OS#3449
2018-07-24hnbgw: remove close_cb() to fix a crash when releasing a hnbgwAlexander Couzens3-19/+8
The read callback should catch all errors already. Previous when a read fails it: * hnb_context_release() -> osmo_stream_srv_destroy() -> hnb_context_release() On the second hnb_context_release() the hnbgw will crash because calling llist_del() twice on the same object. Fixes: OS#3416 Change-Id: Ic84b2184b7fc850c0de2acacf179e86771e17510
2018-05-30asn1tostruct: allow to override build dateBernhard M. Wiedemann1-2/+3
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Also do not record build user name to not have it vary. Change-Id: I5cfa465cc82f009f28dd7f12ced0e72a05fda842
2018-05-03Bump version: 0.2.0.57-cf5f-dirty → 0.3.00.3.0Pau Espin Pedrol5-11/+85
Change-Id: Id5d2f749bca46e8b81cc2934447707e3db80ea18
2018-05-03debian/changelog: set prev releases to unstablePau Espin Pedrol1-2/+2
Otherwise it fools osmo-release.mk Change-Id: I6c05bb7f5bb2b3e78283a5eae6ccf95ce86838f8
2018-03-21cosmetic: use osmo_plmn_id instead of mcc,mncNeels Hofmeyr1-4/+2
It's cosmetic since the MCC and MNC in the PLMN aren't actually used, currently. It makes sense to do it properly anyway, while I'm still in the 3-digit MNC topic, for the future. Change-Id: I29ebcddd45fe3079f8883589a83cc7216a535475
2018-03-05configure: add --enable-werrorNeels Hofmeyr1-0/+21
Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Id659512d2d9fb3f28584ec5f071907f6b6e72e0d
2018-02-28hnb-test: log accurate three-digit MNC with leading zerosNeels Hofmeyr1-4/+5
Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore) Change-Id: Ie3dd206bca2f38a0ef7ee7f9d3b6bf2eacc899a4
2018-02-22ensure unique CellIDs in HNB-GWStefan Sperling3-6/+73
If we receive a HNB-REGISTER-REQ with a cell ID which is already used by another registered NNB, log an error and send HNB-REGISTER-REJECT. Tested manually by running two 'hnb-test' programs concurrently (they need to listen on different telnet ports; this port is hard-coded so I compiled two different hnb-test binaries). Then I issued the 'hnbap hnb register' command on the telnet interface of each, and verified that the correct action is logged by osmo-hnbgw. Both hnb-test programs can connect, but only one of them can register at a time. Killing a registered 'hnb-test' program terminates its connection and allows the previously rejected one to register. The new rejection log message looks like this: hnbgw_hnbap.c:429 rejecting HNB-REGISTER-REQ with duplicate cell identity MCC=901,MNC=99,LAC=49406,RAC=66,SAC=43947,CID=182250155 from (r=127.0.0.1:42828<->l=127.0.0.1:29169) This change depends on a new API in libosmo-netif, which is added in https://gerrit.osmocom.org/#/c/6844/ Change-Id: Iffd441eb2b6b75dfbe001b49b01bea015ca6e11c Depends: I8ed78fe39c463e9018756700d13ee5ebe003b57f Related: OS#2789
2018-02-20contrib: jenkins.sh: Disable doxygen in libosmocore buildPau Espin Pedrol1-1/+1
Change-Id: I12d995c0c993483ed940fc173904d6e686fbe0ab