diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2023-09-01 03:39:50 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2023-09-13 23:04:11 +0200 |
| commit | a7201daaf991371ff972926abf9abe9283467286 (patch) | |
| tree | 3241e55100b932bb781ac50f08e1530814578dce | |
| parent | 00986ff67808911eee0d73d40e73e96cc94d6003 (diff) | |
ranap rab: adjust SDU pars according to specneels/dev
3GPP TS 26.102 Table 5-1 gives some fixed values in an example. Try
them.
Change-Id: I82ae0c7537a95a6a24e95d75c362e169eaa75de2
| -rw-r--r-- | src/ranap_msg_factory.c | 12 | ||||
| -rw-r--r-- | tests/test-ranap.ok | 10 |
2 files changed, 15 insertions, 7 deletions
diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index 8ddc68d..fbc2cb7 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -612,19 +612,27 @@ static RANAP_SDU_ParameterItem_t *new_sdu_par_item(enum sdu_par_profile profile, switch (profile) { case SDUPAR_P_VOICE0: + /* Values according to 3GPP TS 26.102 Table 5-1 */ sdui->sDU_ErrorRatio = new_sdu_error_ratio(7, 3); sdui->residualBitErrorRatio.mantissa = 1; - sdui->residualBitErrorRatio.exponent = 4; + sdui->residualBitErrorRatio.exponent = 6; sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_yes; /* continue below to add SDU subflows */ break; case SDUPAR_P_VOICE1: - case SDUPAR_P_VOICE2: + /* Values according to 3GPP TS 26.102 Table 5-1 */ sdui->residualBitErrorRatio.mantissa = 1; sdui->residualBitErrorRatio.exponent = 3; sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_no_error_detection_consideration; /* continue below to add SDU subflows */ break; + case SDUPAR_P_VOICE2: + /* Values according to 3GPP TS 26.102 Table 5-1 */ + sdui->residualBitErrorRatio.mantissa = 5; + sdui->residualBitErrorRatio.exponent = 3; + sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_no_error_detection_consideration; + /* continue below to add SDU subflows */ + break; case SDUPAR_P_DATA: sdui->sDU_ErrorRatio = new_sdu_error_ratio(1, 4); sdui->residualBitErrorRatio.mantissa = 1; diff --git a/tests/test-ranap.ok b/tests/test-ranap.ok index 5784781..2f9c705 100644 --- a/tests/test-ranap.ok +++ b/tests/test-ranap.ok @@ -88,8 +88,8 @@ Decoded Cause Misc=115 <id>53</id> <firstCriticality><reject/></firstCriticality> <firstValue> - 78 02 CD 80 10 2F A7 20 2F A8 00 00 F4 4C 64 06 - 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 20 + 78 02 CD 80 10 2F A7 20 2F A8 00 00 F4 4C 64 0A + 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 64 3D 02 00 02 27 C0 35 00 01 0A 0B 0C 0D 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 @@ -102,14 +102,14 @@ Decoded Cause Misc=115 <criticality><ignore/></criticality> <value> 00 00 01 00 35 00 48 78 02 CD 80 10 2F A7 20 2F - A8 00 00 F4 4C 64 06 02 80 00 51 40 00 27 20 28 - 14 00 67 40 00 00 20 28 14 00 3C 40 00 00 00 64 + A8 00 00 F4 4C 64 0A 02 80 00 51 40 00 27 20 28 + 14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 64 3D 02 00 02 27 C0 35 00 01 0A 0B 0C 0D 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 </value> </RANAP_IE> -00 00 00 59 00 00 01 00 36 40 52 00 00 01 00 35 00 48 78 02 cd 80 10 2f a7 20 2f a8 00 00 f4 4c 64 06 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 20 28 14 00 3c 40 00 00 00 64 3d 02 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 +00 00 00 59 00 00 01 00 36 40 52 00 00 01 00 35 00 48 78 02 cd 80 10 2f a7 20 2f a8 00 00 f4 4c 64 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 64 3d 02 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 ==> RAB ASSIGNMENT COMMAND (DATA) <RANAP_ProtocolIE-FieldPair> |