From 743cf42ac5dfa2661317e73f70b204bde7450ff2 Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <neels@hofmeyr.de>
Date: Thu, 16 Mar 2017 20:38:44 +0100
Subject: fix db_subscr_ps error handling

Reset stmt and return right away on failure to execute.

Change-Id: I27e8b46915efd678c72138e250a9cbb4c9c8ac20
Fixes: Coverity Scan CID#164747
---
 src/db_hlr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/db_hlr.c b/src/db_hlr.c
index 340e7ce..f6ae18f 100644
--- a/src/db_hlr.c
+++ b/src/db_hlr.c
@@ -92,7 +92,8 @@ int db_subscr_ps(struct db_context *dbc, const char *imsi, bool enable)
 	rc = sqlite3_step(stmt); /* execute the statement */
 	if (rc != SQLITE_DONE) {
 		LOGHLR(imsi, LOGL_ERROR, "Error executing SQL: %d\n", rc);
-		rc = -ENOEXEC;
+		db_remove_reset(stmt);
+		return -ENOEXEC;
 	}
 
 	rc = sqlite3_changes(dbc->db); /* verify execution result */
-- 
cgit v1.2.3