diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2017-10-06 03:50:30 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2017-10-10 23:43:52 +0200 |
| commit | f23fa4b75bbf44005cf85c6007df1bf38cbfc9ea (patch) | |
| tree | 2f4158e72ffbcaa65aa30d1273f4f35e88f1b060 /tests/db/db_test.err | |
| parent | 7c13aa3fbb7e6ac470148ee6f026ac9bede48636 (diff) | |
less noise: simplify db_remove_reset()
db_remove_reset() needs to be called after each stmt run, whether it succeeded
or not.
In case sqlite3_clear_bindings() would fail to unbind a stmt, we would anyway
be beyond recovery. There seem to be no plausible situations where such failure
would occur, unless there have been no bindings in the first place.
In case there was an SQL stmt failure, sqlite3_reset() will re-barf the same
error message, we will always have logged it earlier already in the proper
context.
We are never evaluating the return value, nor would we know how to recover from
non-success.
The conclusions:
- db_remove_reset() does not need to log any errors.
- db_remove_reset() does not need to return success.
Change-Id: I21678463e59f607f5f5c5732963e274392f0fffd
Diffstat (limited to 'tests/db/db_test.err')
| -rw-r--r-- | tests/db/db_test.err | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/tests/db/db_test.err b/tests/db/db_test.err index ac0e2f1..1b08cec 100644 --- a/tests/db/db_test.err +++ b/tests/db/db_test.err @@ -29,7 +29,6 @@ struct hlr_subscriber { db_subscr_create(dbc, imsi0) --> -EIO DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]: UNIQUE constraint failed: subscriber.imsi -DDB Error in sqlite3_reset: 2067 DAUC IMSI='123456789000000': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi0, &g_subscr) --> 0 @@ -40,12 +39,10 @@ struct hlr_subscriber { db_subscr_create(dbc, imsi1) --> -EIO DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]: UNIQUE constraint failed: subscriber.imsi -DDB Error in sqlite3_reset: 2067 DAUC IMSI='123456789000001': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_create(dbc, imsi1) --> -EIO DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]: UNIQUE constraint failed: subscriber.imsi -DDB Error in sqlite3_reset: 2067 DAUC IMSI='123456789000001': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi1, &g_subscr) --> 0 @@ -56,12 +53,10 @@ struct hlr_subscriber { db_subscr_create(dbc, imsi2) --> -EIO DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]: UNIQUE constraint failed: subscriber.imsi -DDB Error in sqlite3_reset: 2067 DAUC IMSI='123456789000002': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_create(dbc, imsi2) --> -EIO DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]: UNIQUE constraint failed: subscriber.imsi -DDB Error in sqlite3_reset: 2067 DAUC IMSI='123456789000002': Cannot create subscriber: SQL error: (2067) UNIQUE constraint failed: subscriber.imsi db_subscr_get_by_imsi(dbc, imsi2, &g_subscr) --> 0 |